From 5c14e371f7d4455411e7e6119aa5ac0db01b78f2 Mon Sep 17 00:00:00 2001 From: Haoyin Xu Date: Thu, 10 Jul 2025 14:44:14 -0400 Subject: [PATCH 1/5] FIX correct if statement --- .github/workflows/main.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/main.yml b/.github/workflows/main.yml index 492f70850..48e33f6ba 100644 --- a/.github/workflows/main.yml +++ b/.github/workflows/main.yml @@ -85,7 +85,7 @@ jobs: pip install -r test_requirements.txt - name: Install nightly wheels for scikit-learn (only for ubuntu 3.12) - if: ${{ matrix.python-version == '3.12' }} && ${{ matrix.os == 'ubuntu-latest' }} + if: ${{ matrix.python-version == '3.12' && matrix.os == 'ubuntu-latest' }} run: | pip install --pre --extra-index https://pypi.anaconda.org/scientific-python-nightly-wheels/simple scikit-learn --force From cd695535a9b459f4cbc3c2e63bba0779f1835964 Mon Sep 17 00:00:00 2001 From: Haoyin Xu Date: Thu, 10 Jul 2025 14:45:13 -0400 Subject: [PATCH 2/5] MAINT specify sklearn version --- build_requirements.txt | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/build_requirements.txt b/build_requirements.txt index ec63cfb3b..90af56671 100644 --- a/build_requirements.txt +++ b/build_requirements.txt @@ -3,7 +3,7 @@ meson-python>=0.16.0 cython>=3.0.10 ninja numpy -scikit-learn>=1.5.0 +scikit-learn~=1.6.0 click rich-click doit From a031e06be0078c425d2f8be469fefc4dc427d1d7 Mon Sep 17 00:00:00 2001 From: Haoyin Xu Date: Thu, 10 Jul 2025 14:45:35 -0400 Subject: [PATCH 3/5] MAINT specify sklearn version --- pyproject.toml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/pyproject.toml b/pyproject.toml index 2bb8c6a23..543e0e767 100644 --- a/pyproject.toml +++ b/pyproject.toml @@ -10,7 +10,7 @@ requires = [ "setuptools<=65.5", "packaging", "Cython>=3.0.10", - "scikit-learn>=1.6.0", + "scikit-learn~=1.6.0", "scipy>=1.5.0", "numpy>=1.25; python_version>='3.9'" ] From 20f76c674b43cba7d5384e09edd362052b1af2e7 Mon Sep 17 00:00:00 2001 From: Haoyin Xu Date: Thu, 10 Jul 2025 14:46:35 -0400 Subject: [PATCH 4/5] MAINT remove sklearn nightly --- .circleci/config.yml | 1 - 1 file changed, 1 deletion(-) diff --git a/.circleci/config.yml b/.circleci/config.yml index 8f5c98550..6d76eb045 100644 --- a/.circleci/config.yml +++ b/.circleci/config.yml @@ -84,7 +84,6 @@ jobs: pip install --upgrade pip spin spin setup-submodule pip install .[build,doc] - pip install --pre --extra-index https://pypi.anaconda.org/scientific-python-nightly-wheels/simple scikit-learn --force - run: name: build treeple From a00587264a1bb48f8b1258e411b5438ba5a427dc Mon Sep 17 00:00:00 2001 From: Haoyin Xu Date: Thu, 10 Jul 2025 14:47:27 -0400 Subject: [PATCH 5/5] MAINT remove extra sklearn nightly --- .github/workflows/main.yml | 2 -- 1 file changed, 2 deletions(-) diff --git a/.github/workflows/main.yml b/.github/workflows/main.yml index 48e33f6ba..c4cb3b447 100644 --- a/.github/workflows/main.yml +++ b/.github/workflows/main.yml @@ -189,7 +189,6 @@ jobs: pip install compilers pip install -r build_requirements.txt pip install -r test_requirements.txt - pip install --pre --extra-index https://pypi.anaconda.org/scientific-python-nightly-wheels/simple scikit-learn --force - name: Prepare compiler cache id: prep-ccache @@ -285,7 +284,6 @@ jobs: pip install spin pip install -r build_requirements.txt pip install -r test_requirements.txt - pip install --pre --extra-index https://pypi.anaconda.org/scientific-python-nightly-wheels/simple scikit-learn --force - name: Build run: |