https: honor per-request TLS options over agent options #60717
commit-lint.yml
on: pull_request_target
lint-commit-message
24s
Annotations
1 error and 1 warning
|
lint-commit-message
# 7145186191b75084a0b1b3fda123bd3b1c0bacc3
ok 1 assisted-by-is-trailer: no Assisted-by metadata
ok 2 co-authored-by-is-trailer: no Co-authored-by metadata
ok 3 fixes-url: skipping fixes-url # SKIP
ok 4 line-after-title: blank line after title
not ok 5 line-length: Line should be <= 72 columns.
---
{
found: 75,
compare: '<=',
wanted: 72,
at: {
line: 4,
column: 72,
body: [
'',
'Per-request rejectUnauthorized/ca/servername were silently ignored when the',
'https.Agent set the same option, because http.Agent merges request options',
"over the agent's own, letting the agent win. Capture the per-request overrides",
'and re-apply them in createConnection(), mirroring the checkServerIdentity',
'handling from CVE-2026-58040.',
'',
'Refs: https://github.com/nodejs/node/commit/52a8ace880d',
'Signed-off-by: axedos <acceleratingssoul@proton.me>'
]
}
}
...
not ok 6 line-length: Line should be <= 72 columns.
---
{
found: 74,
compare: '<=',
wanted: 72,
at: {
line: 5,
column: 72,
body: [
'',
'Per-request rejectUnauthorized/ca/servername were silently ignored when the',
'https.Agent set the same option, because http.Agent merges request options',
"over the agent's own, letting the agent win. Capture the per-request overrides",
'and re-apply them in createConnection(), mirroring the checkServerIdentity',
'handling from CVE-2026-58040.',
'',
'Refs: https://github.com/nodejs/node/commit/52a8ace880d',
'Signed-off-by: axedos <acceleratingssoul@proton.me>'
]
}
}
...
not ok 7 line-length: Line should be <= 72 columns.
---
{
found: 78,
compare: '<=',
wanted: 72,
at: {
line: 6,
column: 72,
body: [
'',
'Per-request rejectUnauthorized/ca/servername were silently ignored when the',
'https.Agent set the same option, because http.Agent merges request options',
"over the agent's own, letting the agent win. Capture the per-request overrides",
'and re-apply them in createConnection(), mirroring the checkServerIdentity',
'handling from CVE-2026-58040.',
'',
'Refs: https://github.com/nodejs/node/commit/52a8ace880d',
'Signed-off-by: axedos <acceleratingssoul@proton.me>'
]
}
}
...
not ok 8 line-length: Line should be <= 72 columns.
---
{
found: 74,
compare: '<=',
wanted: 72,
at: {
line: 7,
column: 72,
body: [
'',
'Per-request rejectUnauthorized/ca/servername were silently ignored when the',
'https.Agent set the same option, because http.Agent merges request options',
"over the agent's own, letting the agent win. Capture the per-request overrides",
'and re-apply them in createConnection(), mirroring the checkServerIdentity',
'handling from CVE-2026-58040.',
'',
'Refs: https://github.com/nodejs/node/commit/52a8ace880d',
'Signed-off-by: axedos <acceleratingssoul@proton.me>'
]
}
}
...
ok 9 signed-off-by: has valid Signed-off-by
ok 10 subsystem: valid subsystems [https]
ok 11 title-format: Title is formatted correctly.
0..11
# tests 11
# pass 6
# fail 4
# Please review the commit message guidelines:
# https://github.com/nodejs/node/blob/HEAD/doc/contributing/pull-requests.md#commit-message-guidelines
npm warn deprecated tap@16.3.10: Versions of tap before v18 are no longer maintained. Please upgrade.
npm warn deprecated rimraf@3.0.2: Rimraf versions prior to v4 are no longer supported
npm warn deprecated inflight@1.0.6: This module is not supported, and leaks memory. Do not use it. Check out lru-cache if you want a good and tested way to coalesce async requests by a key value, which is much more comprehensive and powe
|
|
Workflow execution policy warning (evaluate mode):
.github/workflows/commit-lint.yml#L1
On November 2, 2026, GitHub will restrict `pull_request_target` on public repositories by default. To continue allowing the event trigger, configure an Actions policy. Learn more: https://gh.io/securely-using-pull_request_target#default-policy-for-pull_request_target
|