Commit 8afd2ef
committed
build: keep addon exports in the macOS binary
-Wl,-dead_strip on the Release executable removed napi_* and other
globals that nothing in the executable calls. Addons resolve those
symbols from the host, so doc-kit's lightningcss addon called a null
pointer inside napi_register_module_v1 and macOS CI died with
SIGSEGV while generating docs. -x and -S stay; they only drop local
and debug symbols.
Signed-off-by: Yagiz Nizipli <yagiz@nizipli.com>
Assisted-by: Grok1 parent b094ea9 commit 8afd2ef
1 file changed
Lines changed: 5 additions & 5 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
661 | 661 | | |
662 | 662 | | |
663 | 663 | | |
664 | | - | |
665 | | - | |
666 | | - | |
667 | | - | |
| 664 | + | |
| 665 | + | |
| 666 | + | |
| 667 | + | |
| 668 | + | |
668 | 669 | | |
669 | 670 | | |
670 | 671 | | |
671 | 672 | | |
672 | 673 | | |
673 | | - | |
674 | 674 | | |
675 | 675 | | |
676 | 676 | | |
| |||
0 commit comments