use CC instead HOSTCC for maketab

[xosevp]

It is not built with the same local FLAGS as other files:

Fedora mock build system.

Current code:

cc -g -Wall -pedantic -Wcast-qual -O2 -flto=auto -ffat-lto-objects -fexceptions -g -grecord-gcc-switches -pipe -Wall -Wno-complain-wrong-lang -Werror=format-security -Wp,-U_FORTIFY_SOURCE,-D_FORTIFY_SOURCE=3 -Wp,-D_GLIBCXX_ASSERTIONS -specs=/usr/lib/rpm/redhat/redhat-hardened-cc1 -fstack-protector-strong -specs=/usr/lib/rpm/redhat/redhat-annobin-cc1  -m64 -march=x86-64 -mtune=generic -fasynchronous-unwind-tables -fstack-clash-protection -fcf-protection -mtls-dialect=gnu2 -fno-omit-frame-pointer -mno-omit-leaf-frame-pointer maketab.c -o maketab
[...]

0001-nawk.patch

gcc -O2 -flto=auto -ffat-lto-objects -fexceptions -g -grecord-gcc-switches -pipe -Wall -Wno-complain-wrong-lang -Werror=format-security -Wp,-U_FORTIFY_SOURCE,-D_FORTIFY_SOURCE=3 -Wp,-D_GLIBCXX_ASSERTIONS -specs=/usr/lib/rpm/redhat/redhat-hardened-cc1 -fstack-protector-strong -specs=/usr/lib/rpm/redhat/redhat-annobin-cc1  -m64 -march=x86-64 -mtune=generic -fasynchronous-unwind-tables -fstack-clash-protection -fcf-protection -mtls-dialect=gnu2 -fno-omit-frame-pointer -mno-omit-leaf-frame-pointer maketab.c -o maketab
[...]

Built with all Fedora local flags applied correctly.
"gcc" instead "cc". And "-g -Wall -pedantic -Wcast-qual" were removed.

Thanks.

[leahneukirchen]

That is intentional for cross compiling to work. maketab is only run once and not installed.

[xosevp]

That is intentional for cross compiling to work. maketab is only run once and not installed.

For cross-compilation, some values ​​must be adapted:

awk/makefile

Lines 30 to 36 in d7f3764

	# compiler options
	#CC = cc -Wall -g -Wwrite-strings
	#CC = cc -O4 -Wall -pedantic -fno-strict-aliasing
	#CC = cc -fprofile-arcs -ftest-coverage # then gcov f1.c; cat f1.c.gcov
	HOSTCC = cc -g -Wall -pedantic -Wcast-qual
	# HOSTCC = g++ -g -Wall -pedantic -Wcast-qual
	CC = $(HOSTCC) # change this is cross-compiling.

[leahneukirchen]

Yes, but passing CFLAGS for the target compiler can break the host compiler (e.g. -march=armv8-a for an ARM64 target on a x86_64 host.)

Aha, I see this is wrong too, and we patch it. ;)

[xosevp]

Fedora bug: https://bugzilla.redhat.com/show_bug.cgi?id=2401434
Fedora fix: https://src.fedoraproject.org/rpms/nawk/c/a043083eab2400c1ea4dcacac2e6d3f91425f4f4?branch=rawhide