diff --git a/.github/playwright/impact-map.generated.json b/.github/playwright/impact-map.generated.json index 54428d7b4eb6..ef9b099983eb 100644 --- a/.github/playwright/impact-map.generated.json +++ b/.github/playwright/impact-map.generated.json @@ -7611,14 +7611,6 @@ "playwright/e2e/Pages/AppStopRunModal.spec.ts" ] }, - { - "sources": [ - "openmetadata-ui/src/main/resources/ui/src/components/Modals/StyleModal/StyleModal.component.tsx" - ], - "specs": [ - "playwright/e2e/Pages/DomainUIInteractions.spec.ts" - ] - }, { "sources": [ "openmetadata-ui/src/main/resources/ui/src/components/Modals/TourEndModal/TourEndModal.tsx" @@ -12448,6 +12440,22 @@ "playwright/e2e/Pages/IntakeForm.spec.ts" ] }, + { + "sources": [ + "openmetadata-ui/src/main/resources/ui/src/pages/KPIPage/AddKPIPage.tsx" + ], + "specs": [ + "playwright/e2e/Features/DataQuality/ProfilerSettingsAfterReindex.spec.ts" + ] + }, + { + "sources": [ + "openmetadata-ui/src/main/resources/ui/src/pages/KPIPage/EditKPIPage.tsx" + ], + "specs": [ + "playwright/e2e/Features/DataQuality/ProfilerSettingsAfterReindex.spec.ts" + ] + }, { "sources": [ "openmetadata-ui/src/main/resources/ui/src/pages/KnowledgeCenterFilterPage/KnowledgeCenterFilterPage.tsx" diff --git a/openmetadata-ui/src/main/resources/ui/playwright/e2e/Features/DataQuality/ProfilerSettingsAfterReindex.spec.ts b/openmetadata-ui/src/main/resources/ui/playwright/e2e/Features/DataQuality/ProfilerSettingsAfterReindex.spec.ts index 70929d222a3f..4fa94050ca42 100644 --- a/openmetadata-ui/src/main/resources/ui/playwright/e2e/Features/DataQuality/ProfilerSettingsAfterReindex.spec.ts +++ b/openmetadata-ui/src/main/resources/ui/playwright/e2e/Features/DataQuality/ProfilerSettingsAfterReindex.spec.ts @@ -48,6 +48,23 @@ test('Profiler settings survive a table reindex', async ({ browser }) => { await page.getByTestId('profiler-setting-btn').click(); await page.getByTestId('profiler-settings-modal').waitFor(); + // Body-portaled options are hidden by the modal's accessibility boundary. + // Check accessible options and keyboard selection inside the drawer. + const settings = page.getByRole('dialog', { name: 'Settings' }); + const sampleType = settings.getByRole('combobox', { + name: 'Profile Sample type', + }); + await settings.getByTestId('profile-sample').click(); + await expect( + settings.getByRole('option', { name: 'Row Count', exact: true }) + ).toBeAttached(); + await sampleType.press('ArrowDown'); + await sampleType.press('Enter'); + await expect(settings.getByTestId('metric-number-input')).toBeVisible(); + await settings.getByTestId('profile-sample').click(); + await sampleType.press('ArrowUp'); + await sampleType.press('Enter'); + await page.getByTestId('slider-input').clear(); await page.getByTestId('slider-input').fill(PROFILE_SAMPLE); await page.getByTestId('sample-data-count-input').clear(); diff --git a/openmetadata-ui/src/main/resources/ui/playwright/e2e/Features/Tasks/TaskCreation.spec.ts b/openmetadata-ui/src/main/resources/ui/playwright/e2e/Features/Tasks/TaskCreation.spec.ts index bfd510f5bb36..de71f67fc954 100644 --- a/openmetadata-ui/src/main/resources/ui/playwright/e2e/Features/Tasks/TaskCreation.spec.ts +++ b/openmetadata-ui/src/main/resources/ui/playwright/e2e/Features/Tasks/TaskCreation.spec.ts @@ -175,7 +175,15 @@ test.describe('Task Creation - Request Description', () => { await expect(page.getByTestId('form-container')).toBeVisible(); // Assignee field - search and select user - const assigneeInput = page.locator('[data-testid="select-assignee"] input'); + const assigneeInput = page + .getByTestId('select-assignee') + .getByRole('combobox'); + await expect(assigneeInput).toHaveAccessibleName(/^Assignees\b/); + await page + .locator('label') + .filter({ hasText: /^Assignees\b/ }) + .click(); + await expect(assigneeInput).toBeFocused(); await assigneeInput.click(); // Search for user diff --git a/openmetadata-ui/src/main/resources/ui/playwright/e2e/VisualRegression/__snapshots__/staticPages.spec.ts-snapshots/teams.png b/openmetadata-ui/src/main/resources/ui/playwright/e2e/VisualRegression/__snapshots__/staticPages.spec.ts-snapshots/teams.png index 2d2988f597e1..943c077bd676 100644 Binary files a/openmetadata-ui/src/main/resources/ui/playwright/e2e/VisualRegression/__snapshots__/staticPages.spec.ts-snapshots/teams.png and b/openmetadata-ui/src/main/resources/ui/playwright/e2e/VisualRegression/__snapshots__/staticPages.spec.ts-snapshots/teams.png differ diff --git a/openmetadata-ui/src/main/resources/ui/playwright/utils/glossary.ts b/openmetadata-ui/src/main/resources/ui/playwright/utils/glossary.ts index 643a5266a182..437c442060b1 100644 --- a/openmetadata-ui/src/main/resources/ui/playwright/utils/glossary.ts +++ b/openmetadata-ui/src/main/resources/ui/playwright/utils/glossary.ts @@ -1292,10 +1292,12 @@ export const createDescriptionTaskForGlossary = async ( ); await expect( - page.locator('[data-testid="select-assignee"] input') + page.getByTestId('select-assignee').getByRole('combobox') ).toBeDisabled(); } else { - const assigneeField = page.locator('[data-testid="select-assignee"] input'); + const assigneeField = page + .getByTestId('select-assignee') + .getByRole('combobox'); await assigneeField.click(); const userSearchResponse = page.waitForResponse( @@ -1342,11 +1344,13 @@ export const createTagTaskForGlossary = async ( ); await expect( - page.locator('[data-testid="select-assignee"] input') + page.getByTestId('select-assignee').getByRole('combobox') ).toBeDisabled(); } else { // select assignee - const assigneeField = page.locator('[data-testid="select-assignee"] input'); + const assigneeField = page + .getByTestId('select-assignee') + .getByRole('combobox'); await assigneeField.click(); const userSearchResponse = page.waitForResponse( `/api/v1/search/query?q=*${value.assignee}**&index=user%2Cteam*` diff --git a/openmetadata-ui/src/main/resources/ui/playwright/utils/incidentManager.ts b/openmetadata-ui/src/main/resources/ui/playwright/utils/incidentManager.ts index 487e43df59de..b7fbe6c9caca 100644 --- a/openmetadata-ui/src/main/resources/ui/playwright/utils/incidentManager.ts +++ b/openmetadata-ui/src/main/resources/ui/playwright/utils/incidentManager.ts @@ -189,7 +189,7 @@ export const addAssigneeFromPopoverWidget = async (data: { const assigneeModal = page.locator('.ant-modal-content').last(); const assigneeSelect = assigneeModal.getByTestId('select-assignee'); - const assigneeInput = assigneeSelect.locator('input'); + const assigneeInput = assigneeSelect.getByRole('combobox'); const assigneeOption = page.getByTestId(user.name).first(); const normalizedAssigneeOption = page .getByTestId(user.name.toLowerCase()) diff --git a/openmetadata-ui/src/main/resources/ui/playwright/utils/task.ts b/openmetadata-ui/src/main/resources/ui/playwright/utils/task.ts index 41a1dcc93526..82e65e92871a 100644 --- a/openmetadata-ui/src/main/resources/ui/playwright/utils/task.ts +++ b/openmetadata-ui/src/main/resources/ui/playwright/utils/task.ts @@ -122,10 +122,12 @@ export const createDescriptionTask = async ( ); await expect( - page.locator('[data-testid="select-assignee"] input') + page.getByTestId('select-assignee').getByRole('combobox') ).toBeDisabled(); } else { - const assigneeField = page.locator('[data-testid="select-assignee"] input'); + const assigneeField = page + .getByTestId('select-assignee') + .getByRole('combobox'); await assigneeField.click(); await assigneeField.fill(value.assignee); @@ -163,11 +165,13 @@ export const createTagTask = async ( ); await expect( - page.locator('[data-testid="select-assignee"] input') + page.getByTestId('select-assignee').getByRole('combobox') ).toBeDisabled(); } else { // select assignee - const assigneeField = page.locator('[data-testid="select-assignee"] input'); + const assigneeField = page + .getByTestId('select-assignee') + .getByRole('combobox'); await assigneeField.click(); await assigneeField.fill(value.assignee); diff --git a/openmetadata-ui/src/main/resources/ui/playwright/utils/taskWorkflow.ts b/openmetadata-ui/src/main/resources/ui/playwright/utils/taskWorkflow.ts index d83bbf392859..147b10a56285 100644 --- a/openmetadata-ui/src/main/resources/ui/playwright/utils/taskWorkflow.ts +++ b/openmetadata-ui/src/main/resources/ui/playwright/utils/taskWorkflow.ts @@ -214,7 +214,9 @@ export const openTaskForm = async (page: Page, route: string) => { }; export const selectAssignee = async (page: Page, assigneeName: string) => { - const assigneeInput = page.locator('[data-testid="select-assignee"] input'); + const assigneeInput = page + .getByTestId('select-assignee') + .getByRole('combobox'); const assigneeOption = page.getByTestId(assigneeName); const assigneeSearchResponse = page .waitForResponse( diff --git a/openmetadata-ui/src/main/resources/ui/src/assets/svg/ic-format-block-quote.svg b/openmetadata-ui/src/main/resources/ui/src/assets/svg/ic-format-block-quote.svg index a626260650fd..c7c176aa8a10 100644 --- a/openmetadata-ui/src/main/resources/ui/src/assets/svg/ic-format-block-quote.svg +++ b/openmetadata-ui/src/main/resources/ui/src/assets/svg/ic-format-block-quote.svg @@ -1,3 +1,3 @@ - + \ No newline at end of file diff --git a/openmetadata-ui/src/main/resources/ui/src/assets/svg/ic-format-bullet-list.svg b/openmetadata-ui/src/main/resources/ui/src/assets/svg/ic-format-bullet-list.svg index 293ccd4f7837..01e928ce546d 100644 --- a/openmetadata-ui/src/main/resources/ui/src/assets/svg/ic-format-bullet-list.svg +++ b/openmetadata-ui/src/main/resources/ui/src/assets/svg/ic-format-bullet-list.svg @@ -1,5 +1,5 @@ - - - + + + diff --git a/openmetadata-ui/src/main/resources/ui/src/assets/svg/ic-format-code-block.svg b/openmetadata-ui/src/main/resources/ui/src/assets/svg/ic-format-code-block.svg index 8daf6d5680a1..fb530149e7fa 100644 --- a/openmetadata-ui/src/main/resources/ui/src/assets/svg/ic-format-code-block.svg +++ b/openmetadata-ui/src/main/resources/ui/src/assets/svg/ic-format-code-block.svg @@ -1,3 +1,3 @@ - + diff --git a/openmetadata-ui/src/main/resources/ui/src/assets/svg/ic-format-horizontal-line.svg b/openmetadata-ui/src/main/resources/ui/src/assets/svg/ic-format-horizontal-line.svg index aeb9db3e5ad4..4e8045850efc 100644 --- a/openmetadata-ui/src/main/resources/ui/src/assets/svg/ic-format-horizontal-line.svg +++ b/openmetadata-ui/src/main/resources/ui/src/assets/svg/ic-format-horizontal-line.svg @@ -1,3 +1,3 @@ - + \ No newline at end of file diff --git a/openmetadata-ui/src/main/resources/ui/src/assets/svg/ic-format-image-inline.svg b/openmetadata-ui/src/main/resources/ui/src/assets/svg/ic-format-image-inline.svg index c67825ead370..cbaa84ac190c 100644 --- a/openmetadata-ui/src/main/resources/ui/src/assets/svg/ic-format-image-inline.svg +++ b/openmetadata-ui/src/main/resources/ui/src/assets/svg/ic-format-image-inline.svg @@ -1,4 +1,4 @@ - - + + \ No newline at end of file diff --git a/openmetadata-ui/src/main/resources/ui/src/assets/svg/ic-format-numbered-list.svg b/openmetadata-ui/src/main/resources/ui/src/assets/svg/ic-format-numbered-list.svg index 09f774488a48..e8d236691e45 100644 --- a/openmetadata-ui/src/main/resources/ui/src/assets/svg/ic-format-numbered-list.svg +++ b/openmetadata-ui/src/main/resources/ui/src/assets/svg/ic-format-numbered-list.svg @@ -1,3 +1,3 @@ - + diff --git a/openmetadata-ui/src/main/resources/ui/src/components/ActivityFeed/ActivityFeedPanel/feed-panel-body-v1.less b/openmetadata-ui/src/main/resources/ui/src/components/ActivityFeed/ActivityFeedPanel/feed-panel-body-v1.less index 197438a46e6b..429fdfaba220 100644 --- a/openmetadata-ui/src/main/resources/ui/src/components/ActivityFeed/ActivityFeedPanel/feed-panel-body-v1.less +++ b/openmetadata-ui/src/main/resources/ui/src/components/ActivityFeed/ActivityFeedPanel/feed-panel-body-v1.less @@ -15,17 +15,18 @@ .activity-feed-card-new { border-radius: var(--om-radius-xl); - background: @grey-9; + background: var(--tw-color-bg-surface); display: flex; flex-direction: column; flex-wrap: wrap; width: inherit; &.ant-card { - background: @grey-9; + background: var(--tw-color-bg-surface); border-radius: var(--om-radius-xl); margin-bottom: var(--om-space-20); - border: 0.5px solid @grey-15; + border: 1px solid var(--tw-color-border-subtle); + box-shadow: var(--om-shadow-card); } .ant-card-body { @@ -66,7 +67,7 @@ .task-feed-card-v1-new { .header-link { word-wrap: break-word; - color: @primary-heading-color; + color: var(--tw-color-text-link); font-weight: var(--om-font-weight-semibold); display: inline; } @@ -84,8 +85,8 @@ border-radius: var(--om-radius-xl); padding: var(--om-space-16); margin: var(--om-space-20) 0 0 0; - background: @grey-9; - border: 0.5px solid @grey-15; + background: var(--tw-color-bg-surface); + border: 1px solid var(--tw-color-border-subtle); input.ant-input, textarea.ant-input { border-radius: var(--om-radius-20); @@ -102,8 +103,8 @@ .activity-feed-reply-button { border-radius: var(--om-radius-3xl); - border: 1px solid var(--om-legacy-color-d4d4d8); - color: var(--om-legacy-color-52525b); + border: 1px solid var(--tw-color-border-secondary); + color: var(--tw-color-text-secondary); font-size: var(--om-font-size-xs); } .comments-input-field { diff --git a/openmetadata-ui/src/main/resources/ui/src/components/ActivityFeed/ActivityFeedTab/activity-feed-tab.less b/openmetadata-ui/src/main/resources/ui/src/components/ActivityFeed/ActivityFeedTab/activity-feed-tab.less index 9cb86a68150a..3b0e44d7da9e 100644 --- a/openmetadata-ui/src/main/resources/ui/src/components/ActivityFeed/ActivityFeedTab/activity-feed-tab.less +++ b/openmetadata-ui/src/main/resources/ui/src/components/ActivityFeed/ActivityFeedTab/activity-feed-tab.less @@ -226,10 +226,10 @@ &, & a { - color: @primary-heading-color; + color: var(--tw-color-text-link); &:hover { - color: @primary-heading-color; + color: var(--tw-color-text-link); } } } @@ -244,33 +244,36 @@ } .activity-feed-editor-container-new { - background-color: @grey-9; - border: 0.5px solid @grey-15; + background-color: var(--tw-color-bg-surface); + border: 1px solid var(--tw-color-border-subtle); border-radius: var(--om-radius-10); width: 100%; .ql-container { - background-color: @grey-9; - border: 1px solid @grey-15; + background-color: var(--tw-color-bg-surface); + border: none; width: 100%; &:focus-within { - border: 0.5px solid @grey-15; + outline: 1px solid var(--tw-color-border-brand); + outline-offset: -1px; } } .ql-toolbar { - background-color: @grey-9; - border: 1px solid @grey-15; + background-color: var(--tw-color-bg-surface); + border: none; + border-bottom: 1px solid var(--tw-color-border-subtle); flex-wrap: wrap; &:focus-within { - border: 0.5px solid @grey-15; + outline: 1px solid var(--tw-color-border-brand); + outline-offset: -1px; } } .ql-toolbar button { - color: var(--om-color-gray-true-800); + color: var(--tw-color-text-secondary); } } diff --git a/openmetadata-ui/src/main/resources/ui/src/components/ActivityFeed/FeedEditor/feed-editor.less b/openmetadata-ui/src/main/resources/ui/src/components/ActivityFeed/FeedEditor/feed-editor.less index e9f0410f24de..6344c0c92835 100644 --- a/openmetadata-ui/src/main/resources/ui/src/components/ActivityFeed/FeedEditor/feed-editor.less +++ b/openmetadata-ui/src/main/resources/ui/src/components/ActivityFeed/FeedEditor/feed-editor.less @@ -506,19 +506,19 @@ @media (pointer: coarse) { .ql-snow.ql-toolbar button:hover:not(.ql-active), .ql-snow .ql-toolbar button:hover:not(.ql-active) { - color: var(--om-legacy-color-444444); + color: var(--tw-color-text-secondary); } .ql-snow.ql-toolbar button:hover:not(.ql-active) .ql-fill, .ql-snow .ql-toolbar button:hover:not(.ql-active) .ql-fill, .ql-snow.ql-toolbar button:hover:not(.ql-active) .ql-stroke.ql-fill, .ql-snow .ql-toolbar button:hover:not(.ql-active) .ql-stroke.ql-fill { - fill: var(--om-legacy-color-444444); + fill: var(--tw-color-text-secondary); } .ql-snow.ql-toolbar button:hover:not(.ql-active) .ql-stroke, .ql-snow .ql-toolbar button:hover:not(.ql-active) .ql-stroke, .ql-snow.ql-toolbar button:hover:not(.ql-active) .ql-stroke-miter, .ql-snow .ql-toolbar button:hover:not(.ql-active) .ql-stroke-miter { - stroke: var(--om-legacy-color-444444); + stroke: var(--tw-color-text-secondary); } } .ql-snow { @@ -556,20 +556,20 @@ } .ql-snow .ql-stroke { fill: none; - stroke: var(--om-legacy-color-444444); + stroke: var(--tw-color-text-secondary); stroke-linecap: round; stroke-linejoin: round; stroke-width: 2; } .ql-snow .ql-stroke-miter { fill: none; - stroke: var(--om-legacy-color-444444); + stroke: var(--tw-color-text-secondary); stroke-miterlimit: 10; stroke-width: 2; } .ql-snow .ql-fill, .ql-snow .ql-stroke.ql-fill { - fill: var(--om-legacy-color-444444); + fill: var(--tw-color-text-secondary); } .ql-snow .ql-empty { fill: none; @@ -643,7 +643,7 @@ max-width: 100%; } .ql-snow .ql-picker { - color: var(--om-legacy-color-444444); + color: var(--tw-color-text-secondary); display: inline-block; font-size: var(--om-font-size-sm); font-weight: var(--om-font-weight-medium); diff --git a/openmetadata-ui/src/main/resources/ui/src/components/ActivityFeed/TaskFeedCard/task-feed-card.less b/openmetadata-ui/src/main/resources/ui/src/components/ActivityFeed/TaskFeedCard/task-feed-card.less index 86ea89949229..a1708b588e3b 100644 --- a/openmetadata-ui/src/main/resources/ui/src/components/ActivityFeed/TaskFeedCard/task-feed-card.less +++ b/openmetadata-ui/src/main/resources/ui/src/components/ActivityFeed/TaskFeedCard/task-feed-card.less @@ -38,10 +38,11 @@ } .task-feed-card-v1-new { padding: var(--om-space-20); - background: @grey-9; + background: var(--tw-color-bg-surface); + box-shadow: var(--om-shadow-card); border-radius: var(--om-radius-xl); margin-bottom: var(--om-space-20); - border: 0.5px solid @grey-15; + border: 1px solid var(--tw-color-border-subtle); &.active { border-left: 4px solid @primary-color; diff --git a/openmetadata-ui/src/main/resources/ui/src/components/BlockEditor/block-editor.less b/openmetadata-ui/src/main/resources/ui/src/components/BlockEditor/block-editor.less index 4598d16e979c..cefe096b44e9 100644 --- a/openmetadata-ui/src/main/resources/ui/src/components/BlockEditor/block-editor.less +++ b/openmetadata-ui/src/main/resources/ui/src/components/BlockEditor/block-editor.less @@ -13,16 +13,16 @@ @import (reference) '../../styles/variables.less'; @border-radius: var(--om-radius-md); -@border-color: var(--om-legacy-color-e8e8ed); +@border-color: var(--tw-color-border-subtle); // Semantic surface so inline code, table headers and callouts follow dark mode // (the legacy #f8f8fa alias has no dark value). @markdown-bg-color: var(--om-color-bg-secondary); -@hover-bg: var(--om-legacy-color-0-0-0-0-02); +@hover-bg: var(--tw-color-bg-primary_hover); @callout-bg: var(--om-color-bg-secondary); -@callout-warning-bg: var(--om-legacy-color-fff3dc); -@callout-info-bg: @primary-1; -@callout-danger-bg: var(--om-legacy-color-255-76-59-0-2); -@callout-border: var(--om-legacy-color-afafc1); +@callout-warning-bg: var(--tw-color-bg-warning-primary); +@callout-info-bg: var(--tw-color-bg-brand-primary); +@callout-danger-bg: var(--tw-color-bg-error-primary); +@callout-border: var(--tw-color-border-subtle); .block-editor-wrapper { .om-block-editor > p:last-child { @@ -94,7 +94,7 @@ } a { - color: @primary-color; + color: var(--tw-color-text-link); text-decoration: none; line-height: 24px; @@ -245,7 +245,8 @@ } &.block-editor-wrapper--bar-menu { - border: 1px solid var(--tw-color-border-primary); + background: var(--tw-color-bg-surface); + border: 1px solid var(--tw-color-border-subtle); border-radius: var(--om-radius-sm); &:focus-within { @@ -286,7 +287,7 @@ } .menu-wrapper { - background-color: var(--tw-color-bg-primary); + background-color: var(--tw-color-bg-surface); display: flex; gap: var(--om-space-8); align-items: center; @@ -304,7 +305,7 @@ .slash-menu-wrapper { max-height: 300px; padding: var(--om-space-12) 0; - background-color: var(--tw-color-bg-primary); + background-color: var(--tw-color-bg-overlay-surface); border: @global-border; border-radius: @border-rad-base; overflow-y: auto; @@ -329,7 +330,7 @@ max-height: 300px; max-width: 300px; padding: var(--om-space-12) 0; - background-color: var(--tw-color-bg-primary); + background-color: var(--tw-color-bg-overlay-surface); border: @global-border; border-radius: @border-rad-base; overflow-y: auto; @@ -449,10 +450,12 @@ .is-format-active { .ant-typography, .format-label { - color: @primary-color; + color: var(--tw-color-text-link); } svg { - fill: @primary-color; + // Toolbar paths use currentColor, so the active state must set the foreground. + color: var(--tw-color-text-link); + fill: currentColor; } } diff --git a/openmetadata-ui/src/main/resources/ui/src/components/ContextCenter/ContextCenterLayout/ContextCenterLayout.tsx b/openmetadata-ui/src/main/resources/ui/src/components/ContextCenter/ContextCenterLayout/ContextCenterLayout.tsx index 33c4d587ad0b..de8c5c5f9855 100644 --- a/openmetadata-ui/src/main/resources/ui/src/components/ContextCenter/ContextCenterLayout/ContextCenterLayout.tsx +++ b/openmetadata-ui/src/main/resources/ui/src/components/ContextCenter/ContextCenterLayout/ContextCenterLayout.tsx @@ -109,7 +109,7 @@ const ContextCenterLayout: React.FC = ({ children }) => { ); return ( -
+
{/* Reloads the embedded page on a contextMemory/page change for the active CC route (registry → markRouteDirty); the layout, its modals and intents stay mounted. */} {children} diff --git a/openmetadata-ui/src/main/resources/ui/src/components/ContextCenter/ContextKnowledgePillarCard/ContextKnowledgePillarCard.component.tsx b/openmetadata-ui/src/main/resources/ui/src/components/ContextCenter/ContextKnowledgePillarCard/ContextKnowledgePillarCard.component.tsx index ab48d4ee6a93..45f9f53034f2 100644 --- a/openmetadata-ui/src/main/resources/ui/src/components/ContextCenter/ContextKnowledgePillarCard/ContextKnowledgePillarCard.component.tsx +++ b/openmetadata-ui/src/main/resources/ui/src/components/ContextCenter/ContextKnowledgePillarCard/ContextKnowledgePillarCard.component.tsx @@ -51,7 +51,7 @@ function RecentItem({ return ( = ({ justify="between"> = ({ = ({ return ( onViewMemory?.(memory)}> diff --git a/openmetadata-ui/src/main/resources/ui/src/components/DataAssetSummaryPanelV1/DataAssetSummaryPanelV1.test.tsx b/openmetadata-ui/src/main/resources/ui/src/components/DataAssetSummaryPanelV1/DataAssetSummaryPanelV1.test.tsx index 92b1b216058b..7950a87fd824 100644 --- a/openmetadata-ui/src/main/resources/ui/src/components/DataAssetSummaryPanelV1/DataAssetSummaryPanelV1.test.tsx +++ b/openmetadata-ui/src/main/resources/ui/src/components/DataAssetSummaryPanelV1/DataAssetSummaryPanelV1.test.tsx @@ -274,6 +274,7 @@ jest.mock('@openmetadata/ui-core-components', () => { }); return { + ...jest.requireActual('@openmetadata/ui-core-components'), Owner: () =>
Owners Section
, Button: ({ children, onPress, onClick, ...rest }: any) => ( - +
); @@ -527,6 +531,7 @@ const ProfilerSettingsModal: React.FC = ({ autoFocus className="w-full" data-testid="profile-sample" + getPopupContainer={getPopupContainer} options={PROFILE_SAMPLE_OPTIONS} placeholder={t('label.please-select-entity', { entity: t('label.profile-sample-type', { @@ -614,6 +619,7 @@ const ProfilerSettingsModal: React.FC = ({ className="w-full" data-testid="exclude-column-select" dropdownStyle={{ maxHeight: 200, overflowY: 'auto' }} + getPopupContainer={getPopupContainer} mode="multiple" options={columnOptions} placeholder={t('label.select-column-plural-to-exclude')} @@ -673,6 +679,7 @@ const ProfilerSettingsModal: React.FC = ({ showSearch className="w-full" data-testid="include-column-select" + getPopupContainer={getPopupContainer} options={columnWithAllOption} placeholder={t( 'label.select-column-plural-to-include' @@ -689,6 +696,7 @@ const ProfilerSettingsModal: React.FC = ({ = ({ className="w-full" data-testid="interval-type" disabled={!state?.enablePartition} + getPopupContainer={getPopupContainer} options={INTERVAL_TYPE_OPTIONS} placeholder={t('message.select-interval-type')} size="middle" @@ -790,6 +799,7 @@ const ProfilerSettingsModal: React.FC = ({ className="w-full" data-testid="column-name" disabled={!state?.enablePartition} + getPopupContainer={getPopupContainer} options={partitionColumnOptions} placeholder={t('message.select-column-name')} size="middle" @@ -847,6 +857,7 @@ const ProfilerSettingsModal: React.FC = ({ className="w-full" data-testid="select-interval-unit" disabled={!state?.enablePartition} + getPopupContainer={getPopupContainer} options={INTERVAL_UNIT_OPTIONS} placeholder={t('message.select-interval-unit')} size="middle" @@ -1006,28 +1017,26 @@ const ProfilerSettingsModal: React.FC = ({ ); return ( - } - type="link" - onClick={handleCancel} - /> - } - footer={drawerFooter} - maskClosable={false} - open={visible} - placement="right" - title={t('label.setting-plural')} + dialogClassName="tw:gap-0" + isDismissable={false} + isOpen={visible} width="40%" - onClose={handleCancel}> - {renderContent} - + onOpenChange={(isOpen) => !isOpen && handleCancel()}> + + + {t('label.setting-plural')} + + + + {renderContent} + + {drawerFooter} + ); }; diff --git a/openmetadata-ui/src/main/resources/ui/src/components/Database/Profiler/TableProfiler/table-profiler.less b/openmetadata-ui/src/main/resources/ui/src/components/Database/Profiler/TableProfiler/table-profiler.less index 9016ddd62459..e86a2d3bffca 100644 --- a/openmetadata-ui/src/main/resources/ui/src/components/Database/Profiler/TableProfiler/table-profiler.less +++ b/openmetadata-ui/src/main/resources/ui/src/components/Database/Profiler/TableProfiler/table-profiler.less @@ -70,9 +70,8 @@ .profiler-settings-drawer-content { flex: 1; overflow-y: auto; - padding-top: @padding-lg; - padding-right: @padding-sm; - padding-bottom: @padding-lg; + // The slideout content owns the gutters; nested padding narrows the form. + padding: 0; .delete-btn { &.ant-btn-icon-only { @@ -83,7 +82,7 @@ } .profiler-settings-form { - padding-right: @padding-sm; + padding-right: 0; } } diff --git a/openmetadata-ui/src/main/resources/ui/src/components/Database/SchemaEditor/CodeEditor.tsx b/openmetadata-ui/src/main/resources/ui/src/components/Database/SchemaEditor/CodeEditor.tsx index 019626243fa1..5afb5c95297f 100644 --- a/openmetadata-ui/src/main/resources/ui/src/components/Database/SchemaEditor/CodeEditor.tsx +++ b/openmetadata-ui/src/main/resources/ui/src/components/Database/SchemaEditor/CodeEditor.tsx @@ -11,12 +11,11 @@ * limitations under the License. */ -import { Card } from '@openmetadata/ui-core-components'; +import { ButtonUtility, Card } from '@openmetadata/ui-core-components'; +import { Copy01 } from '@openmetadata/ui-core-components/icons'; import CodeMirror from '@uiw/react-codemirror'; -import { Button, Tooltip } from 'antd'; import classNames from 'classnames'; import { useTranslation } from 'react-i18next'; -import { ReactComponent as CopyIcon } from '../../../assets/svg/copy-left.svg'; import { JSON_TAB_SIZE } from '../../../constants/constants'; import { CSMode } from '../../../enums/codemirror.enum'; import { useClipboard } from '../../../hooks/useClipBoard'; @@ -75,10 +74,9 @@ const CodeEditor = ({ const { onCopyToClipBoard, hasCopied } = useClipboard(internalValue); return ( - // Light values reproduce the antd Card this replaced.
{title} @@ -98,19 +95,17 @@ const CodeEditor = ({
- -
)}
diff --git a/openmetadata-ui/src/main/resources/ui/src/components/Domain/DomainDetails/DomainDetails.component.tsx b/openmetadata-ui/src/main/resources/ui/src/components/Domain/DomainDetails/DomainDetails.component.tsx index eef1c45d76b4..32d3431dd919 100644 --- a/openmetadata-ui/src/main/resources/ui/src/components/Domain/DomainDetails/DomainDetails.component.tsx +++ b/openmetadata-ui/src/main/resources/ui/src/components/Domain/DomainDetails/DomainDetails.component.tsx @@ -19,7 +19,10 @@ import { Tabs, Typography, } from '@openmetadata/ui-core-components'; -import { ChevronDown } from '@openmetadata/ui-core-components/icons'; +import { + Announcement02 as IconAnnouncementsBlack, + ChevronDown, +} from '@openmetadata/ui-core-components/icons'; import { Button, Tooltip } from 'antd'; import ButtonGroup from 'antd/lib/button/button-group'; import { AxiosError } from 'axios'; @@ -29,7 +32,6 @@ import { useCallback, useEffect, useMemo, useRef, useState } from 'react'; import { useForm } from 'react-hook-form'; import { useTranslation } from 'react-i18next'; import { useLocation, useNavigate, useParams } from 'react-router-dom'; -import { ReactComponent as IconAnnouncementsBlack } from '../../../assets/svg/announcements-black.svg'; import { ReactComponent as EditIcon } from '../../../assets/svg/edit-new.svg'; import { ReactComponent as DeleteIcon } from '../../../assets/svg/ic-delete.svg'; import { ReactComponent as VersionIcon } from '../../../assets/svg/ic-version.svg'; diff --git a/openmetadata-ui/src/main/resources/ui/src/components/Domain/domain.less b/openmetadata-ui/src/main/resources/ui/src/components/Domain/domain.less index e8db73d6de4f..6471fb90ba14 100644 --- a/openmetadata-ui/src/main/resources/ui/src/components/Domain/domain.less +++ b/openmetadata-ui/src/main/resources/ui/src/components/Domain/domain.less @@ -13,14 +13,13 @@ @import (reference) '../../styles/variables.less'; .domain-page-container { - background-color: var(--tw-color-bg-primary); - border: 1px solid var(--tw-color-gray-blue-100); + background-color: var(--tw-color-bg-canvas); border-radius: var(--om-radius-md); margin-bottom: var(--om-space-20); .grid-container { background: none; - padding-right: var(--om-space-1); + padding-right: 0; } .resizable-panels-layout { @@ -28,7 +27,7 @@ } .assets-tab-container { - border: 1px solid var(--tw-color-gray-blue-100); + border: none; } .grid-container > #KnowledgePanel\.LeftPanel { diff --git a/openmetadata-ui/src/main/resources/ui/src/components/DomainListing/DomainListPage.tsx b/openmetadata-ui/src/main/resources/ui/src/components/DomainListing/DomainListPage.tsx index fe0526ca236b..0014fd62ab1e 100644 --- a/openmetadata-ui/src/main/resources/ui/src/components/DomainListing/DomainListPage.tsx +++ b/openmetadata-ui/src/main/resources/ui/src/components/DomainListing/DomainListPage.tsx @@ -330,11 +330,12 @@ const DomainListPage = ({ renderPageHeader }: DomainListPageProps) => { + variant={isAiMode ? 'ghost' : 'elevated'}> { }; return ( - - - form={form} - id="style-modal" - initialValues={{ - ...style, - colorInput: style?.color, - }} - layout="vertical" - onFinish={handleSubmit} - onValuesChange={(value) => { - if (!isUndefined(value.color)) { - form.setFieldValue('colorInput', value.color); - } - if (!isUndefined(value.colorInput)) { - form.setFieldValue('color', value.colorInput); - } - }}> - - } - name="iconURL"> - - - - - - - + !isOpen && !saving && onCancel()}> + + !saving && onCancel()}> + + + form={form} + id="style-modal" + initialValues={{ + ...style, + colorInput: style?.color, + }} + layout="vertical" + onFinish={handleSubmit} + onValuesChange={(value) => { + if (!isUndefined(value.color)) { + form.setFieldValue('colorInput', value.color); + } + if (!isUndefined(value.colorInput)) { + form.setFieldValue('color', value.colorInput); + } + }}> + + } + name="iconURL"> + + + + + + + + + + + + + + ); }; diff --git a/openmetadata-ui/src/main/resources/ui/src/components/UploadFile/UploadFile.test.tsx b/openmetadata-ui/src/main/resources/ui/src/components/UploadFile/UploadFile.test.tsx index 5ad4a3dcc21c..f6338f441cbe 100644 --- a/openmetadata-ui/src/main/resources/ui/src/components/UploadFile/UploadFile.test.tsx +++ b/openmetadata-ui/src/main/resources/ui/src/components/UploadFile/UploadFile.test.tsx @@ -16,10 +16,6 @@ import { showErrorToast } from '../../utils/ToastUtils'; import UploadFile from './UploadFile'; import { UploadFileProps } from './UploadFile.interface'; -jest.mock('../../assets/svg/ic-drag-drop.svg', () => ({ - ReactComponent: () =>
ImportIcon
, -})); - jest.mock('../common/Loader/Loader', () => { return jest.fn(() =>
Loading...
); }); @@ -42,7 +38,13 @@ describe('UploadFile Component', () => { render(); expect(screen.getByTestId('upload-file-widget')).toBeInTheDocument(); - expect(screen.getByTestId('import-icon')).toBeInTheDocument(); + + const uploadIcon = screen.getByRole('button').querySelector('svg'); + + expect(uploadIcon).toHaveClass('tw:text-fg-quaternary'); + expect(uploadIcon).toHaveAttribute('stroke', 'currentColor'); + expect(uploadIcon).toHaveAttribute('width', '86'); + expect(uploadIcon).toHaveAttribute('height', '86'); expect( await screen.findByText(/message.drag-and-drop-or-browse-csv-files-here/) ).toBeInTheDocument(); diff --git a/openmetadata-ui/src/main/resources/ui/src/components/UploadFile/UploadFile.tsx b/openmetadata-ui/src/main/resources/ui/src/components/UploadFile/UploadFile.tsx index 27d1726ed85b..e8ecc107c881 100644 --- a/openmetadata-ui/src/main/resources/ui/src/components/UploadFile/UploadFile.tsx +++ b/openmetadata-ui/src/main/resources/ui/src/components/UploadFile/UploadFile.tsx @@ -19,7 +19,6 @@ import { AxiosError } from 'axios'; import type { UploadRequestOption } from 'rc-upload/lib/interface'; import { FC, useCallback, useState } from 'react'; import { useTranslation } from 'react-i18next'; -import { ReactComponent as ImportIcon } from '../../assets/svg/ic-drag-drop.svg'; import { Transi18next } from '../../utils/i18next/LocalUtil'; import { showErrorToast } from '../../utils/ToastUtils'; import Loader from '../common/Loader/Loader'; @@ -110,7 +109,7 @@ const UploadFile: FC = ({ columnGap: 'var(--om-space-42)', rowGap: 'var(--om-space-42)', }}> - + + data-testid={`custom-property-${property.name}-card`} + variant="elevated"> + )} -
+ ); }; diff --git a/openmetadata-ui/src/main/resources/ui/src/components/common/EntityDescription/Description.tsx b/openmetadata-ui/src/main/resources/ui/src/components/common/EntityDescription/Description.tsx index cc647a8f6cd7..b917670dda9f 100644 --- a/openmetadata-ui/src/main/resources/ui/src/components/common/EntityDescription/Description.tsx +++ b/openmetadata-ui/src/main/resources/ui/src/components/common/EntityDescription/Description.tsx @@ -303,7 +303,7 @@ const Description = ({ className={ isWidgetHeader ? 'tw:whitespace-nowrap tw:text-quaternary' - : 'tw:text-text-secondary' + : 'tw:text-secondary' } size="text-sm" weight="semibold"> @@ -325,7 +325,7 @@ const Description = ({ - + @@ -326,11 +326,12 @@ export const SelectableList = ({
diff --git a/openmetadata-ui/src/main/resources/ui/src/components/common/SelectionCardGroup/selection-card-group.less b/openmetadata-ui/src/main/resources/ui/src/components/common/SelectionCardGroup/selection-card-group.less index 32f50aa95f26..b2a9a1f0394d 100644 --- a/openmetadata-ui/src/main/resources/ui/src/components/common/SelectionCardGroup/selection-card-group.less +++ b/openmetadata-ui/src/main/resources/ui/src/components/common/SelectionCardGroup/selection-card-group.less @@ -45,7 +45,7 @@ border-radius: @border-rad-xs; cursor: pointer; transition: all var(--om-duration-300) ease; - background: var(--tw-color-bg-primary); + background: var(--tw-color-bg-surface); position: relative; .beta-badge { @@ -140,25 +140,25 @@ // Selected state styles &.selected, &:hover { - border-color: @primary-3; - background-color: @primary-50; + border-color: var(--tw-color-border-brand); + background-color: var(--tw-color-bg-brand-primary); .selection-content { .selection-icon { - background-color: @primary-1; - border: 6px solid @primary-50; + background-color: var(--tw-color-utility-brand-100); + border: 6px solid var(--tw-color-bg-brand-primary); svg { - color: @primary-6; + color: var(--tw-color-text-link); } } .selection-title { - color: @primary-8; + color: var(--tw-color-text-link); } .selection-description { - color: @primary-6; + color: var(--tw-color-text-link); } .custom-radio.unchecked { diff --git a/openmetadata-ui/src/main/resources/ui/src/components/common/Table/TableV2Utils.test.ts b/openmetadata-ui/src/main/resources/ui/src/components/common/Table/TableV2Utils.test.ts index 4ab8e77c29b7..237683010565 100644 --- a/openmetadata-ui/src/main/resources/ui/src/components/common/Table/TableV2Utils.test.ts +++ b/openmetadata-ui/src/main/resources/ui/src/components/common/Table/TableV2Utils.test.ts @@ -50,8 +50,12 @@ describe('resolveCellValue rawValue branch', () => { describe('sticky column background', () => { it('leaves body cells to the class so dark hover/selected can repaint them', () => { expect(getColumnStickyStyle('left', 1)).not.toHaveProperty('background'); - expect(getStickyBodyCellClass('right')).toContain( - 'tw:dark:group-hover:bg-secondary' + expect(getStickyBodyCellClass('right').split(' ')).toEqual( + expect.arrayContaining([ + 'tw:bg-surface', + 'tw:group-hover:bg-secondary', + 'tw:group-data-[selected]:bg-secondary', + ]) ); expect(getStickyBodyCellClass(undefined)).toBe(''); }); diff --git a/openmetadata-ui/src/main/resources/ui/src/components/common/Table/TableV2Utils.ts b/openmetadata-ui/src/main/resources/ui/src/components/common/Table/TableV2Utils.ts index 6deae19ea7a8..2554c9fad89c 100644 --- a/openmetadata-ui/src/main/resources/ui/src/components/common/Table/TableV2Utils.ts +++ b/openmetadata-ui/src/main/resources/ui/src/components/common/Table/TableV2Utils.ts @@ -131,7 +131,7 @@ export function getStickyBodyCellClass( fixed: ColumnType['fixed'] ): string { return fixed === 'left' || fixed === 'right' - ? 'tw:bg-surface tw:dark:group-hover:bg-secondary tw:dark:group-data-[selected]:bg-secondary' + ? 'tw:bg-surface tw:group-hover:bg-secondary tw:group-data-[selected]:bg-secondary' : ''; } diff --git a/openmetadata-ui/src/main/resources/ui/src/components/common/UserTeamSelectableList/UserTeamSelectableList.component.tsx b/openmetadata-ui/src/main/resources/ui/src/components/common/UserTeamSelectableList/UserTeamSelectableList.component.tsx index 8ff7392193b4..5573b483375e 100644 --- a/openmetadata-ui/src/main/resources/ui/src/components/common/UserTeamSelectableList/UserTeamSelectableList.component.tsx +++ b/openmetadata-ui/src/main/resources/ui/src/components/common/UserTeamSelectableList/UserTeamSelectableList.component.tsx @@ -10,7 +10,16 @@ * See the License for the specific language governing permissions and * limitations under the License. */ -import { Popover, Tabs } from '@openmetadata/ui-core-components'; +import { + Avatar, + ButtonUtility, + Popover, + Tabs, + Tag, + TagGroup, + TagList, +} from '@openmetadata/ui-core-components'; +import { Edit02, Users01 } from '@openmetadata/ui-core-components/icons'; import classNames from 'classnames'; import { isArray, isEmpty, noop, toString } from 'lodash'; import React, { @@ -21,11 +30,8 @@ import React, { useState, } from 'react'; import { useTranslation } from 'react-i18next'; -import { ReactComponent as EditIcon } from '../../../assets/svg/edit-new.svg'; -import { ReactComponent as IconTeamsGrey } from '../../../assets/svg/teams-grey.svg'; import { ADD_USER_CONTAINER_HEIGHT, - DE_ACTIVE_COLOR, PAGE_SIZE_MEDIUM, } from '../../../constants/constants'; import { EntityType } from '../../../enums/entity.enum'; @@ -39,16 +45,13 @@ import { import { getEntityName } from '../../../utils/EntityNameUtils'; import { getEntityReferenceListFromEntities } from '../../../utils/EntityReferenceUtils'; import { getTermQuery } from '../../../utils/SearchPureUtils'; -import { EditIconButton } from '../IconButtons/EditIconButton'; import { SelectableList } from '../SelectableList/SelectableList.component'; -import { UserTag } from '../UserTag/UserTag.component'; -import { UserTagSize } from '../UserTag/UserTag.interface'; import { UserSelectDropdownProps } from './UserTeamSelectableList.interface'; export const TeamListItemRenderer = (props: EntityReference) => { return ( - + {getEntityName(props)} ); @@ -378,12 +381,12 @@ export const UserTeamSelectableList = ({ const defaultTrigger = hasPermission ? ( - } - size="small" - title={getEditTriggerTitle()} + icon={Edit02} + size="xs" + tooltip={getEditTriggerTitle()} onClick={handleTriggerClick} /> @@ -424,23 +427,26 @@ export const UserTeamSelectableList = ({ entity: label ?? t('label.owner-plural'), })} -
- {selectedUsers.map((user) => { - return ( - onRemove(user.id)} - /> - ); - })} -
+ + + {selectedUsers.map((user) => ( + onRemove(user.id)}> + + {getEntityName(user)} + + ))} + +
) : null; @@ -514,7 +520,7 @@ export const UserTeamSelectableList = ({ {triggerElement} = ({ return ( { @@ -64,7 +65,7 @@ const ViewToggle: FC = ({ return ( { direction="col"> {detailKey === undefined ? ( <> - + {/* Kept when empty, so the dimension picker stays on the right. */} {hasStats && ( diff --git a/openmetadata-ui/src/main/resources/ui/src/components/platform/ai-shell/Sidebar/sidebar.less b/openmetadata-ui/src/main/resources/ui/src/components/platform/ai-shell/Sidebar/sidebar.less index 836f1e3e1085..0a06101c4e97 100644 --- a/openmetadata-ui/src/main/resources/ui/src/components/platform/ai-shell/Sidebar/sidebar.less +++ b/openmetadata-ui/src/main/resources/ui/src/components/platform/ai-shell/Sidebar/sidebar.less @@ -1446,9 +1446,20 @@ background: @ask-bg-active; color: @ask-brand-active; + // Visited links must keep the selected icon's foreground instead of + // inheriting the browser/legacy link accent through currentColor. + &:link, + &:visited, + &:focus, &:hover { color: @ask-brand-active; } + + // Match expanded navigation: the icon owns its foreground so link-state + // colors cannot change a currentColor glyph when the pointer leaves. + svg { + color: @ask-brand-active; + } } svg { diff --git a/openmetadata-ui/src/main/resources/ui/src/pages/ContextCenterPage/ContextCenterAIContextPage/ContextCenterAIContextDetailPage.tsx b/openmetadata-ui/src/main/resources/ui/src/pages/ContextCenterPage/ContextCenterAIContextPage/ContextCenterAIContextDetailPage.tsx index 1bd73c306674..9e6ce0fbf114 100644 --- a/openmetadata-ui/src/main/resources/ui/src/pages/ContextCenterPage/ContextCenterAIContextPage/ContextCenterAIContextDetailPage.tsx +++ b/openmetadata-ui/src/main/resources/ui/src/pages/ContextCenterPage/ContextCenterAIContextPage/ContextCenterAIContextDetailPage.tsx @@ -63,7 +63,7 @@ const ContextCenterAIContextDetailPage = () => { return (
{ return (
{ return (
{ return (
{ {recentlyViewedItems.map((item) => ( { {mostCitedItems.map((item) => ( { return ( diff --git a/openmetadata-ui/src/main/resources/ui/src/pages/ContextCenterPage/ContextCenterMemoriesPage/ContextCenterMemoriesPage.tsx b/openmetadata-ui/src/main/resources/ui/src/pages/ContextCenterPage/ContextCenterMemoriesPage/ContextCenterMemoriesPage.tsx index e702e658debd..8395e4e28b02 100644 --- a/openmetadata-ui/src/main/resources/ui/src/pages/ContextCenterPage/ContextCenterMemoriesPage/ContextCenterMemoriesPage.tsx +++ b/openmetadata-ui/src/main/resources/ui/src/pages/ContextCenterPage/ContextCenterMemoriesPage/ContextCenterMemoriesPage.tsx @@ -781,7 +781,7 @@ const ContextCenterMemoriesPage: FC = () => { return ( diff --git a/openmetadata-ui/src/main/resources/ui/src/pages/TasksPage/shared/DescriptionTabs.tsx b/openmetadata-ui/src/main/resources/ui/src/pages/TasksPage/shared/DescriptionTabs.tsx index 0c4d08c81b7e..028c215346d8 100644 --- a/openmetadata-ui/src/main/resources/ui/src/pages/TasksPage/shared/DescriptionTabs.tsx +++ b/openmetadata-ui/src/main/resources/ui/src/pages/TasksPage/shared/DescriptionTabs.tsx @@ -77,7 +77,7 @@ export const DescriptionTabs = ({ {description?.trim() ? ( diff --git a/openmetadata-ui/src/main/resources/ui/src/pages/TasksPage/shared/DiffViewNew.tsx b/openmetadata-ui/src/main/resources/ui/src/pages/TasksPage/shared/DiffViewNew.tsx index b3e43bb9497e..e5d6c522dcda 100644 --- a/openmetadata-ui/src/main/resources/ui/src/pages/TasksPage/shared/DiffViewNew.tsx +++ b/openmetadata-ui/src/main/resources/ui/src/pages/TasksPage/shared/DiffViewNew.tsx @@ -146,13 +146,11 @@ export const DiffViewNew = ({ style={{ ...(showDescTitle ? { - background: 'rgba(239, 244, 250, 0.25)', borderRadius: '12px', } : { padding: '20px', borderRadius: '8px', - background: 'white', margin: '16px 0px', }), }}> diff --git a/openmetadata-ui/src/main/resources/ui/src/styles/app.less b/openmetadata-ui/src/main/resources/ui/src/styles/app.less index b3d9ef718bc4..97089e31f35d 100644 --- a/openmetadata-ui/src/main/resources/ui/src/styles/app.less +++ b/openmetadata-ui/src/main/resources/ui/src/styles/app.less @@ -684,12 +684,10 @@ a[href].link-text-grey, /* Diff style */ .diff-added { - // background: @success-background-color; width: fit-content; - color: @success-color; * { - color: @success-color; + color: var(--tw-color-utility-success-700); } } @@ -702,7 +700,7 @@ a[href].link-text-grey, font-weight: var(--om-font-weight-regular); line-height: 20px; width: fit-content; - color: var(--om-legacy-color-027a48); + color: var(--tw-color-utility-success-700); } .diff-removed-new, @@ -715,9 +713,9 @@ a[href].link-text-grey, width: fit-content; text-decoration: line-through; text-decoration-thickness: 1.5px; - text-decoration-color: var(--om-color-error-400); + text-decoration-color: var(--tw-color-utility-error-700); text-decoration-skip-ink: auto; - color: var(--om-color-error-400); + color: var(--tw-color-utility-error-700); } .diff-normal-new { @@ -731,8 +729,7 @@ a[href].link-text-grey, .diff-normal-new strong { font-weight: var(--om-font-weight-semibold); - color: var(--om-color-black); - /* Adjust color if needed */ + color: var(--tw-color-text-primary); } .clamp-text-2 { diff --git a/openmetadata-ui/src/main/resources/ui/src/styles/components/code-mirror.less b/openmetadata-ui/src/main/resources/ui/src/styles/components/code-mirror.less index f3414f82a9e9..f21487a6381d 100644 --- a/openmetadata-ui/src/main/resources/ui/src/styles/components/code-mirror.less +++ b/openmetadata-ui/src/main/resources/ui/src/styles/components/code-mirror.less @@ -52,7 +52,7 @@ height: auto !important; } .custom-query-editor { - border: @global-border; + border: 1px solid var(--tw-color-border-subtle); border-radius: @border-rad-base; .cm-editor { border-radius: @border-rad-base; diff --git a/openmetadata-ui/src/main/resources/ui/src/utils/TestCaseUtils.tsx b/openmetadata-ui/src/main/resources/ui/src/utils/TestCaseUtils.tsx index 7b2f78813a3c..d51f4f00b044 100644 --- a/openmetadata-ui/src/main/resources/ui/src/utils/TestCaseUtils.tsx +++ b/openmetadata-ui/src/main/resources/ui/src/utils/TestCaseUtils.tsx @@ -12,13 +12,13 @@ */ import { Typography } from '@openmetadata/ui-core-components'; +import { Upload01 as ImportIcon } from '@openmetadata/ui-core-components/icons'; import { ItemType } from 'antd/lib/menu/hooks/useItems'; import { lowerCase } from 'lodash'; import type { ReactElement, ReactNode } from 'react'; import { NavigateFunction } from 'react-router-dom'; import { ReactComponent as IconEdit } from '../assets/svg/edit-new.svg'; import { ReactComponent as ExportIcon } from '../assets/svg/ic-export.svg'; -import { ReactComponent as ImportIcon } from '../assets/svg/ic-import.svg'; import { ManageButtonItemLabel } from '../components/common/ManageButtonContentItem/ManageButtonContentItem.component'; import { ManageMenuItem } from '../components/common/ManageMenuButton/ManageMenuButton.component'; import { ExportData } from '../components/Entity/EntityExportModalProvider/EntityExportModalProvider.interface';