From 1e2a2bcbebf91be8c39cf747cddb312663923ad9 Mon Sep 17 00:00:00 2001 From: Harshit Shah Date: Mon, 12 Oct 2026 21:52:23 +0530 Subject: [PATCH 1/3] fix(ui): dark-mode legacy surfaces and borders render light tokens.css (imported after app.less) declares light values for the legacy --om-* aliases on :root, which ties the .dark-mode bridge on and wins on order, so every bridged var stayed light in dark. Scope the bridge to :root.dark-mode. - point #dde3ea borders at the core secondary border token - column panel: drop max-width 95% that always clipped the title; align Key Profile Metrics padding/divider with sibling sections - dark accents follow the devrel palette: brand-400 for text/icons/links, brand-600 for the selected explore card and nav pill (20%) Fixes open-metadata/openmetadata-collate#7317 --- .../main/resources/ui/src/styles/globals.css | 16 ++--- .../ActivityFeed/FeedEditor/feed-editor.less | 4 +- .../ColumnDetailPanel/ColumnDetailPanel.less | 1 - .../KeyProfileMetrics.component.tsx | 4 +- .../RetentionPeriod.component.tsx | 4 +- .../explore-search-card.less | 6 ++ .../ExploreV1/ExploreV1.component.tsx | 4 +- .../src/components/Glossary/glossaryV1.less | 2 +- .../src/components/Settings/Users/users.less | 2 +- .../ManageButton/ManageButton.less | 2 +- .../connection-step-card.less | 2 +- .../platform/ai-shell/Sidebar/sidebar.less | 21 ++++--- .../src/main/resources/ui/src/styles/app.less | 58 ++++++++++--------- .../main/resources/ui/src/styles/modal.less | 4 +- .../main/resources/ui/src/styles/tailwind.css | 4 +- .../resources/ui/src/styles/variables.less | 2 +- 16 files changed, 74 insertions(+), 62 deletions(-) diff --git a/openmetadata-ui-core-components/src/main/resources/ui/src/styles/globals.css b/openmetadata-ui-core-components/src/main/resources/ui/src/styles/globals.css index 736eb7dcc225..d189603012ef 100644 --- a/openmetadata-ui-core-components/src/main/resources/ui/src/styles/globals.css +++ b/openmetadata-ui-core-components/src/main/resources/ui/src/styles/globals.css @@ -1226,12 +1226,12 @@ --color-text-disabled: theme(--color-gray-500); /* Brand text = blue-300 link tone in dark (palette guideline + Collate #6491 --ai-link); regular text stays on the gray ramp. */ - --color-text-brand-primary: theme(--color-brand-300); - --color-text-brand-secondary: theme(--color-brand-300); + --color-text-brand-primary: theme(--color-brand-400); + --color-text-brand-secondary: theme(--color-brand-400); --color-text-brand-tertiary: theme(--color-gray-400); --color-text-placeholder: theme(--color-gray-400); --color-text-placeholder_subtle: theme(--color-gray-700); - --color-text-link: theme(--color-brand-300); + --color-text-link: theme(--color-brand-400); --color-text-link-hover: theme(--color-brand-200); --color-text-primary_on-brand: theme(--color-gray-50); --color-text-secondary_on-brand: theme(--color-gray-300); @@ -1282,10 +1282,10 @@ --color-fg-disabled_subtle: theme(--color-gray-600); /* Brand foreground (icons, tab underline, active accents) = blue-300 link tone in dark (palette guideline + Collate #6491 --ai-link). */ - --color-fg-brand-primary: theme(--color-brand-300); - --color-fg-brand-secondary: theme(--color-brand-300); - --color-fg-brand-primary_alt: theme(--color-brand-300); - --color-fg-brand-secondary_alt: theme(--color-brand-300); + --color-fg-brand-primary: theme(--color-brand-400); + --color-fg-brand-secondary: theme(--color-brand-400); + --color-fg-brand-primary_alt: theme(--color-brand-400); + --color-fg-brand-secondary_alt: theme(--color-brand-400); --color-fg-brand-secondary_hover: theme(--color-brand-200); /* BACKGROUND COLORS */ @@ -1350,7 +1350,7 @@ --color-avatar-styles-bg-neutral: rgb(224 224 224 / 1); --color-button-destructive-primary-icon: theme(--color-error-300); --color-button-destructive-primary-icon_hover: theme(--color-error-200); - --color-button-primary-icon: theme(--color-brand-300); + --color-button-primary-icon: theme(--color-brand-400); --color-button-primary-icon_hover: theme(--color-brand-200); --color-featured-icon-light-fg-brand: theme(--color-brand-200); --color-featured-icon-light-fg-error: theme(--color-error-200); diff --git a/openmetadata-ui/src/main/resources/ui/src/components/ActivityFeed/FeedEditor/feed-editor.less b/openmetadata-ui/src/main/resources/ui/src/components/ActivityFeed/FeedEditor/feed-editor.less index 6344c0c92835..462b36bce87c 100644 --- a/openmetadata-ui/src/main/resources/ui/src/components/ActivityFeed/FeedEditor/feed-editor.less +++ b/openmetadata-ui/src/main/resources/ui/src/components/ActivityFeed/FeedEditor/feed-editor.less @@ -999,7 +999,7 @@ margin: var(--om-space-6); } .ql-toolbar.ql-snow { - border-color: var(--om-legacy-color-dde3ea); + border-color: var(--tw-border-color-secondary); border-top-left-radius: var(--om-radius-md); border-top-right-radius: var(--om-radius-md); display: flex; @@ -1009,7 +1009,7 @@ width: 100%; } .ql-container.ql-snow { - border-color: var(--om-legacy-color-dde3ea); + border-color: var(--tw-border-color-secondary); border-bottom-left-radius: var(--om-radius-md); border-bottom-right-radius: var(--om-radius-md); width: 100%; diff --git a/openmetadata-ui/src/main/resources/ui/src/components/Database/ColumnDetailPanel/ColumnDetailPanel.less b/openmetadata-ui/src/main/resources/ui/src/components/Database/ColumnDetailPanel/ColumnDetailPanel.less index 0b6bece50ec5..26e1437d7e18 100644 --- a/openmetadata-ui/src/main/resources/ui/src/components/Database/ColumnDetailPanel/ColumnDetailPanel.less +++ b/openmetadata-ui/src/main/resources/ui/src/components/Database/ColumnDetailPanel/ColumnDetailPanel.less @@ -91,7 +91,6 @@ overflow: hidden; text-overflow: ellipsis; white-space: nowrap; - max-width: 95%; } } diff --git a/openmetadata-ui/src/main/resources/ui/src/components/Database/ColumnDetailPanel/KeyProfileMetrics/KeyProfileMetrics.component.tsx b/openmetadata-ui/src/main/resources/ui/src/components/Database/ColumnDetailPanel/KeyProfileMetrics/KeyProfileMetrics.component.tsx index 60ed5c5f055c..d30a840f8fe6 100644 --- a/openmetadata-ui/src/main/resources/ui/src/components/Database/ColumnDetailPanel/KeyProfileMetrics/KeyProfileMetrics.component.tsx +++ b/openmetadata-ui/src/main/resources/ui/src/components/Database/ColumnDetailPanel/KeyProfileMetrics/KeyProfileMetrics.component.tsx @@ -29,8 +29,8 @@ export const KeyProfileMetrics = ({ profile }: KeyProfileMetricsProps) => { ); const sectionClassName = - 'tw:border-b-[0.6px] tw:border-tertiary tw:-mt-2 tw:pb-4 tw:px-4'; - const titleClassName = 'tw:text-sm tw:font-semibold tw:mb-1.5'; + 'tw:border-b-[0.6px] tw:border-secondary tw:pb-4 tw:px-3.5'; + const titleClassName = 'tw:text-sm tw:font-semibold tw:mb-3'; return (
diff --git a/openmetadata-ui/src/main/resources/ui/src/components/Database/RetentionPeriod/RetentionPeriod.component.tsx b/openmetadata-ui/src/main/resources/ui/src/components/Database/RetentionPeriod/RetentionPeriod.component.tsx index af240f9f4428..f898c7fc1978 100644 --- a/openmetadata-ui/src/main/resources/ui/src/components/Database/RetentionPeriod/RetentionPeriod.component.tsx +++ b/openmetadata-ui/src/main/resources/ui/src/components/Database/RetentionPeriod/RetentionPeriod.component.tsx @@ -145,7 +145,7 @@ const RetentionPeriod = ({ width={520}> - +