From 134d6303e8ab29a0df2b26eeac44ddca028f479d Mon Sep 17 00:00:00 2001 From: Fabrizio Antonangeli Date: Tue, 10 Nov 2026 10:35:08 +0100 Subject: [PATCH 1/2] test: Capture Playwright artifacts on E2E test failures Related to open-workflow-specification/editor#524 Signed-off-by: Fabrizio Antonangeli --- packages/dual-editor/playwright.config.ts | 3 +++ packages/open-workflow-diagram-editor/playwright.config.ts | 3 +++ packages/text-editor/playwright.config.ts | 3 +++ 3 files changed, 9 insertions(+) diff --git a/packages/dual-editor/playwright.config.ts b/packages/dual-editor/playwright.config.ts index 30bfa316..28a6e8d6 100644 --- a/packages/dual-editor/playwright.config.ts +++ b/packages/dual-editor/playwright.config.ts @@ -22,6 +22,9 @@ export default defineConfig({ timeout: 30000, }, use: { + screenshot: "only-on-failure", + video: "retain-on-failure", + trace: "retain-on-failure", baseURL: "http://localhost:6008", permissions: ["clipboard-read", "clipboard-write"], }, diff --git a/packages/open-workflow-diagram-editor/playwright.config.ts b/packages/open-workflow-diagram-editor/playwright.config.ts index 587044ab..3de2b220 100644 --- a/packages/open-workflow-diagram-editor/playwright.config.ts +++ b/packages/open-workflow-diagram-editor/playwright.config.ts @@ -24,6 +24,9 @@ export default defineConfig({ }, use: { + screenshot: "only-on-failure", + video: "retain-on-failure", + trace: "retain-on-failure", baseURL: "http://localhost:6006", }, diff --git a/packages/text-editor/playwright.config.ts b/packages/text-editor/playwright.config.ts index e7274047..2d2b2f8e 100644 --- a/packages/text-editor/playwright.config.ts +++ b/packages/text-editor/playwright.config.ts @@ -24,6 +24,9 @@ export default defineConfig({ }, use: { + screenshot: "only-on-failure", + video: "retain-on-failure", + trace: "retain-on-failure", baseURL: "http://localhost:6007", permissions: ["clipboard-read", "clipboard-write"], }, From 8ee2845f616ded7fa91195f391e0ca89c4052707 Mon Sep 17 00:00:00 2001 From: Fabrizio Antonangeli Date: Tue, 10 Nov 2026 10:35:28 +0100 Subject: [PATCH 2/2] test: Force Diagram and Text Editor failures to verify CI artifacts Append intentional failing expectations and continue recursive CI builds so both packages can produce failure artifacts. Do not merge this commit. Signed-off-by: Fabrizio Antonangeli --- .github/workflows/ci_build.yaml | 2 +- .../tests-e2e/validation-error.spec.ts | 2 ++ packages/text-editor/tests-e2e/text-editor.spec.ts | 2 ++ 3 files changed, 5 insertions(+), 1 deletion(-) diff --git a/.github/workflows/ci_build.yaml b/.github/workflows/ci_build.yaml index f35eeb4b..0a678945 100644 --- a/.github/workflows/ci_build.yaml +++ b/.github/workflows/ci_build.yaml @@ -55,7 +55,7 @@ jobs: run: pnpm dependencies:check - name: Build and test - run: pnpm --workspace-concurrency=1 build:prod + run: pnpm -r --no-bail --workspace-concurrency=1 --stream --if-present build:prod - name: Upload Playwright Artifacts if: failure() diff --git a/packages/open-workflow-diagram-editor/tests-e2e/validation-error.spec.ts b/packages/open-workflow-diagram-editor/tests-e2e/validation-error.spec.ts index 98aeab8c..6359a364 100644 --- a/packages/open-workflow-diagram-editor/tests-e2e/validation-error.spec.ts +++ b/packages/open-workflow-diagram-editor/tests-e2e/validation-error.spec.ts @@ -70,4 +70,6 @@ test("a nested task's error marks the child node, not its container", async ({ p await expect(errors).toBeVisible(); await expect(errors.getByText("must have required property 'endpoint'")).toBeVisible(); await expect(errors.locator(".dec-sidebar-error-field")).toHaveText("with"); + + expect(true, "Intentional failure to verify Playwright artifacts for #524").toBe(false); }); diff --git a/packages/text-editor/tests-e2e/text-editor.spec.ts b/packages/text-editor/tests-e2e/text-editor.spec.ts index f83ec018..dbad98d5 100644 --- a/packages/text-editor/tests-e2e/text-editor.spec.ts +++ b/packages/text-editor/tests-e2e/text-editor.spec.ts @@ -185,6 +185,8 @@ test.describe("TextEditor JSON", () => { await page.keyboard.press("ControlOrMeta+v"); await expect(monacoContainer.locator(".squiggly-warning").first()).not.toBeVisible(); + + expect(true, "Intentional failure to verify Playwright artifacts for #524").toBe(false); }); }); });