From ab662fc18058704decde877db2b8cfe88420ab9b Mon Sep 17 00:00:00 2001 From: Aleksandar Fabijanic Date: Wed, 28 Oct 2026 20:09:33 -0500 Subject: [PATCH 1/2] fix(Foundation): TaskManagerTest::testCancel waits for the progress notification Task::setProgress() stores the progress before the TaskProgressNotification reaches the observer, so the test could check the progress of the observer before the notification arrived. Wait for the observer, as testFinish does. --- Foundation/testsuite/src/TaskManagerTest.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Foundation/testsuite/src/TaskManagerTest.cpp b/Foundation/testsuite/src/TaskManagerTest.cpp index f969837aed..c4b0842375 100644 --- a/Foundation/testsuite/src/TaskManagerTest.cpp +++ b/Foundation/testsuite/src/TaskManagerTest.cpp @@ -349,7 +349,7 @@ void TaskManagerTest::testCancel() assertTrue (pTT->progress() == 0); Thread::sleep(200); pTT->cont(); - assertTrue (waitForCondition([&]{ return pTT->progress() == 0.5f; }, 5000)); + assertTrue (waitForCondition([&]{ return to.progress() > 0; }, 5000)); assertTrue (to.progress() == 0.5); assertTrue (to.started()); assertTrue (pTT->state() == Task::TASK_RUNNING); From e8854c5ceb5b7c3da9b91c9988846568a9117f2a Mon Sep 17 00:00:00 2001 From: Aleksandar Fabijanic Date: Wed, 28 Oct 2026 21:34:26 -0500 Subject: [PATCH 2/2] chore(Foundation): stop ignoring TaskManagerTest::testCancel on Windows With the race in the test fixed, cppignore.win no longer needs the entry. --- cppignore.win | 1 - 1 file changed, 1 deletion(-) diff --git a/cppignore.win b/cppignore.win index 40afeae138..456cc7da02 100644 --- a/cppignore.win +++ b/cppignore.win @@ -25,4 +25,3 @@ class CppUnit::TestCaller.testChannelFacility class CppUnit::TestCaller.testChannelOpenClose class CppUnit::TestCaller.testOldBSD class CppUnit::TestCaller.testStructuredData -class CppUnit::TestCaller.testCancel