From 582453e8bf8a713fb58727972bc038dfb810ee53 Mon Sep 17 00:00:00 2001 From: Alex Nazaruk Date: Thu, 2 Jul 2026 23:02:55 +0200 Subject: [PATCH] fix(desktop): drop misleading --metrics-recording-only=false from PRIVACY_FLAGS MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit PRIVACY_FLAGS is documented as flags that 'hard-disable phone-home / telemetry' and is applied by default whenever telemetry is not opted in, but '--metrics-recording-only=false' does not disable telemetry — the switch only ever governs local metrics recording, and passing it here is at best a no-op and at worst misleading given the file's stated guarantee and the project's 'No telemetry by default' rule. The actual no-telemetry posture is enforced by the other PRIVACY_FLAGS (--disable-background-networking, --disable-breakpad, --disable-crash-reporter, --no-pings, --disable-domain-reliability) plus the compile-time build config. Removing this flag strictly improves clarity and cannot weaken privacy. The dynamic-iteration test needs no change. --- apps/desktop/src/chromium-flags.ts | 1 - 1 file changed, 1 deletion(-) diff --git a/apps/desktop/src/chromium-flags.ts b/apps/desktop/src/chromium-flags.ts index 60f3f76..45dca0e 100644 --- a/apps/desktop/src/chromium-flags.ts +++ b/apps/desktop/src/chromium-flags.ts @@ -49,7 +49,6 @@ export const PRIVACY_FLAGS = [ '--disable-features=Translate,OptimizationHints,InterestFeedContentSuggestions', '--no-default-browser-check', '--no-pings', - '--metrics-recording-only=false', '--disable-sync', ] as const;