From 2636d3bec8bd92d27055a45a66bd7654fba3e4f2 Mon Sep 17 00:00:00 2001 From: elonfliter Date: Mon, 19 Oct 2026 09:28:36 +0800 Subject: [PATCH] docs: correct misleading comments in gas consumption rules Signed-off-by: elonfliter --- lib/rules/gas-consumption/gas-small-strings.js | 2 +- lib/rules/gas-consumption/gas-struct-packing.js | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/lib/rules/gas-consumption/gas-small-strings.js b/lib/rules/gas-consumption/gas-small-strings.js index 6be5d04f..5aa37ffd 100644 --- a/lib/rules/gas-consumption/gas-small-strings.js +++ b/lib/rules/gas-consumption/gas-small-strings.js @@ -140,7 +140,7 @@ class GasSmallStrings extends BaseChecker { isStringLargerThan32Bytes(inputString) { if (inputString.startsWith('0x') && inputString.length === 42) { - // Check if the input is a valid Ethereum address + // Exempt 42-character strings starting with '0x' without validating hex digits or checksum return false } else { // Convert the string to Buffer and get its byte length diff --git a/lib/rules/gas-consumption/gas-struct-packing.js b/lib/rules/gas-consumption/gas-struct-packing.js index d0bcdd41..c0c7f207 100644 --- a/lib/rules/gas-consumption/gas-struct-packing.js +++ b/lib/rules/gas-consumption/gas-struct-packing.js @@ -91,7 +91,7 @@ class GasStructPacking extends BaseChecker { // calculateCurrentSlotsUsed const currentSlots = this.calculateCurrentSlotsUsed(members) - // calculate optimal slots by rounding up the total size of members in descending order + // Estimate improved packing by sorting members by descending size and simulating slot usage const sortedMembers = [...members].sort((a, b) => b.size - a.size) const optimalSlots = this.calculateCurrentSlotsUsed(sortedMembers)