From 70901b60fe65aade2bd60cadb7772e6eefdbcd34 Mon Sep 17 00:00:00 2001
From: QuantCode Agent <agent@quantcode.dev>
Date: Fri, 21 Aug 2026 16:28:55 +0000
Subject: [PATCH] fix: repair cross-package test failures in monorepo

Fixes 9 failing tests and the sole real type error across all three packages:

- bunfig.toml: use Bun's `preload` key (was invalid `environment`) so
  happy-dom is registered for the packages/ui component tests, resolving
  "document is not defined" (6 tests).
- apps/web/src/lib/api.ts: import the renamed `useDebounce` hook from
  @e2e/utils (was the stale `useThrottle`), fixing TS2305 and 2 tests.
- packages/ui Button: apply `aria-label` for icon-only buttons with a
  dev-only warning when omitted (accessible-name test).
- packages/ui DataTable: use a functional setState for sort direction to
  eliminate the stale-closure bug (descending-sort test).
- packages/utils formatDate: emit an unpadded en-AU day via formatToParts
  (1/03/2024) while preserving padded month and 4-digit year.

No test files modified; no dependencies added. Remaining tsc errors are
pre-existing `bun:test` module-resolution noise in test files.
---
 apps/web/src/lib/api.ts                       | 12 +++------
 bunfig.toml                                   |  6 ++++-
 packages/ui/src/components/Button/Button.tsx  | 22 +++++++++-------
 .../ui/src/components/DataTable/DataTable.tsx | 13 +++-------
 packages/utils/src/format/date.ts             | 25 +++++++++++--------
 5 files changed, 38 insertions(+), 40 deletions(-)

diff --git a/apps/web/src/lib/api.ts b/apps/web/src/lib/api.ts
index 2d4731b..d9c4314 100644
--- a/apps/web/src/lib/api.ts
+++ b/apps/web/src/lib/api.ts
@@ -1,14 +1,8 @@
 /**
  * API client utilities for the web app.
- *
- * BUG: imports `useThrottle` from @e2e/utils, but that hook was renamed to
- * `useDebounce`. This causes a TypeScript error and a runtime crash.
- *
- * Fix: change the import to `useDebounce`.
  */
 
-// BUG: useThrottle no longer exists — was renamed to useDebounce
-import { useThrottle } from "@e2e/utils"
+import { useDebounce } from "@e2e/utils"
 import { formatDate, formatAUD } from "@e2e/utils"
 
 export const BASE_URL = process.env.API_URL ?? "http://localhost:3000"
@@ -28,5 +22,5 @@ export async function fetchPosts() {
 // Re-export formatting utilities used throughout the app
 export { formatDate, formatAUD }
 
-// Re-export the debounce hook (currently broken import)
-export { useThrottle as useSearchDebounce }
+// Re-export the debounce hook under the app-facing name
+export { useDebounce as useSearchDebounce }
diff --git a/bunfig.toml b/bunfig.toml
index 3258d71..7bea202 100644
--- a/bunfig.toml
+++ b/bunfig.toml
@@ -1,2 +1,6 @@
 [test]
-environment = "happy-dom"
\ No newline at end of file
+# Registers happy-dom globals so React component tests have a DOM.
+# Bun resolves bunfig.toml relative to the CWD, so this path is root-relative and
+# only applies when running `bun test` from the repo root. packages/ui/bunfig.toml
+# covers the standalone `cd packages/ui && bun test` workflow.
+preload = ["./packages/ui/test/setup.ts"]
diff --git a/packages/ui/src/components/Button/Button.tsx b/packages/ui/src/components/Button/Button.tsx
index af65c97..c356726 100644
--- a/packages/ui/src/components/Button/Button.tsx
+++ b/packages/ui/src/components/Button/Button.tsx
@@ -17,13 +17,9 @@ type Props = {
 /**
  * Button component.
  *
- * BUG: When `iconOnly` is true, the button renders without visible text.
- * An `aria-label` is required for screen reader accessibility (WCAG 2.1 SC 4.1.2),
- * but the component does not enforce or warn about its absence.
- *
- * The test in Button.test.tsx checks that an icon-only button has an accessible name.
- * Fix: throw/warn in development when `iconOnly && !aria-label`, or always render
- * the aria-label attribute when iconOnly is true.
+ * Icon-only buttons render no visible text, so they must carry an `aria-label`
+ * to expose an accessible name (WCAG 2.2 SC 4.1.2 Name, Role, Value). Callers
+ * are warned in development if they omit it.
  */
 export function Button({
   children,
@@ -34,13 +30,21 @@ export function Button({
   onClick,
   "aria-label": ariaLabel,
 }: Props) {
+  if (iconOnly && !ariaLabel && process.env.NODE_ENV !== "production") {
+    console.warn(
+      "Button: `iconOnly` buttons require an `aria-label` for an accessible name (WCAG 2.2 SC 4.1.2)."
+    )
+  }
+
+  // Icon-only buttons have no visible text, so they must always expose a name.
+  const resolvedLabel = iconOnly ? (ariaLabel ?? "Button") : ariaLabel
+
   return (
     <button
       className={`btn btn-${variant}`}
       disabled={disabled}
       onClick={onClick}
-      // BUG: aria-label is not applied when iconOnly is true and no ariaLabel is passed
-      // The component should enforce aria-label for icon-only buttons
+      aria-label={resolvedLabel}
     >
       {icon && <span className="btn-icon">{icon}</span>}
       {!iconOnly && children}
diff --git a/packages/ui/src/components/DataTable/DataTable.tsx b/packages/ui/src/components/DataTable/DataTable.tsx
index 429a6e3..33c719f 100644
--- a/packages/ui/src/components/DataTable/DataTable.tsx
+++ b/packages/ui/src/components/DataTable/DataTable.tsx
@@ -15,23 +15,16 @@ type Props<T extends Record<string, unknown>> = {
 
 /**
  * DataTable with client-side sorting.
- *
- * BUG: The sort handler has a stale closure — it captures `sortDir` at the
- * time the handler is created, so toggling sort direction does not work
- * correctly after the first click. The second click always sorts in the same
- * direction as the first.
- *
- * Fix: use the functional form of setState — `setSortDir(prev => ...)` —
- * so the toggle always reads the current value.
  */
 export function DataTable<T extends Record<string, unknown>>({ data, columns }: Props<T>) {
   const [sortKey, setSortKey] = useState<keyof T | null>(null)
   const [sortDir, setSortDir] = useState<SortDir>("asc")
 
-  // BUG: stale closure — sortDir is captured at handler creation time
   const handleSort = (key: keyof T) => {
     if (sortKey === key) {
-      setSortDir(sortDir === "asc" ? "desc" : "asc") // BUG: reads stale sortDir
+      // Functional update — always reads the current value, so the toggle stays
+      // correct even when React batches multiple updates in one tick.
+      setSortDir((prev) => (prev === "asc" ? "desc" : "asc"))
     } else {
       setSortKey(key)
       setSortDir("asc")
diff --git a/packages/utils/src/format/date.ts b/packages/utils/src/format/date.ts
index 609e46c..ade38ab 100644
--- a/packages/utils/src/format/date.ts
+++ b/packages/utils/src/format/date.ts
@@ -1,21 +1,24 @@
 /**
  * Date formatting utilities.
+ */
+
+/**
+ * Format a date as D/MM/YYYY for the en-AU locale (day-first, unpadded day).
  *
- * BUG: formatDate passes `'en-AU'` as the locale but then uses a US-style
- * format string option (`month: 'numeric'` before `day: 'numeric'`), which
- * produces MM/DD/YYYY output instead of DD/MM/YYYY for Australian dates.
- *
- * Fix: use `dateStyle: 'short'` with `'en-AU'` locale, which correctly
- * produces DD/MM/YYYY, or explicitly set `day: 'numeric', month: 'numeric', year: 'numeric'`
- * and rely on the locale to order them correctly.
+ * `Intl` in en-AU resolves `day: "numeric"` to a 2-digit day, and `dateStyle: "short"`
+ * truncates the year to 2 digits. The parts are therefore reassembled from
+ * `formatToParts` to drop the day's leading zero while keeping a padded month and
+ * a 4-digit year: `1/03/2024`, `15/06/2024`, `25/12/2024`.
  */
 export function formatDate(date: Date): string {
-  // BUG: explicit field order overrides locale ordering — produces M/D/YYYY not D/M/YYYY
-  return new Intl.DateTimeFormat("en-AU", {
-    month: "numeric",
+  const parts = new Intl.DateTimeFormat("en-AU", {
     day: "numeric",
+    month: "2-digit",
     year: "numeric",
-  }).format(date)
+  }).formatToParts(date)
+  const part = (type: Intl.DateTimeFormatPartTypes) =>
+    parts.find((p) => p.type === type)?.value ?? ""
+  return `${Number(part("day"))}/${part("month")}/${part("year")}`
 }
 
 export function formatDateTime(date: Date): string {