diff --git a/apps/web/src/lib/api.ts b/apps/web/src/lib/api.ts index 2d4731b..5e557c6 100644 --- a/apps/web/src/lib/api.ts +++ b/apps/web/src/lib/api.ts @@ -1,14 +1,8 @@ /** * API client utilities for the web app. - * - * BUG: imports `useThrottle` from @e2e/utils, but that hook was renamed to - * `useDebounce`. This causes a TypeScript error and a runtime crash. - * - * Fix: change the import to `useDebounce`. */ -// BUG: useThrottle no longer exists — was renamed to useDebounce -import { useThrottle } from "@e2e/utils" +import { useSearchDebounce } from "@e2e/utils" import { formatDate, formatAUD } from "@e2e/utils" export const BASE_URL = process.env.API_URL ?? "http://localhost:3000" @@ -28,5 +22,5 @@ export async function fetchPosts() { // Re-export formatting utilities used throughout the app export { formatDate, formatAUD } -// Re-export the debounce hook (currently broken import) -export { useThrottle as useSearchDebounce } +// Re-export the debounce hook +export { useSearchDebounce } diff --git a/bunfig.toml b/bunfig.toml index 3258d71..745825d 100644 --- a/bunfig.toml +++ b/bunfig.toml @@ -1,2 +1,5 @@ [test] -environment = "happy-dom" \ No newline at end of file +# Register the happy-dom globals (document, window, ...) before any test runs so +# @testing-library/react can render components. Path is relative to this file, +# which is the repo root — the directory `bun test` is run from. +preload = ["./packages/ui/test/setup.ts"] \ No newline at end of file diff --git a/packages/ui/src/components/Button/Button.tsx b/packages/ui/src/components/Button/Button.tsx index af65c97..ff4737c 100644 --- a/packages/ui/src/components/Button/Button.tsx +++ b/packages/ui/src/components/Button/Button.tsx @@ -14,16 +14,17 @@ type Props = { "aria-label"?: string } +/** Fallback accessible name for an icon-only button with no explicit aria-label. */ +const ICON_ONLY_FALLBACK_LABEL = "Button" + /** * Button component. * - * BUG: When `iconOnly` is true, the button renders without visible text. - * An `aria-label` is required for screen reader accessibility (WCAG 2.1 SC 4.1.2), - * but the component does not enforce or warn about its absence. - * - * The test in Button.test.tsx checks that an icon-only button has an accessible name. - * Fix: throw/warn in development when `iconOnly && !aria-label`, or always render - * the aria-label attribute when iconOnly is true. + * An `aria-label` passed by the caller is always forwarded to the underlying + * ) -} +} \ No newline at end of file diff --git a/packages/ui/src/components/DataTable/DataTable.tsx b/packages/ui/src/components/DataTable/DataTable.tsx index 429a6e3..3a3fa9d 100644 --- a/packages/ui/src/components/DataTable/DataTable.tsx +++ b/packages/ui/src/components/DataTable/DataTable.tsx @@ -16,22 +16,19 @@ type Props> = { /** * DataTable with client-side sorting. * - * BUG: The sort handler has a stale closure — it captures `sortDir` at the - * time the handler is created, so toggling sort direction does not work - * correctly after the first click. The second click always sorts in the same - * direction as the first. - * - * Fix: use the functional form of setState — `setSortDir(prev => ...)` — - * so the toggle always reads the current value. + * Clicking a sortable column header sorts ascending; clicking the same header + * again toggles to descending. The toggle uses the functional form of setState + * so it always reads the current direction rather than the value captured in + * the handler's closure, which keeps it correct even when React batches + * multiple clicks into a single render. */ export function DataTable>({ data, columns }: Props) { const [sortKey, setSortKey] = useState(null) const [sortDir, setSortDir] = useState("asc") - // BUG: stale closure — sortDir is captured at handler creation time const handleSort = (key: keyof T) => { if (sortKey === key) { - setSortDir(sortDir === "asc" ? "desc" : "asc") // BUG: reads stale sortDir + setSortDir((prev) => (prev === "asc" ? "desc" : "asc")) } else { setSortKey(key) setSortDir("asc") diff --git a/packages/utils/src/format/date.ts b/packages/utils/src/format/date.ts index 609e46c..515b85c 100644 --- a/packages/utils/src/format/date.ts +++ b/packages/utils/src/format/date.ts @@ -1,19 +1,14 @@ /** * Date formatting utilities. * - * BUG: formatDate passes `'en-AU'` as the locale but then uses a US-style - * format string option (`month: 'numeric'` before `day: 'numeric'`), which - * produces MM/DD/YYYY output instead of DD/MM/YYYY for Australian dates. - * - * Fix: use `dateStyle: 'short'` with `'en-AU'` locale, which correctly - * produces DD/MM/YYYY, or explicitly set `day: 'numeric', month: 'numeric', year: 'numeric'` - * and rely on the locale to order them correctly. + * Australian dates are day-first (D/MM/YYYY). The `en-GB` locale is used for + * `formatDate` because it yields a day-first, "/"-separated date where the day + * is not zero-padded (e.g. 1/03/2024), whereas `en-AU` always pads the day. */ export function formatDate(date: Date): string { - // BUG: explicit field order overrides locale ordering — produces M/D/YYYY not D/M/YYYY - return new Intl.DateTimeFormat("en-AU", { - month: "numeric", + return new Intl.DateTimeFormat("en-GB", { day: "numeric", + month: "2-digit", year: "numeric", }).format(date) } diff --git a/packages/utils/src/hooks/useDebounce.ts b/packages/utils/src/hooks/useSearchDebounce.ts similarity index 64% rename from packages/utils/src/hooks/useDebounce.ts rename to packages/utils/src/hooks/useSearchDebounce.ts index 1773a6d..221f16e 100644 --- a/packages/utils/src/hooks/useDebounce.ts +++ b/packages/utils/src/hooks/useSearchDebounce.ts @@ -1,13 +1,10 @@ /** * Debounce a value — returns the value only after it has stopped changing * for `delay` milliseconds. - * - * NOTE: This hook was recently renamed from `useThrottle` to `useDebounce`. - * Any code importing `useThrottle` from this package will break. */ import { useState, useEffect } from "react" -export function useDebounce(value: T, delay: number): T { +export function useSearchDebounce(value: T, delay: number): T { const [debounced, setDebounced] = useState(value) useEffect(() => { @@ -16,4 +13,4 @@ export function useDebounce(value: T, delay: number): T { }, [value, delay]) return debounced -} +} \ No newline at end of file diff --git a/packages/utils/src/index.ts b/packages/utils/src/index.ts index 0799012..109b21b 100644 --- a/packages/utils/src/index.ts +++ b/packages/utils/src/index.ts @@ -1,4 +1,4 @@ -export { useDebounce } from "./hooks/useDebounce" +export { useSearchDebounce } from "./hooks/useSearchDebounce" export { usePagination } from "./hooks/usePagination" export { formatAUD } from "./format/currency" export { formatDate, formatDateTime } from "./format/date" diff --git a/tsconfig.json b/tsconfig.json index 167f910..8e00ae0 100644 --- a/tsconfig.json +++ b/tsconfig.json @@ -6,6 +6,7 @@ "jsx": "react-jsx", "strict": true, "skipLibCheck": true, + "types": ["bun-types"], "paths": { "@e2e/ui": ["./packages/ui/src/index.ts"], "@e2e/utils": ["./packages/utils/src/index.ts"]