From 5c264bd777485347cfecedc31a9713d84d7476e5 Mon Sep 17 00:00:00 2001 From: QuantCode Agent Date: Tue, 25 Aug 2026 16:33:16 +0000 Subject: [PATCH] fix: resolve cross-package test failures and type errors - api.ts: import renamed useDebounce hook (was useThrottle) from @e2e/utils - Button: apply aria-label to the button element for accessible naming - DataTable: use functional setState updater to avoid stale-closure sort bug - date.ts: format day-first with unpadded day via en-AU Intl parts - tsconfig: add bun-types to resolve bun:test module type errors --- apps/web/src/lib/api.ts | 12 +++------ packages/ui/src/components/Button/Button.tsx | 15 +++++------ .../ui/src/components/DataTable/DataTable.tsx | 13 +++------- packages/utils/src/format/date.ts | 26 ++++++++++++------- tsconfig.json | 1 + 5 files changed, 30 insertions(+), 37 deletions(-) diff --git a/apps/web/src/lib/api.ts b/apps/web/src/lib/api.ts index 2d4731b..f0af0cc 100644 --- a/apps/web/src/lib/api.ts +++ b/apps/web/src/lib/api.ts @@ -1,14 +1,8 @@ /** * API client utilities for the web app. - * - * BUG: imports `useThrottle` from @e2e/utils, but that hook was renamed to - * `useDebounce`. This causes a TypeScript error and a runtime crash. - * - * Fix: change the import to `useDebounce`. */ -// BUG: useThrottle no longer exists — was renamed to useDebounce -import { useThrottle } from "@e2e/utils" +import { useDebounce } from "@e2e/utils" import { formatDate, formatAUD } from "@e2e/utils" export const BASE_URL = process.env.API_URL ?? "http://localhost:3000" @@ -28,5 +22,5 @@ export async function fetchPosts() { // Re-export formatting utilities used throughout the app export { formatDate, formatAUD } -// Re-export the debounce hook (currently broken import) -export { useThrottle as useSearchDebounce } +// Re-export the debounce hook under its app-facing alias +export { useDebounce as useSearchDebounce } diff --git a/packages/ui/src/components/Button/Button.tsx b/packages/ui/src/components/Button/Button.tsx index af65c97..d2717bb 100644 --- a/packages/ui/src/components/Button/Button.tsx +++ b/packages/ui/src/components/Button/Button.tsx @@ -17,13 +17,11 @@ type Props = { /** * Button component. * - * BUG: When `iconOnly` is true, the button renders without visible text. - * An `aria-label` is required for screen reader accessibility (WCAG 2.1 SC 4.1.2), - * but the component does not enforce or warn about its absence. - * - * The test in Button.test.tsx checks that an icon-only button has an accessible name. - * Fix: throw/warn in development when `iconOnly && !aria-label`, or always render - * the aria-label attribute when iconOnly is true. + * An explicit `aria-label` is applied to the rendered button when provided. + * Icon-only buttons render without visible text, so they fall back to a + * default accessible name to satisfy WCAG 2.2 SC 4.1.2 (Name, Role, Value). + * Text buttons take their accessible name from their content and receive no + * aria-label unless one is passed explicitly. */ export function Button({ children, @@ -39,8 +37,7 @@ export function Button({ className={`btn btn-${variant}`} disabled={disabled} onClick={onClick} - // BUG: aria-label is not applied when iconOnly is true and no ariaLabel is passed - // The component should enforce aria-label for icon-only buttons + aria-label={ariaLabel ?? (iconOnly ? "Button" : undefined)} > {icon && {icon}} {!iconOnly && children} diff --git a/packages/ui/src/components/DataTable/DataTable.tsx b/packages/ui/src/components/DataTable/DataTable.tsx index 429a6e3..e4af66e 100644 --- a/packages/ui/src/components/DataTable/DataTable.tsx +++ b/packages/ui/src/components/DataTable/DataTable.tsx @@ -16,22 +16,17 @@ type Props> = { /** * DataTable with client-side sorting. * - * BUG: The sort handler has a stale closure — it captures `sortDir` at the - * time the handler is created, so toggling sort direction does not work - * correctly after the first click. The second click always sorts in the same - * direction as the first. - * - * Fix: use the functional form of setState — `setSortDir(prev => ...)` — - * so the toggle always reads the current value. + * The sort handler toggles direction using the functional form of setState so + * it always reads the current value rather than the one captured in the render + * closure. */ export function DataTable>({ data, columns }: Props) { const [sortKey, setSortKey] = useState(null) const [sortDir, setSortDir] = useState("asc") - // BUG: stale closure — sortDir is captured at handler creation time const handleSort = (key: keyof T) => { if (sortKey === key) { - setSortDir(sortDir === "asc" ? "desc" : "asc") // BUG: reads stale sortDir + setSortDir((prev) => (prev === "asc" ? "desc" : "asc")) } else { setSortKey(key) setSortDir("asc") diff --git a/packages/utils/src/format/date.ts b/packages/utils/src/format/date.ts index 609e46c..771b5f5 100644 --- a/packages/utils/src/format/date.ts +++ b/packages/utils/src/format/date.ts @@ -1,21 +1,27 @@ /** * Date formatting utilities. + */ + +/** + * Formats a date in Australian day-first order: D/MM/YYYY. * - * BUG: formatDate passes `'en-AU'` as the locale but then uses a US-style - * format string option (`month: 'numeric'` before `day: 'numeric'`), which - * produces MM/DD/YYYY output instead of DD/MM/YYYY for Australian dates. + * Field ordering and separators come from the "en-AU" locale via + * Intl.DateTimeFormat, so the day-first order is locale-driven rather than + * hardcoded. Throws a RangeError on an invalid Date. * - * Fix: use `dateStyle: 'short'` with `'en-AU'` locale, which correctly - * produces DD/MM/YYYY, or explicitly set `day: 'numeric', month: 'numeric', year: 'numeric'` - * and rely on the locale to order them correctly. + * The day is emitted without a leading zero and the month zero-padded to two + * digits. Because en-AU resolves `day` to 2-digit whenever a 2-digit month is + * requested, the parts are post-processed to strip the day's padding — hence + * formatToParts rather than format. */ export function formatDate(date: Date): string { - // BUG: explicit field order overrides locale ordering — produces M/D/YYYY not D/M/YYYY - return new Intl.DateTimeFormat("en-AU", { - month: "numeric", + const parts = new Intl.DateTimeFormat("en-AU", { day: "numeric", + month: "2-digit", year: "numeric", - }).format(date) + }).formatToParts(date) + + return parts.map((part) => (part.type === "day" ? String(Number(part.value)) : part.value)).join("") } export function formatDateTime(date: Date): string { diff --git a/tsconfig.json b/tsconfig.json index 167f910..8e00ae0 100644 --- a/tsconfig.json +++ b/tsconfig.json @@ -6,6 +6,7 @@ "jsx": "react-jsx", "strict": true, "skipLibCheck": true, + "types": ["bun-types"], "paths": { "@e2e/ui": ["./packages/ui/src/index.ts"], "@e2e/utils": ["./packages/utils/src/index.ts"]