From d82533191c05cb6bb1b734a794582b9a0f49be02 Mon Sep 17 00:00:00 2001
From: QuantCode Agent <agent@quantcode.dev>
Date: Thu, 27 Aug 2026 22:47:01 +0000
Subject: [PATCH] fix: repair cross-package bugs so tests and typecheck pass

- ui/Button: forward aria-label to the button element for icon-only
  buttons so they have an accessible name (WCAG 2.2 SC 4.1.2)
- ui/DataTable: use functional setState for the sort-direction toggle
  to avoid a stale-closure toggle across rapid successive clicks
- utils/formatDate: use en-GB so day-first dates render without a
  leading zero on the day (1/03/2024), matching the expected format
- web/api: fix stale import of the renamed useThrottle export from
  @e2e/utils (now useDebounce)
- tsconfig: add bun-types to compilerOptions.types to resolve the
  bun:test module type errors in the test files

bun run test: 13 pass / 0 fail. tsc --noEmit: 0 errors.
---
 apps/web/src/lib/api.ts                       | 13 +++--------
 packages/ui/src/components/Button/Button.tsx  | 22 +++++++++++--------
 .../ui/src/components/DataTable/DataTable.tsx | 11 +---------
 packages/utils/src/format/date.ts             | 18 +++++++--------
 tsconfig.json                                 |  1 +
 5 files changed, 26 insertions(+), 39 deletions(-)

diff --git a/apps/web/src/lib/api.ts b/apps/web/src/lib/api.ts
index 2d4731b..4900d97 100644
--- a/apps/web/src/lib/api.ts
+++ b/apps/web/src/lib/api.ts
@@ -1,15 +1,8 @@
 /**
  * API client utilities for the web app.
- *
- * BUG: imports `useThrottle` from @e2e/utils, but that hook was renamed to
- * `useDebounce`. This causes a TypeScript error and a runtime crash.
- *
- * Fix: change the import to `useDebounce`.
  */
 
-// BUG: useThrottle no longer exists — was renamed to useDebounce
-import { useThrottle } from "@e2e/utils"
-import { formatDate, formatAUD } from "@e2e/utils"
+import { useDebounce, formatDate, formatAUD } from "@e2e/utils"
 
 export const BASE_URL = process.env.API_URL ?? "http://localhost:3000"
 
@@ -28,5 +21,5 @@ export async function fetchPosts() {
 // Re-export formatting utilities used throughout the app
 export { formatDate, formatAUD }
 
-// Re-export the debounce hook (currently broken import)
-export { useThrottle as useSearchDebounce }
+// Re-export the debounce hook under the app's public name
+export { useDebounce as useSearchDebounce }
diff --git a/packages/ui/src/components/Button/Button.tsx b/packages/ui/src/components/Button/Button.tsx
index af65c97..6bf4654 100644
--- a/packages/ui/src/components/Button/Button.tsx
+++ b/packages/ui/src/components/Button/Button.tsx
@@ -17,13 +17,10 @@ type Props = {
 /**
  * Button component.
  *
- * BUG: When `iconOnly` is true, the button renders without visible text.
- * An `aria-label` is required for screen reader accessibility (WCAG 2.1 SC 4.1.2),
- * but the component does not enforce or warn about its absence.
- *
- * The test in Button.test.tsx checks that an icon-only button has an accessible name.
- * Fix: throw/warn in development when `iconOnly && !aria-label`, or always render
- * the aria-label attribute when iconOnly is true.
+ * When `iconOnly` is true the button renders no visible text, so an `aria-label`
+ * is required to give it an accessible name (WCAG 2.2 SC 4.1.2). The label is
+ * forwarded to the underlying element; if it is missing on an icon-only button a
+ * generic fallback is applied and a development warning is emitted.
  */
 export function Button({
   children,
@@ -34,13 +31,20 @@ export function Button({
   onClick,
   "aria-label": ariaLabel,
 }: Props) {
+  const accessibleLabel = ariaLabel ?? (iconOnly ? "Button" : undefined)
+
+  if (process.env.NODE_ENV !== "production" && iconOnly && !ariaLabel) {
+    console.warn(
+      "Button: `iconOnly` buttons require an explicit `aria-label` for an accessible name (WCAG 2.2 SC 4.1.2). Falling back to a generic label.",
+    )
+  }
+
   return (
     <button
       className={`btn btn-${variant}`}
       disabled={disabled}
       onClick={onClick}
-      // BUG: aria-label is not applied when iconOnly is true and no ariaLabel is passed
-      // The component should enforce aria-label for icon-only buttons
+      aria-label={accessibleLabel}
     >
       {icon && <span className="btn-icon">{icon}</span>}
       {!iconOnly && children}
diff --git a/packages/ui/src/components/DataTable/DataTable.tsx b/packages/ui/src/components/DataTable/DataTable.tsx
index 429a6e3..e6ba613 100644
--- a/packages/ui/src/components/DataTable/DataTable.tsx
+++ b/packages/ui/src/components/DataTable/DataTable.tsx
@@ -15,23 +15,14 @@ type Props<T extends Record<string, unknown>> = {
 
 /**
  * DataTable with client-side sorting.
- *
- * BUG: The sort handler has a stale closure — it captures `sortDir` at the
- * time the handler is created, so toggling sort direction does not work
- * correctly after the first click. The second click always sorts in the same
- * direction as the first.
- *
- * Fix: use the functional form of setState — `setSortDir(prev => ...)` —
- * so the toggle always reads the current value.
  */
 export function DataTable<T extends Record<string, unknown>>({ data, columns }: Props<T>) {
   const [sortKey, setSortKey] = useState<keyof T | null>(null)
   const [sortDir, setSortDir] = useState<SortDir>("asc")
 
-  // BUG: stale closure — sortDir is captured at handler creation time
   const handleSort = (key: keyof T) => {
     if (sortKey === key) {
-      setSortDir(sortDir === "asc" ? "desc" : "asc") // BUG: reads stale sortDir
+      setSortDir((prev) => (prev === "asc" ? "desc" : "asc"))
     } else {
       setSortKey(key)
       setSortDir("asc")
diff --git a/packages/utils/src/format/date.ts b/packages/utils/src/format/date.ts
index 609e46c..e8de9a2 100644
--- a/packages/utils/src/format/date.ts
+++ b/packages/utils/src/format/date.ts
@@ -1,19 +1,17 @@
 /**
  * Date formatting utilities.
  *
- * BUG: formatDate passes `'en-AU'` as the locale but then uses a US-style
- * format string option (`month: 'numeric'` before `day: 'numeric'`), which
- * produces MM/DD/YYYY output instead of DD/MM/YYYY for Australian dates.
- *
- * Fix: use `dateStyle: 'short'` with `'en-AU'` locale, which correctly
- * produces DD/MM/YYYY, or explicitly set `day: 'numeric', month: 'numeric', year: 'numeric'`
- * and rely on the locale to order them correctly.
+ * Both helpers produce day-first output suitable for Australian audiences.
  */
+
+/** Formats a date as day-first D/MM/YYYY, e.g. 1/03/2024 and 15/06/2024. */
 export function formatDate(date: Date): string {
-  // BUG: explicit field order overrides locale ordering — produces M/D/YYYY not D/M/YYYY
-  return new Intl.DateTimeFormat("en-AU", {
-    month: "numeric",
+  // en-GB (not en-AU) is required here: the en-AU short-date pattern forces a
+  // 2-digit day alongside a 2-digit month, producing 01/03/2024. en-GB honours
+  // day: "numeric" independently, giving 1/03/2024 with a 4-digit year.
+  return new Intl.DateTimeFormat("en-GB", {
     day: "numeric",
+    month: "2-digit",
     year: "numeric",
   }).format(date)
 }
diff --git a/tsconfig.json b/tsconfig.json
index 167f910..8e00ae0 100644
--- a/tsconfig.json
+++ b/tsconfig.json
@@ -6,6 +6,7 @@
     "jsx": "react-jsx",
     "strict": true,
     "skipLibCheck": true,
+    "types": ["bun-types"],
     "paths": {
       "@e2e/ui": ["./packages/ui/src/index.ts"],
       "@e2e/utils": ["./packages/utils/src/index.ts"]