From 78a1494472958900ff6babe68f731ed40acc9b9c Mon Sep 17 00:00:00 2001
From: QuantCode Agent <agent@quantcode.dev>
Date: Thu, 27 Aug 2026 23:31:12 +0000
Subject: [PATCH] fix: reconcile renamed hook, icon-only button a11y, and AU
 date format

- apps/web: import useDebounce and re-export as useSearchDebounce (renamed hook was still imported under the old useThrottle name)
- ui/Button: add aria-label for icon-only buttons with dev-only warning [WCAG-4.1.2]
- utils/formatDate: emit standard Australian D/M/YYYY (unpadded day and month)
- tsconfig: add bun-types to compilerOptions.types to resolve bun:test module

Makes all 13 tests pass and clears all type errors. No test files or
dependencies changed.
---
 apps/web/src/lib/api.ts                      | 13 +++--------
 packages/ui/src/components/Button/Button.tsx | 24 ++++++++++++--------
 packages/utils/src/format/date.ts            | 23 +++++++++++--------
 tsconfig.json                                |  6 +++++
 4 files changed, 37 insertions(+), 29 deletions(-)

diff --git a/apps/web/src/lib/api.ts b/apps/web/src/lib/api.ts
index 2d4731b..4900d97 100644
--- a/apps/web/src/lib/api.ts
+++ b/apps/web/src/lib/api.ts
@@ -1,15 +1,8 @@
 /**
  * API client utilities for the web app.
- *
- * BUG: imports `useThrottle` from @e2e/utils, but that hook was renamed to
- * `useDebounce`. This causes a TypeScript error and a runtime crash.
- *
- * Fix: change the import to `useDebounce`.
  */
 
-// BUG: useThrottle no longer exists — was renamed to useDebounce
-import { useThrottle } from "@e2e/utils"
-import { formatDate, formatAUD } from "@e2e/utils"
+import { useDebounce, formatDate, formatAUD } from "@e2e/utils"
 
 export const BASE_URL = process.env.API_URL ?? "http://localhost:3000"
 
@@ -28,5 +21,5 @@ export async function fetchPosts() {
 // Re-export formatting utilities used throughout the app
 export { formatDate, formatAUD }
 
-// Re-export the debounce hook (currently broken import)
-export { useThrottle as useSearchDebounce }
+// Re-export the debounce hook under the app's public name
+export { useDebounce as useSearchDebounce }
diff --git a/packages/ui/src/components/Button/Button.tsx b/packages/ui/src/components/Button/Button.tsx
index af65c97..33cec30 100644
--- a/packages/ui/src/components/Button/Button.tsx
+++ b/packages/ui/src/components/Button/Button.tsx
@@ -17,13 +17,11 @@ type Props = {
 /**
  * Button component.
  *
- * BUG: When `iconOnly` is true, the button renders without visible text.
- * An `aria-label` is required for screen reader accessibility (WCAG 2.1 SC 4.1.2),
- * but the component does not enforce or warn about its absence.
- *
- * The test in Button.test.tsx checks that an icon-only button has an accessible name.
- * Fix: throw/warn in development when `iconOnly && !aria-label`, or always render
- * the aria-label attribute when iconOnly is true.
+ * Icon-only buttons render no visible text, so they must carry an `aria-label`
+ * to expose an accessible name (WCAG 2.2 SC 4.1.2 Name, Role, Value — Level A).
+ * Callers should always pass an explicit, meaningful `aria-label` when using
+ * `iconOnly`; a fallback is applied so the button is never left unnamed, and a
+ * development-only warning flags the omission.
  */
 export function Button({
   children,
@@ -34,13 +32,21 @@ export function Button({
   onClick,
   "aria-label": ariaLabel,
 }: Props) {
+  const resolvedAriaLabel =
+    ariaLabel ?? (iconOnly ? (typeof children === "string" ? children : "Button") : undefined)
+
+  if (process.env.NODE_ENV !== "production" && iconOnly && !ariaLabel) {
+    console.warn(
+      "Button: `iconOnly` buttons require an explicit `aria-label` for an accessible name (WCAG 2.2 SC 4.1.2).",
+    )
+  }
+
   return (
     <button
       className={`btn btn-${variant}`}
       disabled={disabled}
       onClick={onClick}
-      // BUG: aria-label is not applied when iconOnly is true and no ariaLabel is passed
-      // The component should enforce aria-label for icon-only buttons
+      aria-label={resolvedAriaLabel}
     >
       {icon && <span className="btn-icon">{icon}</span>}
       {!iconOnly && children}
diff --git a/packages/utils/src/format/date.ts b/packages/utils/src/format/date.ts
index 609e46c..59c4472 100644
--- a/packages/utils/src/format/date.ts
+++ b/packages/utils/src/format/date.ts
@@ -1,21 +1,24 @@
 /**
  * Date formatting utilities.
  *
- * BUG: formatDate passes `'en-AU'` as the locale but then uses a US-style
- * format string option (`month: 'numeric'` before `day: 'numeric'`), which
- * produces MM/DD/YYYY output instead of DD/MM/YYYY for Australian dates.
- *
- * Fix: use `dateStyle: 'short'` with `'en-AU'` locale, which correctly
- * produces DD/MM/YYYY, or explicitly set `day: 'numeric', month: 'numeric', year: 'numeric'`
- * and rely on the locale to order them correctly.
+ * Field order comes from the locale, not from the order of the option keys —
+ * ICU ignores option key order, so `en-AU` already yields D/M/Y. The subtlety is
+ * that ICU widens `numeric` to `2-digit` when day, month and year are requested
+ * together, so both fields come back zero-padded (`01/03/2024`). `formatToParts`
+ * is used to unpad the day and the month, leaving the year four digits, which
+ * gives the standard Australian D/M/YYYY: `1/3/2024`, `15/6/2024`.
  */
 export function formatDate(date: Date): string {
-  // BUG: explicit field order overrides locale ordering — produces M/D/YYYY not D/M/YYYY
   return new Intl.DateTimeFormat("en-AU", {
-    month: "numeric",
     day: "numeric",
+    month: "numeric",
     year: "numeric",
-  }).format(date)
+  })
+    .formatToParts(date)
+    .map((part) =>
+      part.type === "day" || part.type === "month" ? String(Number(part.value)) : part.value,
+    )
+    .join("")
 }
 
 export function formatDateTime(date: Date): string {
diff --git a/tsconfig.json b/tsconfig.json
index 167f910..748cdc0 100644
--- a/tsconfig.json
+++ b/tsconfig.json
@@ -6,6 +6,12 @@
     "jsx": "react-jsx",
     "strict": true,
     "skipLibCheck": true,
+    // Bun's `bun:test` module is declared by bun-types (an installed devDependency).
+    // Naming `types` explicitly turns OFF automatic inclusion of every other
+    // node_modules/@types/* package. That is harmless here: @types/react is pulled
+    // in via the explicit `import ... from "react"` in each file rather than relying
+    // on global auto-inclusion, so React prop type-checking is unaffected.
+    "types": ["bun-types"],
     "paths": {
       "@e2e/ui": ["./packages/ui/src/index.ts"],
       "@e2e/utils": ["./packages/utils/src/index.ts"]