Expo next storage support config plugins

[Stevemoretz]

Proposal

Hello, this 6mb limit always has been a pain in the arm, so with the new EAS build system it's now possible to lift it. (According to Brent Vatne himself the creator of expo : https://expo.canny.io/feature-requests/p/ability-to-increase-async-storage-size).

It would be great to have a config plugin : https://docs.expo.dev/guides/config-plugins/
which can add support of next storage, so that 6mb limit would get lifted.

Alternatives

The alternative of course can be not using the next storage, and the old one but be able to configure the size, that is possible if you search this text in the link I provided in the next section Some plugins can be customized by passing an array, where the second argument is the options:

Implementation Details

I don't know much but I have seen other libraries do the same for example rn-firebase has done it, and many more.
But the full tutorial on that seems to be here : https://docs.expo.dev/guides/config-plugins/

Additional Context

No response

[wodin]

If it's just a matter of adding the following to gradle.properties a config plugin will be very simple:

AsyncStorage_db_size_in_MB=10

Or do you also need to update build.gradle?

[Stevemoretz]

If it's just a matter of adding the following to gradle.properties a config plugin will be very simple:

AsyncStorage_db_size_in_MB=10

Or do you also need to update build.gradle?

Hello thank you for the reply, for my needs if the next storage doesn't have this limitation : #640 (comment)

There's also an Android OS limitation on how big the data can be while reading from the DB (CursorWindow limitation) and that's around 2MB.

I would need that one, otherwise just having AsyncStorage_db_size_in_MB=10 option would be more than enough.

[wodin]

hmmm... if I understand you correctly, you need to be able to retrieve more than 2MB of data when reading a single key? It sounds like this "Android OS limitation" is not something that you could increase. Only the total database size.

If you don't mind, what kind of data is this?

Also, have you considered using something else to store the data? e.g. https://github.com/mrousavy/react-native-mmkv/
But I don't know if MMKV has size limitations. I don't think either AsyncStorage or MMKV are really intended for storing big values in a key.

[Stevemoretz]

hmmm... if I understand you correctly, you need to be able to retrieve more than 2MB of data when reading a single key? It sounds like this "Android OS limitation" is not something that you could increase. Only the total database size.

If you don't mind, what kind of data is this?

Also, have you considered using something else to store the data? e.g. https://github.com/mrousavy/react-native-mmkv/ But I don't know if MMKV has size limitations. I don't think either AsyncStorage or MMKV are really intended for storing big values in a key.

Hello Micheal, the exact use case of mine is with using redux-persistence it just stores all the data under one single key, I'm caching a few jsons coming back from the server, these jsons could grow over the time and that could cause the 2mb overflow problem.

I had considered the expo file system, haven't tried it yet though, never had heard of mmkv! Sounds amazing I'll open an issue there to ask see if they're also using the database or not!

Thank you again!

[Stevemoretz]

I got a response back from mmkv sounds like it's not useful for big objects as well, but that's okay, so forgetting about the 2mb limit.

How about a Plugin for changing the 6mb limit? That sounds like a good idea yet I couldn't make it myself since expo has support only for vscode for developing and validating plugins, but I have Intellij Idea, I couldn't figure out how to use the mod I know a mod exists exactly for changing gradle properties tried to use it but it's not really obvious what to do there!

The hook is : withGradleProperties
But couldn't find a single example

[github-actions]

This issue has been marked as stale due to inactivity. Please respond or otherwise resolve the issue within 7 days or it will be closed.

[wodin]

How about a Plugin for changing the 6mb limit? That sounds like a good idea yet I couldn't make it myself since expo has support only for vscode for developing and validating plugins, but I have Intellij Idea

You don't need VS Code. I don't use it. I've written a few simple plugins and I just test them by running expo prebuild and checking the results.

I couldn't figure out how to use the mod I know a mod exists exactly for changing gradle properties tried to use it but it's not really obvious what to do there!

The hook is : withGradleProperties But couldn't find a single example

Maybe these will help:

• https://github.com/expo/config-plugins/blob/9b22a71343d74d71353d8c6535e7d04da2fc4473/packages/react-native-webrtc/src/withDesugaring.ts#L9
• https://github.com/expo/expo/blob/a9c4f103b23f4ed907a362c31c12eae14382d95c/apps/native-component-list/app.config.js#L32

[ansh]

Here is a Stackoverflow issue that basically creates a config plugin for increasing the size

I also just wrote one with setting up Next Storage:

// withNextStorage.ts
// Next Storage Implementation for react-native-async-storage https://react-native-async-storage.github.io/async-storage/docs/advanced/next/
import {
  ConfigPlugin,
  createRunOncePlugin,
  withGradleProperties,
  withProjectBuildGradle,
} from "@expo/config-plugins";
import { MergeResults, mergeContents } from "@expo/config-plugins/build/utils/generateCode";

const pkg = require("@react-native-async-storage/async-storage/package.json");

const addKotlinGradlePlugin = (src: string): MergeResults => {
  return mergeContents({
    tag: "react-native-async-storage withNextStorage config plugin",
    src,
    newSrc: `classpath "org.jetbrains.kotlin:kotlin-gradle-plugin:$kotlinVersion"`,
    anchor: /dependencies(?:\s+)?\{/,
    offset: 1,
    comment: "//",
  });
};

const withDangerousMod: ConfigPlugin = (config) => {
  return withProjectBuildGradle(config, (config) => {
    if (config.modResults.language === "groovy") {
      config.modResults.contents = addKotlinGradlePlugin(config.modResults.contents).contents;
    } else {
      throw new Error(
        "Cannot add Snapkit maven gradle because the project build.gradle is not groovy"
      );
    }
    return config;
  });
};

const withGradlePropertyMod: ConfigPlugin = (config) => {
  return withGradleProperties(config, (config) => {
    config.modResults.push({
      type: "property",
      key: "AsyncStorage_useNextStorage",
      value: "true",
    });
    return config;
  });
};

const withNextStorage: ConfigPlugin = (config) => {
  return withGradlePropertyMod(withDangerousMod(config));
};

export default createRunOncePlugin(withNextStorage, pkg.name, pkg.version);

I can publish this as a config plugin package. Let me know @tido64

[tido64]

I can publish this as a config plugin package. Let me know @tido64

@ansh: Can this be part of the AsyncStorage package? I think it would be nice if they came together. It would also make updating it a lot easier. What do you think, @krizzu?