Skip to content

Preserve non-OLM component image defaults when bundle CSV values are missing #1262

Description

@coderabbitai

Summary

The non-OLM installer can replace configured component image defaults with empty values when USE_BUNDLE_IMG=true and the bundle CSV does not define an extracted environment variable.

Required changes

Update hack/non-olm-install/install-gitops-operator.sh so extract_component_images_from_bundle_image preserves each configured component image value when the bundle CSV has no non-empty value for that environment variable.

Apply the behavior consistently to all component image environment variables extracted from the bundle CSV. Do not limit the change to GITOPS_CONSOLE_PLUGIN_IMAGE_PF5.

Rationale

The installer must keep user-provided or script-provided defaults when an older or incomplete bundle CSV does not provide a component image override. This prevents generated deployment overrides from containing empty image values.

Affected area

  • hack/non-olm-install/install-gitops-operator.sh
  • extract_component_images_from_bundle_image

Acceptance criteria

  • When USE_BUNDLE_IMG=true and the bundle CSV contains a non-empty component image environment variable, the installer uses the bundle value.
  • When the bundle CSV omits a component image environment variable or gives it an empty value, the installer preserves the configured value.
  • The behavior applies consistently to all component image environment variables extracted by extract_component_images_from_bundle_image.
  • Add or update tests if the repository has practical coverage for this shell-script behavior.

Backlinks

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions