From cc96d360496abec71c471d53cff27a14ea41aacf Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Oliver=20Gond=C5=BEa?= Date: Fri, 14 Aug 2026 16:22:36 +0200 Subject: [PATCH] fix(e2e): Do not print secret value from secret.Fixture.HaveNonEmptyKeyValue MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit It confuses openshift-ci secrets redaction Signed-off-by: Oliver Gondža --- test/openshift/e2e/ginkgo/fixture/secret/fixture.go | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/test/openshift/e2e/ginkgo/fixture/secret/fixture.go b/test/openshift/e2e/ginkgo/fixture/secret/fixture.go index 78b8cd5a4a3..109c0c7755e 100644 --- a/test/openshift/e2e/ginkgo/fixture/secret/fixture.go +++ b/test/openshift/e2e/ginkgo/fixture/secret/fixture.go @@ -61,9 +61,10 @@ func HaveNonEmptyKeyValue(key string) matcher.GomegaMatcher { return false } - GinkgoWriter.Println("HaveNonEmptyKeyValue - Key:", key, " Have:", string(a)) - - return len(a) > 0 + // Printing string that looks like secret causes openshift-ci to redact the entire log file, preventing investigating failures in any other tests. + empty := len(a) == 0 + GinkgoWriter.Println("HaveNonEmptyKeyValue - Key:", key, " empty:", empty) + return !empty }) }