Skip to content

Commit 2089a5b

Browse files
committed
Assign check result of flags to a variable for understandability
1 parent d6b5125 commit 2089a5b

1 file changed

Lines changed: 4 additions & 3 deletions

File tree

ext/fiddle/pointer.c

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -137,11 +137,12 @@ fiddle_ptr_memory_view_available_p(VALUE obj)
137137
static bool
138138
fiddle_ptr_get_memory_view(VALUE obj, rb_memory_view_t *view, int flags)
139139
{
140-
bool writable_requested = flags & RUBY_MEMORY_VIEW_WRITABLE;
141-
if (flags != RUBY_MEMORY_VIEW_SIMPLE && flags != RUBY_MEMORY_VIEW_WRITABLE) return false;
140+
bool flags_supported = flags == RUBY_MEMORY_VIEW_SIMPLE || flags == RUBY_MEMORY_VIEW_WRITABLE;
141+
bool read_only = !(flags & RUBY_MEMORY_VIEW_WRITABLE);
142+
if (!flags_supported) return false;
142143

143144
struct ptr_data *data = fiddle_ptr_check_memory_view(obj);
144-
rb_memory_view_init_as_byte_array(view, obj, data->ptr, data->size, !writable_requested);
145+
rb_memory_view_init_as_byte_array(view, obj, data->ptr, data->size, read_only);
145146

146147
return true;
147148
}

0 commit comments

Comments
 (0)