unnecessary_unwrap recommends that foo.is_some() in a conditional followed by foo.unwrap() should be replaced by an if let. That is usually good advice, however, if the is_some is just part of the conditional, then the only way to use if let is with nested ifs.
E.g.,
if some_condition && foo.is_some() {
let foo = foo.unwrap();
...
}
can only be rewritten as
if some_condition {
if let Some(foo) = foo {
...
}
}
which is not much of an improvement (and arguably no improvement at all). (In this case, using match might be better, but in some more complex examples it is not possible).
I would much prefer is unnecessary_unwrap only triggered when it was possible to rewrite exactly using a single if let or match.
unnecessary_unwraprecommends thatfoo.is_some()in a conditional followed byfoo.unwrap()should be replaced by anif let. That is usually good advice, however, if theis_someis just part of the conditional, then the only way to useif letis with nestedifs.E.g.,
can only be rewritten as
which is not much of an improvement (and arguably no improvement at all). (In this case, using
matchmight be better, but in some more complex examples it is not possible).I would much prefer is
unnecessary_unwraponly triggered when it was possible to rewrite exactly using a singleif letormatch.