chore: updates from devScripts

Author: svc-cli-bot

.eslintignore

@@ -0,0 +1 @@
+export { default } from 'eslint-config-salesforce-typescript';

.eslintrc.cjs

@@ -143,9 +143,15 @@
     "@oclif/plugin-command-snapshot": "^5.3.34",
     "@oclif/test": "^4.1.21",
     "@salesforce/cli-plugins-testkit": "^5.3.64",
-    "@salesforce/dev-scripts": "^11.0.4",
+    "@salesforce/dev-scripts": "^13.0.2",
     "@salesforce/plugin-command-reference": "^3.1.131",
     "@salesforce/types": "^1.8.0",
+    "@types/chai": "^4.3.17",
+    "@types/mocha": "^10.0.10",
+    "@types/node": "^18",
+    "@types/sinon": "^10.0.20",
+    "eslint": "^10.4.0",
+    "eslint-config-salesforce-typescript": "^6.0.0",
     "eslint-plugin-sf-plugin": "^1.20.33",
     "oclif": "^4.23.29",
     "ts-node": "^10.9.2",
@@ -193,6 +199,7 @@
         "src/**/*.ts",
         "test/**/*.ts",
         "messages/**",
+        "**/eslint.config.*",
         "**/.eslint*",
         "**/tsconfig.json"
       ],

eslint.config.mjs

@@ -141,7 +141,7 @@ export class Batcher {
           const newBatch = job.createBatch();
 
           return new Promise((resolve, reject) => {
-            // eslint-disable-next-line @typescript-eslint/no-floating-promises
+             
             newBatch.on('error', (err: Error) => {
               // reword no external id error message to direct it to org user rather than api user
               if (err.message.startsWith('External ID was blank')) {
@@ -175,7 +175,7 @@ export class Batcher {
             );
 
             if (!wait) {
-              // eslint-disable-next-line @typescript-eslint/no-floating-promises
+               
               newBatch.on(
                 'queue',
                 // we're using an async method on an event listener which doesn't fit the .on method parameter types

package.json

@@ -72,7 +72,7 @@ export default class Delete extends SfCommand<SaveResult> {
         ? flags['target-org'].getConnection(flags['api-version']).tooling
         : flags['target-org'].getConnection(flags['api-version']);
       // "where flag" will be defined if sobjectId is not
-      const sObjectId = flags['record-id'] ?? ((await query(conn, flags.sobject, flags.where as string)).Id as string);
+      const sObjectId = flags['record-id'] ?? ((await query(conn, flags.sobject, flags.where as string)).Id);
       const result = await conn.sobject(flags.sobject).destroy(sObjectId);
       if (result.success) {
         this.log(messages.getMessage('deleteSuccess', [sObjectId]));

src/batcher.ts

@@ -70,10 +70,10 @@ export default class Get extends SfCommand<Record> {
       ? flags['target-org'].getConnection(flags['api-version']).tooling
       : flags['target-org'].getConnection(flags['api-version']);
     try {
-      const sObjectId = flags['record-id'] ?? ((await query(conn, flags.sobject, flags.where as string)).Id as string);
+      const sObjectId = flags['record-id'] ?? ((await query(conn, flags.sobject, flags.where as string)).Id);
       const result = await conn.sobject(flags.sobject).retrieve(sObjectId);
       if (!this.jsonEnabled()) {
-        logNestedObject(new Ux({ jsonEnabled: this.jsonEnabled() }), result as never);
+        logNestedObject(new Ux({ jsonEnabled: this.jsonEnabled() }), result);
       }
       this.spinner.stop();
       return toAnyJson(result) as Record;

src/commands/data/delete/record.ts

@@ -258,7 +258,7 @@ const recursivelyFindColumns = (data: JsonArray): Field[] => {
       }
       columns.push(field);
     } else {
-      columns.push({ fieldType: FieldType.field, name } as Field);
+      columns.push({ fieldType: FieldType.field, name });
     }
   }
   return columns;

src/commands/data/get/record.ts

@@ -86,7 +86,7 @@ export default class Update extends SfCommand<SaveResult> {
       ? flags['target-org'].getConnection(flags['api-version']).tooling
       : flags['target-org'].getConnection(flags['api-version']);
     // oclif isn't smart of enough to know that if record-id is not set, then where is set
-    const sObjectId = flags['record-id'] ?? ((await query(conn, flags.sobject, flags.where as string)).Id as string);
+    const sObjectId = flags['record-id'] ?? ((await query(conn, flags.sobject, flags.where as string)).Id);
     try {
       const updateObject = { ...stringToDictionary(flags.values), Id: sObjectId };
       const result = await conn

src/commands/data/query.ts

@@ -84,10 +84,10 @@ function prepData(
     const row: Record<string, unknown> = {};
     fields.forEach((field) => {
       if (field in record) {
-        row[field] = (record[field] as string) ?? '';
+        row[field] = (record[field]) ?? '';
       } else {
         // if not, try to find it query
-        row[field] = (get(record, field) as string) ?? '';
+        row[field] = (get(record, field)) ?? '';
       }
     });
     return row;