From 7914b61e858424716030b4d4a7050b01e328cc81 Mon Sep 17 00:00:00 2001 From: Joao-Dionisio Date: Fri, 20 Nov 2026 11:56:12 +0000 Subject: [PATCH 1/2] Post a reviewer checklist comment on new PRs --- .github/review_checklist.md | 28 ++++++++++++++++++++++++++ .github/workflows/review-checklist.yml | 21 +++++++++++++++++++ 2 files changed, 49 insertions(+) create mode 100644 .github/review_checklist.md create mode 100644 .github/workflows/review-checklist.yml diff --git a/.github/review_checklist.md b/.github/review_checklist.md new file mode 100644 index 000000000..4d1bb8509 --- /dev/null +++ b/.github/review_checklist.md @@ -0,0 +1,28 @@ +## Reviewer checklist + +Ticked by the reviewer, nothing to do here for the author. + +### Code + +- [ ] The code change is correct. +- [ ] New methods are named after their SCIP function (e.g. `SCIPgetVars()` becomes `getVars()`) and are placed next to related methods, **or** no new methods were added. +- [ ] The added/modified behavior is identical to SCIP's, **or** deviations were justified. +- [ ] If methods were added to `BaseModel`, they work in exact mode. +- [ ] If methods were added to `Model`, the exact counterpart was added to `ExactModel` with `Fraction` i/o, **or** the method has no meaning in exact mode or SCIP has no exact equivalent. + +### Documentation + +- [ ] The code is documented (numpydoc docstrings with parameter and return types). +- [ ] `CHANGELOG.md` is updated, including API changes. +- [ ] The type stubs (`scip.pyi`) are updated for new or changed methods. +- [ ] Docs and examples are updated, **or** a new docs section was added for new features (e.g. plugin types), **or** no user-facing behavior changed. + +### Testing + +- [ ] New code is covered by tests, including error paths. +- [ ] If this touches expressions, model building or callbacks, `/benchmark` was run and shows no regression. + `/benchmark [filter] [timelimit=seconds]`, e.g. `/benchmark expr or plugin`. Locally: `pytest benchmarks`. + +### Does this PR introduce an API change? ⚠️ + +- [ ] No, **or** it is backwards compatible, **or** the old behavior goes through a deprecation warning first. diff --git a/.github/workflows/review-checklist.yml b/.github/workflows/review-checklist.yml new file mode 100644 index 000000000..52034931f --- /dev/null +++ b/.github/workflows/review-checklist.yml @@ -0,0 +1,21 @@ +name: Review checklist + +on: + pull_request_target: + types: [opened] + +permissions: + contents: read + pull-requests: write + +jobs: + comment: + runs-on: ubuntu-latest + steps: + - uses: actions/checkout@v4 + with: + sparse-checkout: .github/review_checklist.md + sparse-checkout-cone-mode: false + - run: gh pr comment "${{ github.event.pull_request.number }}" --repo "${{ github.repository }}" --body-file .github/review_checklist.md + env: + GH_TOKEN: ${{ github.token }} From 2746cd5123cf372de925d01f7da82a60c4321e14 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Jo=C3=A3o=20Dion=C3=ADsio?= <57299939+Joao-Dionisio@users.noreply.github.com> Date: Fri, 20 Nov 2026 14:09:58 +0000 Subject: [PATCH 2/2] Update review_checklist.md --- .github/review_checklist.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/review_checklist.md b/.github/review_checklist.md index 4d1bb8509..3d5f96adb 100644 --- a/.github/review_checklist.md +++ b/.github/review_checklist.md @@ -1,6 +1,6 @@ ## Reviewer checklist -Ticked by the reviewer, nothing to do here for the author. +To be checked by the reviewer. ### Code