After updating ComfyUI using Manager's Update All, MiniMax H3 generation fails when using the UtilsCollection MiniMax H3 patch/cache functionality.
The error is:
TypeError: FinalLayer.forward() missing 3 required positional arguments: 'sigma', 'sample_sigmas', and 'shifts'
What appears to be happening
ComfyUI's MiniMax H3 implementation has changed the signature of FinalLayer.forward() to require three additional arguments:
sigma
sample_sigmas
shifts
UtilsCollection's minimax_h3_block_patch_forward() appears to still call self.final_layer() using the previous argument list.
The relevant part of the traceback is:
File ".../ComfyUI/comfy/ldm/minimax/model.py", line 566, in forward
out = comfy.patcher_extension.WrapperExecutor.new_class_executor(
File ".../ComfyUI/custom_nodes/ComfyUI-UtilsCollection/patcher_helpers.py", line 1275, in minimax_h3_block_patch_forward
video_result, audio_result = self.final_layer(
File ".../torch/nn/modules/module.py", line 1789, in _call_impl
return forward_call(*args, **kwargs)
TypeError: FinalLayer.forward() missing 3 required positional arguments:
'sigma', 'sample_sigmas', and 'shifts'
Expected behavior
MiniMax H3 generation using the UtilsCollection H3 patch/cache should continue to work with current ComfyUI.
Actual behavior
Sampling begins, but generation immediately fails when minimax_h3_block_patch_forward() reaches self.final_layer().
Likely compatibility issue
Current ComfyUI appears to call the final layer with additional H3 sampling information, while the UtilsCollection patched forward path still uses the older call signature.
The UtilsCollection call will presumably need to be updated to pass the equivalent values now used by ComfyUI core, including the current sigma, sample sigmas, and video/audio shifts.
Reproduction
- Update ComfyUI and custom nodes using ComfyUI Manager's Update All.
- Load a MiniMax H3 workflow using the UtilsCollection MiniMax H3 cache/patch functionality.
- Start generation.
- Sampling fails with:
FinalLayer.forward() missing 3 required positional arguments:
'sigma', 'sample_sigmas', and 'shifts'
Environment
- Linux
- Python 3.12
- Current/recent ComfyUI
- Current/recent ComfyUI-UtilsCollection
- MiniMax H3 workflow
- UtilsCollection H3 cache/patch enabled
After updating ComfyUI using Manager's Update All, MiniMax H3 generation fails when using the UtilsCollection MiniMax H3 patch/cache functionality.
The error is:
What appears to be happening
ComfyUI's MiniMax H3 implementation has changed the signature of
FinalLayer.forward()to require three additional arguments:sigmasample_sigmasshiftsUtilsCollection's
minimax_h3_block_patch_forward()appears to still callself.final_layer()using the previous argument list.The relevant part of the traceback is:
Expected behavior
MiniMax H3 generation using the UtilsCollection H3 patch/cache should continue to work with current ComfyUI.
Actual behavior
Sampling begins, but generation immediately fails when
minimax_h3_block_patch_forward()reachesself.final_layer().Likely compatibility issue
Current ComfyUI appears to call the final layer with additional H3 sampling information, while the UtilsCollection patched forward path still uses the older call signature.
The UtilsCollection call will presumably need to be updated to pass the equivalent values now used by ComfyUI core, including the current sigma, sample sigmas, and video/audio shifts.
Reproduction
Environment