fix(search): handle replies missing during Gmail verification

Author: waleedlatif1

apps/sim/lib/sim-search/live/google.ts

@@ -435,17 +435,17 @@ export async function readGmail(
   for (const candidate of latest) {
     options.signal.throwIfAborted()
     const candidateId = string(candidate.id)
-    if (
-      !(await options.verify({
-        id: candidateId,
-        accessMetadata: { id: candidateId, labelIds: candidate.labelIds },
-      }))
-    ) {
-      warnings.add('messages outside the source search scope were omitted')
-      continue
-    }
     let row: Record<string, unknown>
     try {
+      if (
+        !(await options.verify({
+          id: candidateId,
+          accessMetadata: { id: candidateId, labelIds: candidate.labelIds },
+        }))
+      ) {
+        warnings.add('messages outside the source search scope were omitted')
+        continue
+      }
       row = object(
         await client.json(`/gmail/v1/users/me/messages/${segment(candidateId)}`, {
           query: { format: 'full' },

apps/sim/scripts/test-search-google-content-e2e.ts

@@ -79,7 +79,7 @@ const mailbox: GmailMessage[] = Array.from({ length: 12 }, (_, index) => ({
     body: { data: Buffer.from(`Synthetic evidence ${index}.`).toString('base64url') },
   },
 }))
-const messageFailures = new Map<string, number>()
+const messageFailures = new Map<string, { status: number; format: string }>()
 const mediaStarted = createDeferred<void>()
 const mediaClosed = createDeferred<void>()
 const server = http.createServer((request, response) => {
@@ -93,13 +93,12 @@ const server = http.createServer((request, response) => {
     const row = mailbox.find((message) => message.id === id)
     const isThread = url.pathname.startsWith('/gmail/v1/users/me/threads/')
     const isAttachment = url.pathname.includes('/attachments/')
-    const failure =
-      !isThread && url.searchParams.get('format') === 'full' ? messageFailures.get(id) : undefined
-    if (failure) {
-      requests.push({ id, resource: 'message', status: failure })
+    const failure = !isThread ? messageFailures.get(id) : undefined
+    if (failure && url.searchParams.get('format') === failure.format) {
+      requests.push({ id, resource: 'message', status: failure.status })
       response
-        .writeHead(failure, { 'Content-Type': 'application/json' })
-        .end(JSON.stringify({ error: { code: failure } }))
+        .writeHead(failure.status, { 'Content-Type': 'application/json' })
+        .end(JSON.stringify({ error: { code: failure.status } }))
       return
     }
     const threadMessages = isThread ? mailbox.filter((message) => message.threadId === id) : []
@@ -303,68 +302,71 @@ try {
     { name: 'rate limit', failedId: 'reply', status: 429, expectedStatus: 'rate_limited' },
     { name: 'server failure', failedId: 'reply', status: 500, expectedStatus: 'unavailable' },
   ]) {
-    await check(
-      `Gmail conversation handles ${name} without hiding unrelated failures`,
-      async () => {
-        const before = mailbox.length
-        mailbox.push(
-          ...['anchor', 'retained', 'reply'].map((id, index) => ({
-            id,
-            threadId: 'failure-conversation',
-            labelIds: ['INBOX'],
-            internalDate: String(Date.UTC(2026, 0, 1, 12, index)),
-            payload: {
-              mimeType: 'text/plain',
-              body: { data: Buffer.from(`Synthetic ${id} evidence.`).toString('base64url') },
-            },
-          }))
-        )
-        if (failedId) messageFailures.set(failedId, status)
-        try {
-          const signal = AbortSignal.timeout(5000)
-          const api = createNativeClient({ origin, accessToken: TOKEN, signal })
-          const policy = {
-            ...defaultLiveSearchPolicy('gmail'),
-            mode: 'selected' as const,
-            included: ['INBOX'],
-          }
-          const verify = createPolicyVerifier('gmail', policy, api, origin)
-          assert.ok(await verify({ id: 'anchor' }))
-          const reading = readGmail(api, 'anchor', {
-            policy,
-            signal,
-            verify: (reference) => verify(reference, reference.accessMetadata),
-          })
-          if (expectedStatus) {
-            await assert.rejects(
-              reading,
-              (error: unknown) =>
-                error instanceof NativeSearchError && error.status === expectedStatus
+    for (const format of failedId === 'reply' ? ['metadata', 'full'] : ['full']) {
+      await check(
+        `Gmail conversation handles ${name} during ${format} reads without hiding unrelated failures`,
+        async () => {
+          const before = mailbox.length
+          mailbox.push(
+            ...['anchor', 'retained', 'reply'].map((id, index) => ({
+              id,
+              threadId: 'failure-conversation',
+              labelIds: ['INBOX'],
+              internalDate: String(Date.UTC(2026, 0, 1, 12, index)),
+              payload: {
+                mimeType: 'text/plain',
+                body: { data: Buffer.from(`Synthetic ${id} evidence.`).toString('base64url') },
+              },
+            }))
+          )
+          if (failedId) messageFailures.set(failedId, { status, format })
+          try {
+            const signal = AbortSignal.timeout(5000)
+            const api = createNativeClient({ origin, accessToken: TOKEN, signal })
+            const policy = {
+              ...defaultLiveSearchPolicy('gmail'),
+              mode: 'selected' as const,
+              included: ['INBOX'],
+            }
+            const verify = createPolicyVerifier('gmail', policy, api, origin)
+            assert.ok(await verify({ id: 'anchor' }))
+            const reading = readGmail(api, 'anchor', {
+              policy,
+              signal,
+              verify: (reference) =>
+                verify(reference, format === 'full' ? reference.accessMetadata : undefined),
+            })
+            if (expectedStatus) {
+              await assert.rejects(
+                reading,
+                (error: unknown) =>
+                  error instanceof NativeSearchError && error.status === expectedStatus
+              )
+              return
+            }
+            const document = await reading
+            assert.equal(document.id, 'anchor')
+            assert.ok(document.content.includes('Synthetic anchor evidence.'))
+            assert.ok(document.content.includes('Synthetic retained evidence.'))
+            assert.equal(document.content.includes('Synthetic reply evidence.'), status === 200)
+            assert.equal(document.content.includes('Coverage incomplete:'), status === 404)
+            assert.deepEqual(
+              document.accessDependencies,
+              status === 404 ? [{ id: 'retained' }] : [{ id: 'retained' }, { id: 'reply' }]
             )
-            return
+            const current = createPolicyVerifier('gmail', policy, api, origin, undefined, {
+              fresh: true,
+            })
+            assert.ok(await current({ id: document.id }))
+            for (const dependency of document.accessDependencies ?? [])
+              assert.ok(await current(dependency))
+          } finally {
+            mailbox.splice(before)
+            messageFailures.clear()
           }
-          const document = await reading
-          assert.equal(document.id, 'anchor')
-          assert.ok(document.content.includes('Synthetic anchor evidence.'))
-          assert.ok(document.content.includes('Synthetic retained evidence.'))
-          assert.equal(document.content.includes('Synthetic reply evidence.'), status === 200)
-          assert.equal(document.content.includes('Coverage incomplete:'), status === 404)
-          assert.deepEqual(
-            document.accessDependencies,
-            status === 404 ? [{ id: 'retained' }] : [{ id: 'retained' }, { id: 'reply' }]
-          )
-          const current = createPolicyVerifier('gmail', policy, api, origin, undefined, {
-            fresh: true,
-          })
-          assert.ok(await current({ id: document.id }))
-          for (const dependency of document.accessDependencies ?? [])
-            assert.ok(await current(dependency))
-        } finally {
-          mailbox.splice(before)
-          messageFailures.clear()
         }
-      }
-    )
+      )
+    }
   }
   await check(
     'Gmail conversation and fresh selected-label checks fit one native request budget',