fix(knowledge): resolve the v1 reader before updating and drop unscoped update totals

Author: waleedlatif1

apps/sim/app/api/v1/knowledge/[id]/route.ts

@@ -87,6 +87,8 @@ export const PUT = withRouteHandler(async (request: NextRequest, context: Knowle
     )
     if (result instanceof NextResponse) return result
 
+    /** Resolved before the write, so a reader that cannot be resolved changes nothing. */
+    const access = await resolveV1KnowledgeReadAccess(userId, rateLimit, workspaceId)
     const outcome = await performUpdateKnowledgeBase({
       knowledgeBaseId: id,
       workspaceId,
@@ -103,10 +105,7 @@ export const PUT = withRouteHandler(async (request: NextRequest, context: Knowle
       )
     }
 
-    const knowledgeBase = await attachKnowledgeBaseConnectors(
-      outcome.knowledgeBase,
-      await resolveV1KnowledgeReadAccess(userId, rateLimit, workspaceId)
-    )
+    const knowledgeBase = await attachKnowledgeBaseConnectors(outcome.knowledgeBase, access)
     return NextResponse.json({
       success: true,
       data: {

apps/sim/app/workspace/[workspaceId]/lib/prefetch.test.ts

@@ -208,7 +208,7 @@ describe('workspace list prefetches', () => {
       await prefetchKnowledgeBases(client, WORKSPACE_ID, USER_ID)
 
       expect(mockListInternalKnowledgeBases).not.toHaveBeenCalled()
-      expect(client.getQueryData(knowledgeKeys.list(WORKSPACE_ID, 'active'))).toBeUndefined()
+      expect(client.getQueryData(knowledgeKeys.countedList(WORKSPACE_ID, 'active'))).toBeUndefined()
     })
   })
 

apps/sim/lib/knowledge/orchestration/knowledge-bases.ts

@@ -4,6 +4,7 @@ import { PlatformEvents } from '@/lib/core/telemetry'
 import { generateRequestId } from '@/lib/core/utils/request'
 import { DEFAULT_CHUNKING_CONFIG } from '@/lib/knowledge/constants'
 import { getConfiguredKbEmbedding } from '@/lib/knowledge/embeddings'
+import type { ActiveKnowledgeBaseReference } from '@/lib/knowledge/knowledge-base-reference'
 import {
   auditActorFields,
   classifyKnowledgeFailure,
@@ -25,6 +26,11 @@ export type PerformKnowledgeBaseResult = KnowledgeOrchestrationResult<{
   knowledgeBase: KnowledgeBaseWithCounts
 }>
 
+/** The updated base without document totals, which a surface reads as its caller. */
+export type PerformUpdateKnowledgeBaseResult = KnowledgeOrchestrationResult<{
+  knowledgeBase: ActiveKnowledgeBaseReference
+}>
+
 export interface PerformCreateKnowledgeBaseParams extends KnowledgeOperationContext {
   workspaceId: string
   name: string
@@ -143,7 +149,7 @@ export interface PerformUpdateKnowledgeBaseParams extends KnowledgeOperationCont
  */
 export async function performUpdateKnowledgeBase(
   params: PerformUpdateKnowledgeBaseParams
-): Promise<PerformKnowledgeBaseResult> {
+): Promise<PerformUpdateKnowledgeBaseResult> {
   const { knowledgeBaseId, updates, request, source } = params
   const requestId = params.requestId ?? generateRequestId()
 
@@ -154,7 +160,7 @@ export async function performUpdateKnowledgeBase(
     return fail('No updates specified', 'validation')
   }
 
-  let updated: KnowledgeBaseWithCounts
+  let updated: ActiveKnowledgeBaseReference
   try {
     updated = await updateKnowledgeBase(knowledgeBaseId, updates, requestId, {
       actorUserId: params.userId,

apps/sim/lib/knowledge/service.ts

@@ -544,7 +544,8 @@ export async function createAuthorizedKnowledgeBase(
 }
 
 /**
- * Update a knowledge base
+ * Updates a knowledge base and returns it without document totals; a surface that shows them
+ * reads them through {@link attachKnowledgeBaseConnectors} as its caller.
  */
 export async function updateKnowledgeBase(
   knowledgeBaseId: string,
@@ -557,7 +558,7 @@ export async function updateKnowledgeBase(
   },
   requestId: string,
   options?: { actorUserId?: string; assertedWorkspaceId?: string }
-): Promise<KnowledgeBaseWithCounts> {
+): Promise<ActiveKnowledgeBaseReference> {
   if (updates.workspaceId !== undefined && !updates.workspaceId) {
     throw new OrchestrationError('validation', 'Workspace ID is required')
   }
@@ -890,35 +891,9 @@ export async function updateKnowledgeBase(
     }
   }
 
-  const updatedKb = await db
-    .select({
-      id: knowledgeBase.id,
-      userId: knowledgeBase.userId,
-      name: knowledgeBase.name,
-      isSearchIndex: knowledgeBase.isSearchIndex,
-      description: knowledgeBase.description,
-      tokenCount: sql<number>`COALESCE(SUM(${document.tokenCount}), 0)`.mapWith(Number),
-      embeddingModel: knowledgeBase.embeddingModel,
-      embeddingDimension: knowledgeBase.embeddingDimension,
-      chunkingConfig: knowledgeBase.chunkingConfig,
-      createdAt: knowledgeBase.createdAt,
-      updatedAt: knowledgeBase.updatedAt,
-      deletedAt: knowledgeBase.deletedAt,
-      workspaceId: knowledgeBase.workspaceId,
-      organizationId: knowledgeBase.organizationId,
-      folderId: knowledgeBase.folderId,
-      docCount: count(document.knowledgeBaseId),
-    })
+  const [updated] = await db
+    .select(ACTIVE_KNOWLEDGE_BASE_REFERENCE_FIELDS)
     .from(knowledgeBase)
-    .leftJoin(
-      document,
-      and(
-        eq(document.knowledgeBaseId, knowledgeBase.id),
-        eq(document.userExcluded, false),
-        isNull(document.archivedAt),
-        isNull(document.deletedAt)
-      )
-    )
     .where(
       and(
         eq(knowledgeBase.id, knowledgeBaseId),
@@ -928,23 +903,15 @@ export async function updateKnowledgeBase(
           : undefined
       )
     )
-    .groupBy(knowledgeBase.id)
     .limit(1)
 
-  if (updatedKb.length === 0) {
+  if (!updated) {
     throw new KnowledgeBaseNotFoundError(knowledgeBaseId)
   }
 
   logger.info(`[${requestId}] Updated knowledge base: ${knowledgeBaseId}`)
 
-  const [withConnectors] = await attachConnectorTypes([
-    {
-      ...updatedKb[0],
-      chunkingConfig: updatedKb[0].chunkingConfig as ChunkingConfig,
-      docCount: Number(updatedKb[0].docCount),
-    },
-  ])
-  return withConnectors
+  return toActiveKnowledgeBaseReference(updated)
 }
 
 /**