fix(glasser): bound polling failures, split social inputs, drop section comments

Address review: a rejected or undecodable poll now counts toward the
three-error budget and returns success: false instead of escaping the
loop; Social Media Search gets its own query and URL controls keyed on
its mode rather than the hidden web action; the news query copy says the
domain stays required (the API contract requires it); test drops its any
cast; non-TSDoc section comments removed.

Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>

Author: glasserai

apps/sim/blocks/blocks/glasser.ts

@@ -73,6 +73,8 @@ const ID_TO_PARAM: Record<string, string> = {
   ci_query: 'query',
   sr_platform: 'platform',
   sr_mode: 'mode',
+  sr_query: 'query',
+  sr_url: 'url',
 }
 
 /** Per operation, the sub-block that carries the API's `action`. */
@@ -118,7 +120,7 @@ export const GlasserBlock: BlockConfig<GlasserResponse> = {
         [SOCIAL]: [
           { text: 'Get', field: 'sr_mode', core: true },
           { text: 'on', field: 'sr_platform', core: true },
-          { text: 'for', field: ['query', 'handle', 'url'] },
+          { text: 'for', field: ['sr_query', 'handle', 'sr_url'] },
         ],
         [MARKET]: [
           { text: 'Get', field: 'md_action', core: true },
@@ -144,7 +146,6 @@ export const GlasserBlock: BlockConfig<GlasserResponse> = {
       value: () => PEOPLE,
     },
 
-    // --- Find Prospects ---
     {
       id: 'ps_action',
       title: 'Action',
@@ -273,7 +274,6 @@ export const GlasserBlock: BlockConfig<GlasserResponse> = {
       },
     },
 
-    // --- Company Intelligence ---
     {
       id: 'ci_action',
       title: 'Company Report',
@@ -306,7 +306,6 @@ export const GlasserBlock: BlockConfig<GlasserResponse> = {
       mode: 'advanced',
     },
 
-    // --- Keywords and SEO ---
     {
       id: 'seo_action',
       title: 'SEO Report',
@@ -344,7 +343,6 @@ export const GlasserBlock: BlockConfig<GlasserResponse> = {
       },
     },
 
-    // --- Web Research ---
     {
       id: 'wr_action',
       title: 'Action',
@@ -371,7 +369,7 @@ export const GlasserBlock: BlockConfig<GlasserResponse> = {
       placeholder: 'Search phrase or question',
       condition: {
         field: 'operation',
-        value: [WEB, SOCIAL],
+        value: WEB,
         and: { field: 'wr_action', value: ['scrape', 'similar'], not: true },
       },
       required: {
@@ -387,7 +385,7 @@ export const GlasserBlock: BlockConfig<GlasserResponse> = {
       placeholder: 'https://example.com/page',
       condition: {
         field: 'operation',
-        value: [WEB, SOCIAL],
+        value: WEB,
         and: { field: 'wr_action', value: ['scrape', 'similar'] },
       },
       required: {
@@ -405,7 +403,6 @@ export const GlasserBlock: BlockConfig<GlasserResponse> = {
       mode: 'advanced',
     },
 
-    // --- Social Media Search ---
     {
       id: 'sr_platform',
       title: 'Platform',
@@ -436,6 +433,30 @@ export const GlasserBlock: BlockConfig<GlasserResponse> = {
       value: () => 'search',
       condition: { field: 'operation', value: SOCIAL },
     },
+    {
+      id: 'sr_query',
+      title: 'Query',
+      type: 'long-input',
+      placeholder: 'Search phrase',
+      condition: {
+        field: 'operation',
+        value: SOCIAL,
+        and: { field: 'sr_mode', value: ['search', 'find'] },
+      },
+      required: { field: 'operation', value: SOCIAL, and: { field: 'sr_mode', value: 'search' } },
+    },
+    {
+      id: 'sr_url',
+      title: 'URL',
+      type: 'short-input',
+      placeholder: 'Post URL, or a LinkedIn profile or company page URL',
+      condition: {
+        field: 'operation',
+        value: SOCIAL,
+        and: { field: 'sr_mode', value: 'search', not: true },
+      },
+      required: { field: 'operation', value: SOCIAL, and: { field: 'sr_mode', value: 'post' } },
+    },
     {
       id: 'handle',
       title: 'Handle',
@@ -448,7 +469,6 @@ export const GlasserBlock: BlockConfig<GlasserResponse> = {
       },
     },
 
-    // --- Market Data ---
     {
       id: 'md_action',
       title: 'Market Report',
@@ -551,7 +571,6 @@ export const GlasserBlock: BlockConfig<GlasserResponse> = {
       },
     },
 
-    // --- Shared ---
     {
       id: 'country',
       title: 'Country',
@@ -630,7 +649,6 @@ export const GlasserBlock: BlockConfig<GlasserResponse> = {
     task_id: { type: 'string', description: 'Task the runs are filed under' },
     limit: { type: 'number', description: 'Rows to return' },
     country: { type: 'string', description: 'Country as ISO code or name' },
-    // Find Prospects
     ps_action: { type: 'string', description: 'search, enrich or find_email' },
     job_titles: { type: 'string', description: 'Job titles, comma-separated' },
     seniorities: { type: 'json', description: 'Seniority levels' },
@@ -640,23 +658,20 @@ export const GlasserBlock: BlockConfig<GlasserResponse> = {
     full_name: { type: 'string', description: "Person's full name" },
     email: { type: 'string', description: 'Email address' },
     linkedin_url: { type: 'string', description: 'LinkedIn profile URL' },
-    // Company Intelligence
     ci_action: { type: 'string', description: 'Company report to fetch' },
     domain: { type: 'string', description: 'Website domain' },
     ci_query: { type: 'string', description: 'Company name for news search' },
-    // Keywords and SEO
     seo_action: { type: 'string', description: 'SEO report to fetch' },
     seo_keywords: { type: 'string', description: 'Keywords, comma-separated' },
-    // Web Research
     wr_action: { type: 'string', description: 'Web research action' },
     query: { type: 'string', description: 'Search phrase or question' },
-    url: { type: 'string', description: 'Page or post URL' },
+    url: { type: 'string', description: 'Page URL' },
     language: { type: 'string', description: 'Two-letter language code' },
-    // Social Media Search
     sr_platform: { type: 'string', description: 'Social platform' },
     sr_mode: { type: 'string', description: 'What to read on the platform' },
+    sr_query: { type: 'string', description: 'Search phrase (social)' },
+    sr_url: { type: 'string', description: 'Post, profile or company page URL (social)' },
     handle: { type: 'string', description: 'Username or subreddit' },
-    // Market Data
     md_action: { type: 'string', description: 'Market report to fetch' },
     address: { type: 'string', description: 'US street address' },
     city: { type: 'string', description: 'US city' },

apps/sim/tools/generated/tool-metadata.ts

@@ -46,7 +46,7 @@ export const companyIntelligenceTool: ToolConfig<
       required: false,
       visibility: 'user-or-llm',
       description:
-        'For news via Serper only: the company name to search Google News by, instead of the domain',
+        'For news via Serper only: the company name to search Google News by. The domain is still required and identifies the company.',
     },
     limit: COMMON_PARAMS.limit,
     provider: {

apps/sim/tools/glasser/company_intelligence.ts

@@ -43,9 +43,8 @@ const respond = (body: unknown, status = 200) =>
 
 describe('glasser request shape', () => {
   it('posts to the gtm solution with a bearer key and a fresh idempotency key per call', () => {
-    const headers = peopleSearchTool.request.headers as (p: any) => Record<string, string>
-    const first = headers({ apiKey: 'gl_test' })
-    const second = headers({ apiKey: 'gl_test' })
+    const first = peopleSearchTool.request.headers({ apiKey: 'gl_test' })
+    const second = peopleSearchTool.request.headers({ apiKey: 'gl_test' })
 
     expect(peopleSearchTool.request.url).toBe(`${GLASSER_API_BASE}/v1/solutions/gtm/people_search`)
     expect(first.Authorization).toBe('Bearer gl_test')
@@ -169,6 +168,23 @@ describe('glasser polling', () => {
     expect(result.output.status).toBe('COMPLETED')
   })
 
+  it('counts a rejected poll toward the error budget instead of throwing', async () => {
+    vi.useFakeTimers()
+    const fetchMock = vi.fn().mockRejectedValue(new Error('socket hang up'))
+    vi.stubGlobal('fetch', fetchMock)
+    const initial = await companyIntelligenceTool.transformResponse!(
+      respond(run({ status: 'RUNNING', output: null }), 202)
+    )
+
+    const pending = pollRun(initial, { apiKey: 'k' })
+    await vi.advanceTimersByTimeAsync(6000)
+    const result = await pending
+
+    expect(fetchMock).toHaveBeenCalledTimes(3)
+    expect(result.success).toBe(false)
+    expect(result.error).toBe('Glasser polling failed: socket hang up')
+  })
+
   it('gives up after repeated polling errors', async () => {
     vi.useFakeTimers()
     const fetchMock = vi.fn().mockImplementation(async () => respond({ error: 'down' }, 503))

apps/sim/tools/glasser/glasser.test.ts

@@ -1,3 +1,4 @@
+import { getErrorMessage } from '@sim/utils/errors'
 import { sleep } from '@sim/utils/helpers'
 import { generateId } from '@sim/utils/id'
 import type { GlasserResponse, GlasserRun, GlasserRunOutput } from '@/tools/glasser/types'
@@ -98,7 +99,9 @@ export const transformRun: ToolConfig<{ apiKey: string }, GlasserResponse>['tran
 
 /**
  * A run that came back QUEUED or RUNNING is read from `GET /v1/runs/{id}` until it is
- * terminal or the budget is spent. Used as every Glasser tool's `postProcess`.
+ * terminal or the budget is spent. Used as every Glasser tool's `postProcess`. It never throws:
+ * a thrown error would make the executor fall back to the initial in-flight result, so every
+ * failure is returned as a bounded `success: false` instead.
  */
 export async function pollRun(
   result: GlasserResponse,
@@ -117,29 +120,30 @@ export async function pollRun(
     await sleep(POLL_INTERVAL_MS)
     elapsed += POLL_INTERVAL_MS
 
-    const response = await fetch(`${GLASSER_API_BASE}/v1/runs/${encodeURIComponent(runId)}`, {
-      headers: {
-        Authorization: `Bearer ${params.apiKey}`,
-        'User-Agent': USER_AGENT,
-      },
-    })
-
-    if (!response.ok) {
-      consecutiveErrors += 1
-      if (consecutiveErrors >= MAX_CONSECUTIVE_POLL_ERRORS) {
-        const errorText = await response.text().catch(() => '')
-        return {
-          success: false,
-          error: `Glasser API error: ${response.status} - ${errorText}`,
-          output: result.output,
-        }
+    let failure: string | null = null
+    try {
+      const response = await fetch(`${GLASSER_API_BASE}/v1/runs/${encodeURIComponent(runId)}`, {
+        headers: {
+          Authorization: `Bearer ${params.apiKey}`,
+          'User-Agent': USER_AGENT,
+        },
+      })
+      if (response.ok) {
+        const run = (await response.json()) as GlasserRun
+        if (TERMINAL_STATUSES.has(run.status)) return runResult(run)
+        consecutiveErrors = 0
+        continue
       }
-      continue
+      const errorText = await response.text().catch(() => '')
+      failure = `Glasser API error: ${response.status} - ${errorText}`
+    } catch (error) {
+      failure = `Glasser polling failed: ${getErrorMessage(error)}`
     }
-    consecutiveErrors = 0
 
-    const run = (await response.json()) as GlasserRun
-    if (TERMINAL_STATUSES.has(run.status)) return runResult(run)
+    consecutiveErrors += 1
+    if (consecutiveErrors >= MAX_CONSECUTIVE_POLL_ERRORS) {
+      return { success: false, error: failure, output: result.output }
+    }
   }
 
   return {

apps/sim/tools/glasser/run.ts

@@ -60,7 +60,7 @@ export const webResearchTool: ToolConfig<GlasserWebResearchParams, GlasserRespon
   },
 
   request: {
-    // Only `answer` hands the query to a model (Exa's answer endpoint); every other action is a plain search or fetch.
+    /** Only `answer` hands the query to a model (Exa's answer endpoint); every other action is a plain search or fetch. */
     modelInput: {
       mode: 'project',
       select: (params) => (params.action === 'answer' ? { query: params.query } : {}),