Skip to content

Commit 41bc4c3

Browse files
committed
fix(sim-setup): address review feedback on no-install hint
1 parent 551de95 commit 41bc4c3

2 files changed

Lines changed: 5 additions & 3 deletions

File tree

‎packages/sim-setup/src/lifecycle.test.ts‎

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -144,6 +144,7 @@ describe('no-install hint', () => {
144144
const lines = noInstallHint({ dockerReachable: true, cwd: '/home/dev' })
145145
expect(lines[0]).toContain('/home/dev')
146146
expect(lines[1]).toContain('--dir')
147-
expect(lines[2]).toContain('npx sim-setup')
147+
expect(lines[2]).toContain('kubectl')
148+
expect(lines[3]).toContain('npx sim-setup')
148149
})
149150
})

‎packages/sim-setup/src/lifecycle.ts‎

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -370,12 +370,13 @@ export function noInstallHint(options: { dockerReachable: boolean; cwd: string }
370370
if (!options.dockerReachable) {
371371
return [
372372
'Docker is not reachable, so a Compose install cannot be detected.',
373-
'Start Docker Desktop (or OrbStack), then re-run this command.',
373+
'Start Docker (Docker Desktop or OrbStack, or the docker service on Linux), then re-run this command.',
374374
]
375375
}
376376
return [
377377
`No Sim install found from ${options.cwd}.`,
378-
`Already set up? Run this from the folder that contains your sim/ directory, or pass ${theme.command('--dir <path-to-sim>')}.`,
378+
`Docker Compose install? Run this from the folder that contains your sim/ directory, or pass ${theme.command('--dir <path-to-sim>')}.`,
379+
'Kubernetes install? Check that your current kubectl context is the one Sim was installed in.',
379380
`New here? Run ${theme.command('npx sim-setup')}.`,
380381
]
381382
}

0 commit comments

Comments
 (0)