Commit 7e8d3ff
authored
fix(dashboards): carry dashboard chat context ids, label the chart readout, isolate repository tests (#8499)
* fix(dashboards): carry dashboard chat context ids, label the chart readout, isolate repository tests
- User message contexts keep a dashboard mention's dashboardId, both in the
optimistic message and when a persisted message is reopened, matching the
context the server stores.
- The time-series readout row has role="group", so its aria-label is exposed to
assistive technology.
- The revision test in the dashboard repository suite seeds its own workspace
instead of depending on the previous test's row.
* fix(dashboards): name the chart readout group only when it has values1 parent 51f793b commit 7e8d3ff
5 files changed
Lines changed: 21 additions & 3 deletions
File tree
- apps/sim
- app/workspace/[workspaceId]/home/hooks
- components/charts
- lib
- dashboards
- mothership/chat
Lines changed: 1 addition & 0 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
3423 | 3423 | | |
3424 | 3424 | | |
3425 | 3425 | | |
| 3426 | + | |
3426 | 3427 | | |
3427 | 3428 | | |
3428 | 3429 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
19 | 19 | | |
20 | 20 | | |
21 | 21 | | |
| 22 | + | |
22 | 23 | | |
23 | 24 | | |
24 | 25 | | |
| 26 | + | |
25 | 27 | | |
26 | | - | |
| 28 | + | |
27 | 29 | | |
28 | 30 | | |
29 | 31 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
53 | 53 | | |
54 | 54 | | |
55 | 55 | | |
56 | | - | |
| 56 | + | |
57 | 57 | | |
58 | 58 | | |
59 | 59 | | |
60 | 60 | | |
61 | 61 | | |
62 | 62 | | |
63 | 63 | | |
64 | | - | |
| 64 | + | |
65 | 65 | | |
66 | 66 | | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
208 | 208 | | |
209 | 209 | | |
210 | 210 | | |
| 211 | + | |
| 212 | + | |
| 213 | + | |
| 214 | + | |
| 215 | + | |
| 216 | + | |
| 217 | + | |
| 218 | + | |
| 219 | + | |
| 220 | + | |
| 221 | + | |
| 222 | + | |
| 223 | + | |
| 224 | + | |
211 | 225 | | |
212 | 226 | | |
213 | 227 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
149 | 149 | | |
150 | 150 | | |
151 | 151 | | |
| 152 | + | |
152 | 153 | | |
153 | 154 | | |
154 | 155 | | |
| |||
0 commit comments