test(cleanup): port storage-cleanup ownership tests and drop stale mock keys

Author: waleedlatif1

apps/sim/lib/knowledge/documents/storage-cleanup.test.ts

@@ -41,6 +41,26 @@ const payload = {
   workspaceId: binding.workspaceId,
   organizationId: null,
 }
+const SOURCE_WORKSPACE_ID = 'workspace-1'
+const SOURCE_KEY = `workspace/${SOURCE_WORKSPACE_ID}/source.pdf`
+const SOURCE_URL = `/api/files/serve/${encodeURIComponent(SOURCE_KEY)}?context=workspace`
+const SOURCE_UPDATED_AT = new Date('2026-08-05T12:00:00.000Z')
+const SOURCE_BINDING = {
+  id: 'source-file-1',
+  key: SOURCE_KEY,
+  userId: 'source-user',
+  workspaceId: SOURCE_WORKSPACE_ID,
+  context: 'workspace',
+  originalName: 'source.pdf',
+  displayName: 'source.pdf',
+  contentType: 'application/pdf',
+  size: 512,
+  folderId: null,
+  uploadedAt: SOURCE_UPDATED_AT,
+  contentUpdatedAt: SOURCE_UPDATED_AT,
+  deletedAt: null,
+  secretProvenanceVersion: 1,
+}
 function context(): OutboxEventContext {
   return {
     eventId: 'cleanup-1',
@@ -179,4 +199,51 @@ describe('durable knowledge storage cleanup', () => {
     expect(dbChainMockFns.transaction).not.toHaveBeenCalled()
     expect(mockDeleteFile).not.toHaveBeenCalled()
   })
+  it('never deletes a referenced workspace source as knowledge-base storage', async () => {
+    await enqueueKnowledgeStorageCleanup(
+      db,
+      [{ id: 'document-1', fileUrl: SOURCE_URL, workspaceId: SOURCE_WORKSPACE_ID }],
+      'request-1'
+    )
+
+    expect(mockGetBindings).not.toHaveBeenCalled()
+    expect(mockDeleteFile).not.toHaveBeenCalled()
+    expect(mockDeleteMetadata).not.toHaveBeenCalled()
+  })
+
+  it.each(['org-1', 'org-2', null])(
+    'only queues an organization cache for its exact owner: %s',
+    async (organizationId) => {
+      const storageKey = 'kb/org-source.pdf'
+      mockGetBindings.mockResolvedValue([
+        {
+          ...SOURCE_BINDING,
+          key: storageKey,
+          context: 'knowledge-base',
+          workspaceId: null,
+          organizationId: 'org-1',
+        },
+      ])
+      const cleanup = enqueueKnowledgeStorageCleanup(
+        db,
+        [
+          {
+            id: 'org-doc',
+            fileUrl: `/api/files/serve/${encodeURIComponent(storageKey)}`,
+            workspaceId: null,
+            organizationId,
+          },
+        ],
+        'request-1'
+      )
+      if (organizationId === 'org-1') {
+        await cleanup
+        expect(dbChainMockFns.values).toHaveBeenCalledOnce()
+      } else {
+        await expect(cleanup).rejects.toThrow()
+        expect(dbChainMockFns.values).not.toHaveBeenCalled()
+      }
+      expect(mockDeleteFile).not.toHaveBeenCalled()
+    }
+  )
 })

apps/sim/lib/logs/log-views.test.ts

@@ -1,6 +1,6 @@
 import { describe, expect, it } from 'vitest'
+import { toOverview } from '@/lib/logs/log-views'
 import type { TraceSpan } from '@/lib/logs/types'
-import { toOverview } from './log-views'
 
 const ref = (preview: unknown) => ({ __sim: 'ref', preview, size: 100 })
 

apps/sim/lib/table/bulk-update-concurrency.test.ts

@@ -29,7 +29,6 @@ vi.mock('@/lib/table/sql', () => ({
   buildFilterClause: vi.fn(() => sql`true`),
   buildPredicateClause: vi.fn(() => sql`true`),
   buildSortClause: vi.fn(() => sql`true`),
-  escapeLikePattern: vi.fn((value: string) => value),
   uniqueValuePredicate: vi.fn(() => sql`true`),
 }))
 

apps/sim/lib/table/find-row-matches.test.ts

@@ -14,7 +14,6 @@ import type { ColumnDefinition, TableDefinition } from '@/lib/table/types'
 vi.mock('@/lib/table/sql', () => ({
   buildFilterClause: vi.fn(() => sql`true`),
   buildSortClause: vi.fn(() => sql`true`),
-  escapeLikePattern: vi.fn((s: string) => s),
 }))
 
 vi.mock('@/lib/table/trigger', () => tableTriggerMock)

apps/sim/lib/table/rows/bulk-update-patch-validation.test.ts

@@ -31,7 +31,6 @@ vi.mock('@/lib/table/sql', () => ({
   buildFilterClause: vi.fn(() => sql`true`),
   buildPredicateClause: vi.fn(() => sql`true`),
   buildSortClause: vi.fn(() => sql`true`),
-  escapeLikePattern: vi.fn((value: string) => value),
   uniqueValuePredicate: vi.fn(() => sql`true`),
 }))