fix(slack): address workflow API review findings

Author: TheodoreSpeaks

apps/docs/content/docs/integrations/slack.mdx

@@ -2251,7 +2251,7 @@ Start an asynchronous CSV or JSON List export. Use the returned job_id with Get
 
 ### Slack Get List Export
 
-Read a List export job status and its download URL when ready. Format and inclusion options must match Start List Export.
+Read a List export job status and its download URL when ready. Format, Include Threads, and Include Attachments must match Start List Export.
 
 #### Input
 
@@ -2340,7 +2340,7 @@ Join a public Slack channel as the authenticated bot.
 | Parameter | Type | Description |
 | --------- | ---- | ----------- |
 | `ok` | boolean | Ok |
-| `channel` | object | Conversation |
+| `conversation` | object | Conversation |
 |   ↳ `id` | string | Id |
 |   ↳ `name` | string | Name |
 |   ↳ `creator` | string | Creator |
@@ -2462,7 +2462,7 @@ Open a DM or group DM with 1–8 user IDs, or resume a conversation by ID. Suppl
 | Parameter | Type | Description |
 | --------- | ---- | ----------- |
 | `ok` | boolean | Ok |
-| `channel` | object | Conversation |
+| `conversation` | object | Conversation |
 |   ↳ `id` | string | Id |
 |   ↳ `name` | string | Name |
 |   ↳ `creator` | string | Creator |
@@ -2725,7 +2725,7 @@ List one page of Slack files matching user, channel, type, or timestamp filters.
 | Parameter | Type | Description |
 | --------- | ---- | ----------- |
 | `ok` | boolean | Ok |
-| `files` | array | Files |
+| `fileMetadata` | array | Files |
 |   ↳ `id` | string | Id |
 |   ↳ `name` | string | Name |
 |   ↳ `title` | string | Title |
@@ -3261,7 +3261,7 @@ Read the user IDs in a Slack user group.
 | Parameter | Type | Required | Description |
 | --------- | ---- | -------- | ----------- |
 | `usergroup` | string | Yes | User Group ID |
-| `include_disabled` | boolean | No | Include Disabled Groups |
+| `include_disabled` | boolean | No | Include Disabled Users |
 | `team_id` | string | No | Workspace ID |
 
 #### Output
@@ -3372,7 +3372,7 @@ Search messages visible to the authorized Slack user. Requires a managed user cr
 
 ### Slack Search Files
 
-Search files visible to the authorized Slack user. Requires a managed user credential with search:read. Continue using files.paging.
+Search files visible to the authorized Slack user. Requires a managed user credential with search:read. Continue using fileSearchResults.paging.
 
 #### Input
 
@@ -3392,7 +3392,7 @@ Search files visible to the authorized Slack user. Requires a managed user crede
 | --------- | ---- | ----------- |
 | `ok` | boolean | Ok |
 | `query` | string | Query |
-| `files` | object | Filesearch |
+| `fileSearchResults` | object | Filesearch |
 |   ↳ `matches` | array | Matches |
 |     ↳ `id` | string | Id |
 |     ↳ `name` | string | Name |
@@ -3487,7 +3487,7 @@ Search messages and files visible to the authorized Slack user. Requires a manag
 |     ↳ `page_count` | number | Page count |
 |     ↳ `per_page` | number | Per page |
 |     ↳ `total_count` | number | Total count |
-| `files` | object | Filesearch |
+| `fileSearchResults` | object | Filesearch |
 |   ↳ `matches` | array | Matches |
 |     ↳ `id` | string | Id |
 |     ↳ `name` | string | Name |

apps/sim/blocks/blocks/slack-workflow-operations.test.ts

@@ -54,6 +54,30 @@ describe('Slack workflow operations in the existing block', () => {
     }
   )
 
+  it('keeps message output types while exposing conversation and file metadata separately', () => {
+    expect(SlackV2Block.outputs.channel.type).toBe('string')
+    expect(SlackV2Block.outputs.files.type).toBe('file[]')
+    for (const key of ['conversation', 'fileMetadata', 'fileSearchResults'])
+      expect(SlackV2Block.outputs[key].type).toBe('json')
+  })
+
+  it('does not offer Canvas ownership for channels and clears stale access choices', () => {
+    const field = SlackV2Block.subBlocks.find(({ id }) => id === 'slack_share_canvas_access_level')!
+    const options = field.options
+    if (typeof options !== 'function') throw new Error('Expected dynamic access options')
+    for (const channels of ['["C1"]', ['C1'], '<Block.channels>']) {
+      expect(
+        options({ values: { slack_share_canvas_channel_ids: channels } }).map(({ id }) => id)
+      ).toEqual(['read', 'write'])
+    }
+    for (const channels of ['', '[]', [], undefined]) {
+      expect(
+        options({ values: { slack_share_canvas_channel_ids: channels } }).map(({ id }) => id)
+      ).toContain('owner')
+    }
+    expect(field.dependsOn).toEqual(['slack_share_canvas_channel_ids'])
+  })
+
   it('keeps target alternatives available in basic mode', () => {
     for (const [operation, params] of [
       ['open_conversation', ['users', 'channel']],
@@ -164,6 +188,17 @@ describe('Slack custom-app permissions', () => {
     )
   })
 
+  it('grants conversation reads when only conversation management is enabled', () => {
+    const manifest = buildSlackManifest(new Set(['action_manage_conversations']), {
+      appName: 'Test',
+      webhookUrl: 'https://example.com/slack',
+    })
+    const oauth = manifest.oauth_config as { scopes: { bot: string[] } }
+    expect(oauth.scopes.bot).toEqual(
+      expect.arrayContaining(['channels:read', 'groups:read', 'im:read', 'mpim:read'])
+    )
+  })
+
   it('covers user-only operations through managed user scopes and leaves native Sim scopes unchanged', () => {
     for (const operation of SLACK_WORKFLOW_OPERATIONS.filter(({ auth }) => auth === 'user')) {
       expect(SLACK_MANAGED_USER_SCOPES).toEqual(

apps/sim/blocks/blocks/slack-workflow-operations.ts

@@ -13,6 +13,8 @@ interface SlackWorkflowField {
   type: 'string' | 'boolean' | 'number' | 'json'
   required: boolean
   enum?: string[]
+  options?: SubBlockConfig['options']
+  dependsOn?: string[]
   default?: string
   allowEmpty?: boolean
   basic?: boolean
@@ -192,6 +194,18 @@ export const SLACK_WORKFLOW_OPERATIONS: readonly SlackWorkflowOperation[] = [
         type: 'string',
         required: true,
         enum: ['read', 'write', 'owner'],
+        dependsOn: ['slack_share_canvas_channel_ids'],
+        options: ({ values } = { values: {} }) => {
+          const channels = values.slack_share_canvas_channel_ids
+          const hasChannels = Array.isArray(channels)
+            ? channels.length > 0
+            : typeof channels === 'string' && channels.trim() !== '' && channels.trim() !== '[]'
+          return [
+            { id: 'read', label: 'Can view' },
+            { id: 'write', label: 'Can edit' },
+            ...(!hasChannels ? [{ id: 'owner', label: 'Owner (users only)' }] : []),
+          ]
+        },
         default: 'read',
       },
       {
@@ -1175,7 +1189,7 @@ export const SLACK_WORKFLOW_OPERATIONS: readonly SlackWorkflowOperation[] = [
       {
         id: 'slack_list_user_group_members_include_disabled',
         param: 'include_disabled',
-        title: 'Include Disabled Groups',
+        title: 'Include Disabled Users',
         type: 'boolean',
         required: false,
       },
@@ -1653,7 +1667,8 @@ export function getSlackWorkflowSubBlocks(): SubBlockConfig[] {
         ...(field.type === 'json' ? { language: 'json' as const } : {}),
         ...(field.enum
           ? {
-              options: field.enum.map((value) => ({ id: value, label: value })),
+              options: field.options ?? field.enum.map((value) => ({ id: value, label: value })),
+              ...(field.dependsOn ? { dependsOn: field.dependsOn } : {}),
               ...(field.default === undefined ? {} : { value: () => field.default! }),
             }
           : {}),

apps/sim/blocks/blocks/slack.ts

@@ -3987,13 +3987,17 @@ export const SlackV2Block: BlockConfig<SlackResponse> = {
       type: 'json',
       description: 'Conversation messages, or search results with matches and paging',
     },
-    files: {
+    fileMetadata: {
       type: 'json',
-      description: 'File metadata, or search results with matches and paging',
+      description: 'Slack file metadata (id, name, title, mimetype, permalink)',
     },
-    channel: {
+    fileSearchResults: {
       type: 'json',
-      description: 'Conversation ID or opened conversation details, depending on the operation',
+      description: 'File search results with matches and paging',
+    },
+    conversation: {
+      type: 'json',
+      description: 'Opened or joined conversation details (id, name, is_im, is_mpim)',
     },
 
     listId: { type: 'string', description: 'Created List ID' },

apps/sim/tools/generated/tool-metadata.ts

@@ -1295,6 +1295,16 @@
   "slack_get_dnd_info": [
     {
       "ok": true
+    },
+    {
+      "ok": true,
+      "dnd_enabled": true,
+      "next_dnd_start_ts": 1450416600,
+      "next_dnd_end_ts": 1450452600,
+      "snooze_enabled": true,
+      "snooze_endtime": 1450416600,
+      "snooze_remaining": 1196,
+      "snooze_is_indefinite": false
     }
   ],
   "slack_get_team_dnd_info": [

apps/sim/tools/generated/tool-outputs.ts

@@ -24,6 +24,8 @@ export const slackJoinConversationTool = createSlackWebApiTool({
     },
   },
   input: z.object({ channel: z.string().trim().min(1) }),
-  output: z.object({ ok: z.literal(true), channel: conversationSchema }),
-  outputs: { ok: { type: 'boolean', description: 'Ok' }, channel: { ...conversationOutput } },
+  output: z
+    .object({ ok: z.literal(true), channel: conversationSchema })
+    .transform(({ channel, ...rest }) => ({ ...rest, conversation: channel })),
+  outputs: { ok: { type: 'boolean', description: 'Ok' }, conversation: { ...conversationOutput } },
 })

apps/sim/tools/slack/fixtures/workflow-api-responses.json

@@ -63,14 +63,16 @@ export const slackListFilesTool = createSlackWebApiTool({
     show_files_hidden_by_limit: z.boolean().optional(),
     team_id: z.string().trim().min(1).optional(),
   }),
-  output: z.object({
-    ok: z.literal(true),
-    files: z.array(fileSchema),
-    paging: pagingSchema.optional(),
-  }),
+  output: z
+    .object({
+      ok: z.literal(true),
+      files: z.array(fileSchema),
+      paging: pagingSchema.optional(),
+    })
+    .transform(({ files, ...rest }) => ({ ...rest, fileMetadata: files })),
   outputs: {
     ok: { type: 'boolean', description: 'Ok' },
-    files: { type: 'array', description: 'Files', items: { ...fileOutput } },
+    fileMetadata: { type: 'array', description: 'Files', items: { ...fileOutput } },
     paging: { ...pagingOutput, optional: true },
   },
 })

apps/sim/tools/slack/join_conversation.ts

@@ -25,7 +25,7 @@ export const slackListUserGroupMembersTool = createSlackWebApiTool({
       type: 'boolean',
       required: false,
       visibility: 'user-or-llm',
-      description: 'Include Disabled Groups',
+      description: 'Include Disabled Users',
     },
     team_id: {
       type: 'string',