fix(search): clarify activity result states and labels

Author: waleedlatif1

apps/sim/app/workspace/[workspaceId]/home/components/message-content/components/agent-group/activity-viewport.tsx

@@ -6,7 +6,7 @@ import { cn, scrollFadeAttributes, scrollFadeClass, useScrollEdges } from '@sim/
 interface ActivityViewportProps {
   children: ReactNode
   isStreaming: boolean
-  /** A nested blocking interaction must not be clipped by this ancestor's log viewport. */
+  /** Keeps nested interactions or independently scrolling detail lists from being clipped. */
   unbounded?: boolean
 }
 

apps/sim/app/workspace/[workspaceId]/home/components/message-content/components/agent-group/search-activity-details.tsx

@@ -20,6 +20,7 @@ export function getSearchActivitySources(tool: ToolCallData): SourceTagData[] |
     tool.status === ToolCallStatus.success &&
       tool.result?.success &&
       output?.success !== false &&
+      parseCitationRecord(data?.retrieval)?.status !== 'partial' &&
       Array.isArray(data?.results) &&
       data.results.length === 0
   )
@@ -29,12 +30,13 @@ export function getSearchActivitySources(tool: ToolCallData): SourceTagData[] |
 
 interface SearchActivityDetailsProps {
   sources: SourceTagData[]
+  label: string
 }
 
 /** Per-call evidence stays in the shared activity history, never in the live header. */
-export function SearchActivityDetails({ sources }: SearchActivityDetailsProps) {
+export function SearchActivityDetails({ sources, label }: SearchActivityDetailsProps) {
   return sources.length > 0 ? (
-    <SearchActivityResults sources={sources} />
+    <SearchActivityResults sources={sources} label={label} />
   ) : (
     <p className='text-[var(--text-muted)] text-caption'>No results</p>
   )

apps/sim/app/workspace/[workspaceId]/home/components/message-content/components/agent-group/search-activity-results.tsx

@@ -22,14 +22,15 @@ import type { SourceTagData } from '@/app/workspace/[workspaceId]/home/component
 
 interface SearchActivityResultsProps {
   sources: SourceTagData[]
+  label: string
 }
 
 /**
  * Bounded results keep every match available without growing the activity
  * transcript. The list shows four and a half 32px rows, so a clipped row signals
  * that it scrolls.
  */
-export function SearchActivityResults({ sources }: SearchActivityResultsProps) {
+export function SearchActivityResults({ sources, label }: SearchActivityResultsProps) {
   const scrollRef = useRef<HTMLDivElement>(null)
   const edges = useScrollEdges(scrollRef)
 
@@ -38,7 +39,7 @@ export function SearchActivityResults({ sources }: SearchActivityResultsProps) {
       <div
         ref={scrollRef}
         role='region'
-        aria-label='Search results'
+        aria-label={label}
         className={cn('max-h-[152px] overflow-y-auto overscroll-contain p-1', scrollFadeClass)}
         {...scrollFadeAttributes(edges)}
       >

apps/sim/app/workspace/[workspaceId]/home/components/message-content/components/agent-group/search-activity.test.tsx

@@ -115,7 +115,7 @@ describe('search in shared tool activity', () => {
     expand()
     expect(container.querySelectorAll('a')).toHaveLength(3)
     expect(container.querySelector('[role="region"]')?.getAttribute('aria-label')).toBe(
-      'Search results'
+      'Search results for step 1: Searched documents'
     )
     expect(container.innerHTML).not.toContain('in:launch review')
     expect(container.innerHTML).not.toContain('raw-provider-query-sentinel')
@@ -176,6 +176,14 @@ describe('search in shared tool activity', () => {
     expect(header().getAttribute('aria-expanded')).toBe('true')
     expect(container.querySelectorAll('a')).toHaveLength(6)
     expect(container.querySelectorAll('[role="region"]')).toHaveLength(2)
+    expect(
+      [...container.querySelectorAll('[role="region"]')].map((region) =>
+        region.getAttribute('aria-label')
+      )
+    ).toEqual([
+      'Search results for step 1: Searched documents',
+      'Search results for step 2: Searched documents',
+    ])
     act(() => header().dispatchEvent(new KeyboardEvent('keydown', { key: 'Enter', bubbles: true })))
     expect(header().getAttribute('aria-expanded')).toBe('false')
   })
@@ -232,14 +240,49 @@ describe('search in shared tool activity', () => {
     expect(container.querySelectorAll('a')).toHaveLength(0)
   })
 
-  it('shows an empty result only in its history, without a header count', () => {
+  it.each([undefined, { status: 'complete', timedOutLegs: [] }])(
+    'shows a complete or legacy empty result only in its history, without a header count',
+    (retrieval) => {
+      render([
+        {
+          ...tool,
+          status: 'success',
+          result: { success: true, output: { data: { results: [], retrieval } } },
+        },
+      ])
+      expect(headerText()).toBe('Searched documents')
+      expect(container.textContent).not.toContain('results')
+      expand()
+      expect(container.textContent).toContain('No results')
+    }
+  )
+
+  it('does not claim no results or expose an empty disclosure when retrieval is partial', () => {
     render([
-      { ...tool, status: 'success', result: { success: true, output: { data: { results: [] } } } },
+      {
+        ...tool,
+        status: 'success',
+        result: {
+          success: true,
+          output: {
+            data: { results: [], retrieval: { status: 'partial', timedOutLegs: ['vector'] } },
+          },
+        },
+      },
     ])
     expect(headerText()).toBe('Searched documents')
-    expect(container.textContent).not.toContain('results')
+    expect(header()).toBeNull()
+    expect(container.textContent).not.toContain('No results')
+  })
+
+  it('preserves available source matches when retrieval is partial', () => {
+    const search = completedSearch('partial', 'Available matches')
+    const output = search.result!.output as { data: Record<string, unknown> }
+    output.data.retrieval = { status: 'partial', timedOutLegs: ['vector'] }
+    render([search])
     expand()
-    expect(container.textContent).toContain('No results')
+    expect(container.querySelectorAll('a')).toHaveLength(3)
+    expect(container.textContent).not.toContain('No results')
   })
 
   it.each([

apps/sim/app/workspace/[workspaceId]/home/components/message-content/components/agent-group/tool-activity-group.tsx

@@ -240,17 +240,22 @@ export function ToolActivityGroup({
           expanded={expanded}
           onToggle={() => setExpanded(!expanded)}
           isStreaming={working && autoScrollActivity}
-          unbounded={hasSearchDetails}
+          unbounded={entries.some(({ sources }) => (sources?.length ?? 0) > 0)}
         >
           <div className='flex min-w-0 flex-col gap-1.5 py-0.5'>
-            {entries.map(({ tool, sources }) => (
+            {entries.map(({ tool, sources }, index) => (
               <Fragment key={tool.id}>
                 {tools.length === 1 ? null : tool.id === headerTool.id ? (
                   <ActivityStatus {...status} />
                 ) : (
                   <ToolCallComponent {...tool} toolCallId={tool.id} />
                 )}
-                {sources && <SearchActivityDetails sources={sources} />}
+                {sources && (
+                  <SearchActivityDetails
+                    sources={sources}
+                    label={`Search results for step ${index + 1}: ${getToolTitle(tool)}`}
+                  />
+                )}
               </Fragment>
             ))}
           </div>