fix(tests): refresh test tabs after a run, keep saved edits successful

- A finished Mothership run refreshes its tests instead of upserting tabs, so a
  test deleted mid-run does not come back.
- A failed file-tab lookup after a saved edit opens no tab instead of
  reporting the edit as failed.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01EHGBgHrtePpi7KMrEfy41R

Author: TheodoreSpeaks

apps/sim/lib/mothership/resources/file-tabs.ts

@@ -1,9 +1,12 @@
 import { db } from '@sim/db'
 import { workspaceFiles } from '@sim/db/schema'
+import { createLogger } from '@sim/logger'
 import { toStringOrNull } from '@sim/utils/coerce'
 import { and, inArray, notInArray } from 'drizzle-orm'
 import type { BaseServerTool } from '@/lib/mothership/tools/server/base-tool'
 
+const logger = createLogger('FileTabs')
+
 /** Row contexts that open as a file tab: workspace files and chat uploads. */
 const FILE_TAB_CONTEXTS = ['workspace', 'mothership']
 
@@ -38,8 +41,16 @@ export function withFileTabFlag<TArgs, TResult extends { data?: Record<string, u
     async execute(args, context) {
       const result = await tool.execute(args, context)
       const id = toStringOrNull(result.data?.id)
-      if (id === null || !(await findNonTabFileIds([id])).has(id)) return result
-      return { ...result, data: { ...result.data, fileTab: false } }
+      if (id === null) return result
+      let isTab: boolean
+      try {
+        isTab = !(await findNonTabFileIds([id])).has(id)
+      } catch (error) {
+        // The edit already saved, so a failed lookup opens no tab rather than failing it.
+        logger.error('Could not check whether an edited file is a file tab', { id, error })
+        isTab = false
+      }
+      return isTab ? result : { ...result, data: { ...result.data, fileTab: false } }
     },
   }
 }

apps/sim/lib/mothership/tools/server/tests.ts

@@ -144,8 +144,8 @@ export const testsServerTool: BaseServerTool = {
           )
           if (current.every((run) => run.status !== 'running')) {
             const resources: ResourceChange[] = current.map((run) => ({
-              op: 'upsert',
-              resource: { type: 'test', workspaceId, id: run.name, title: run.title },
+              op: 'refresh',
+              resource: { type: 'test', id: run.name },
             }))
             return {
               resources,

apps/sim/lib/workflow-tests/application/tests.ts

@@ -390,7 +390,6 @@ export const readWorkflowTestRuns = defineAuthorizedWorkspaceUseCase({
       runs: rows.map((row) => ({
         ...presentRun(row, row.testSourceHash, facts),
         name: row.testName,
-        title: row.testTitle,
         report: row.report as TestReport | null,
       })),
     }

apps/sim/lib/workflow-tests/repository.ts

@@ -437,24 +437,16 @@ export async function getWorkflowTestRunById(
 export async function listWorkflowTestRunsById(
   runIds: string[],
   workspaceId: string
-): Promise<
-  Array<WorkflowTestRunRow & { testName: string; testTitle: string; testSourceHash: string }>
-> {
+): Promise<Array<WorkflowTestRunRow & { testName: string; testSourceHash: string }>> {
   if (runIds.length === 0) return []
   const rows = await db
     .select({
       run: workflowTestRun,
       testName: workflowTest.name,
-      testTitle: workflowTest.title,
       testSourceHash: workflowTest.sourceHash,
     })
     .from(workflowTestRun)
     .innerJoin(workflowTest, eq(workflowTest.id, workflowTestRun.testId))
     .where(and(inArray(workflowTestRun.id, runIds), eq(workflowTestRun.workspaceId, workspaceId)))
-  return rows.map(({ run, testName, testTitle, testSourceHash }) => ({
-    ...run,
-    testName,
-    testTitle,
-    testSourceHash,
-  }))
+  return rows.map(({ run, testName, testSourceHash }) => ({ ...run, testName, testSourceHash }))
 }