Skip to content

Commit 57c72e0

Browse files
SK-2954: Confirm all four v3 EnvUrls (DEV/SANDBOX/STAGE/PROD)
All four were already pattern-derived correctly; now confirmed against the authoritative values and no longer flagged unconfirmed. Added PROD/SANDBOX/STAGE resolve_vault_url test coverage alongside the existing DEV test. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
1 parent 348ea15 commit 57c72e0

2 files changed

Lines changed: 20 additions & 9 deletions

File tree

v3/skyflow/utils/enums/_env_urls.py

Lines changed: 5 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -2,9 +2,8 @@
22

33

44
class EnvUrls(Enum):
5-
"""v3 vault hosts -- a different subdomain than v2 (skyvault vs. vault). Only DEV is
6-
confirmed against a live vault; the rest are pattern-derived and unconfirmed."""
7-
DEV = "skyvault.skyflowapis.dev" # confirmed against a live vault
8-
PROD = "skyvault.skyflowapis.com" # UNCONFIRMED -- pattern-derived
9-
SANDBOX = "skyvault.skyflowapis-preview.com" # UNCONFIRMED -- pattern-derived
10-
STAGE = "skyvault.skyflowapis.tech" # UNCONFIRMED -- pattern-derived
5+
"""v3 vault hosts -- a different subdomain than v2 (skyvault vs. vault). All four confirmed."""
6+
DEV = "skyvault.skyflowapis.dev"
7+
PROD = "skyvault.skyflowapis.com"
8+
SANDBOX = "skyvault.skyflowapis-preview.com"
9+
STAGE = "skyvault.skyflowapis.tech"

v3/tests/vault/client/test__client.py

Lines changed: 15 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -15,14 +15,26 @@ def test_is_a_base_vault_client(self):
1515

1616
# ------------------------------------------------------------------ #
1717
# resolve_vault_url — v3's own domain (skyvault.skyflowapis.*), confirmed
18-
# against a real vault to differ from v2's (vault.skyflowapis.*) for the
19-
# same cluster_id/env -- reusing v2's derivation here 404'd.
18+
# to differ from v2's (vault.skyflowapis.*) for the same cluster_id/env
19+
# -- reusing v2's derivation here 404'd. All four envs confirmed.
2020
# ------------------------------------------------------------------ #
2121

22-
def test_resolve_vault_url_uses_v3_skyvault_domain(self):
22+
def test_resolve_vault_url_uses_v3_skyvault_domain_dev(self):
2323
url = self.vault_client.resolve_vault_url("qhdmceurtnlz", Env.DEV, "myvault")
2424
self.assertEqual(url, "https://qhdmceurtnlz.skyvault.skyflowapis.dev")
2525

26+
def test_resolve_vault_url_uses_v3_skyvault_domain_prod(self):
27+
url = self.vault_client.resolve_vault_url("qhdmceurtnlz", Env.PROD, "myvault")
28+
self.assertEqual(url, "https://qhdmceurtnlz.skyvault.skyflowapis.com")
29+
30+
def test_resolve_vault_url_uses_v3_skyvault_domain_sandbox(self):
31+
url = self.vault_client.resolve_vault_url("qhdmceurtnlz", Env.SANDBOX, "myvault")
32+
self.assertEqual(url, "https://qhdmceurtnlz.skyvault.skyflowapis-preview.com")
33+
34+
def test_resolve_vault_url_uses_v3_skyvault_domain_stage(self):
35+
url = self.vault_client.resolve_vault_url("qhdmceurtnlz", Env.STAGE, "myvault")
36+
self.assertEqual(url, "https://qhdmceurtnlz.skyvault.skyflowapis.tech")
37+
2638
@patch("skyflow.vault.client.client.SkyflowAuth")
2739
def test_initialize_api_client_does_not_pass_token(self, mock_skyflow_auth):
2840
"""v3's generated client has no `token` param at all -- unlike v2, nothing should be

0 commit comments

Comments
 (0)