enhance: button states in Bisect toolbar

Signed-off-by: leo <longshuang@msn.cn>

Author: love-linger

src/Models/Bisect.cs

@@ -6,7 +6,8 @@ namespace SourceGit.Models
     public enum BisectState
     {
         None = 0,
-        WaitingForRange,
+        WaitingForFirstBad,
+        WaitingForFirstGood,
         Detecting,
     }
 

src/ViewModels/Histories.cs

@@ -212,10 +212,13 @@ public Models.BisectState UpdateBisectInfo()
 
             Bisect = info;
 
-            if (info.Bads.Count == 0 || info.Goods.Count == 0)
-                return Models.BisectState.WaitingForRange;
-            else
-                return Models.BisectState.Detecting;
+            if (info.Bads.Count == 0)
+                return Models.BisectState.WaitingForFirstBad;
+
+            if (info.Goods.Count == 0)
+                return Models.BisectState.WaitingForFirstGood;
+
+            return Models.BisectState.Detecting;
         }
 
         public void NavigateTo(string commitSHA)

src/Views/Repository.axaml

@@ -792,8 +792,14 @@
                    FontWeight="Bold"
                    Margin="8,0"
                    Foreground="{DynamicResource Brush.Conflict.Foreground}"
-                   Text="{DynamicResource Text.Bisect.WaitingForRange}"
-                   IsVisible="{Binding BisectState, Converter={x:Static ObjectConverters.Equal}, ConverterParameter={x:Static m:BisectState.WaitingForRange}}"/>
+                   Text="{DynamicResource Text.Bisect.WaitingForRange}">
+          <TextBlock.IsVisible>
+            <MultiBinding Converter="{x:Static BoolConverters.Or}">
+              <Binding Path="BisectState" Converter="{x:Static ObjectConverters.Equal}" ConverterParameter="{x:Static m:BisectState.WaitingForFirstBad}"/>
+              <Binding Path="BisectState" Converter="{x:Static ObjectConverters.Equal}" ConverterParameter="{x:Static m:BisectState.WaitingForFirstGood}"/>
+            </MultiBinding>
+          </TextBlock.IsVisible>
+        </TextBlock>
 
         <TextBlock Grid.Column="0"
                    FontWeight="Bold"
@@ -813,10 +819,16 @@
                 FontWeight="Regular"
                 BorderThickness="0"
                 Content="{DynamicResource Text.Bisect.Good}"
-                IsEnabled="{Binding !IsBisectCommandRunning}"
                 Padding="8,2"
                 Click="OnBisectCommand"
-                Tag="good"/>
+                Tag="good">
+          <Button.IsEnabled>
+            <MultiBinding Converter="{x:Static BoolConverters.And}">
+              <Binding Path="IsBisectCommandRunning" Converter="{x:Static BoolConverters.Not}"/>
+              <Binding Path="BisectState" Converter="{x:Static ObjectConverters.NotEqual}" ConverterParameter="{x:Static m:BisectState.WaitingForFirstBad}"/>
+            </MultiBinding>
+          </Button.IsEnabled>
+        </Button>        
         <Button Grid.Column="3"
                 Classes="flat"
                 Margin="4,0"
@@ -833,6 +845,7 @@
                 FontWeight="Regular"
                 BorderThickness="0"
                 Content="{DynamicResource Text.Bisect.Skip}"
+                IsVisible="{Binding BisectState, Converter={x:Static ObjectConverters.Equal}, ConverterParameter={x:Static m:BisectState.Detecting}}"
                 IsEnabled="{Binding !IsBisectCommandRunning}"
                 Padding="8,2"
                 Click="OnBisectCommand"