ux: hide tracffic lights spacer on Windows and Linux

Signed-off-by: leo <longshuang@msn.cn>

Author: love-linger

src/Views/Launcher.axaml

@@ -30,7 +30,8 @@
       <!-- Caption Buttons (macOS) -->
       <v:MacOSTrafficLightsSpacer Grid.Column="0"
                                   Zoom="{Binding Source={x:Static vm:Preferences.Instance}, Path=Zoom, Mode=OneWay}"
-                                  IsFullScreen="{Binding !#ThisControl.HasLeftCaptionButton, Mode=OneWay}"/>
+                                  IsFullScreen="{Binding #ThisControl.WindowState, Converter={x:Static ObjectConverters.Equal}, ConverterParameter={x:Static WindowState.FullScreen}}"
+                                  IsVisible="{OnPlatform False, macOS=True}"/>
 
       <!-- Menu (Windows/Linux) -->
       <Button Grid.Column="0" Classes="icon_button" VerticalAlignment="Bottom" Margin="6,0,0,3" IsVisible="{OnPlatform True, macOS=False}">

src/Views/Launcher.axaml.cs

@@ -21,17 +21,6 @@ public GridLength CaptionHeight
             set => SetAndRaise(CaptionHeightProperty, ref _captionHeight, value);
         }
 
-        public static readonly DirectProperty<Launcher, bool> HasLeftCaptionButtonProperty =
-            AvaloniaProperty.RegisterDirect<Launcher, bool>(
-                nameof(HasLeftCaptionButton),
-                o => o.HasLeftCaptionButton);
-
-        public bool HasLeftCaptionButton
-        {
-            get => _hasLeftCaptionButton;
-            set => SetAndRaise(HasLeftCaptionButtonProperty, ref _hasLeftCaptionButton, value);
-        }
-
         public bool HasRightCaptionButton
         {
             get
@@ -46,18 +35,11 @@ public bool HasRightCaptionButton
         public Launcher()
         {
             if (OperatingSystem.IsMacOS())
-            {
-                HasLeftCaptionButton = true;
                 CaptionHeight = new GridLength(34);
-            }
             else if (UseSystemWindowFrame)
-            {
                 CaptionHeight = new GridLength(30);
-            }
             else
-            {
                 CaptionHeight = new GridLength(38);
-            }
 
             InitializeComponent();
             PositionChanged += OnPositionChanged;
@@ -112,9 +94,7 @@ protected override void OnPropertyChanged(AvaloniaPropertyChangedEventArgs chang
                 var state = (WindowState)change.NewValue!;
                 _lastWindowState = (WindowState)change.OldValue!;
 
-                if (OperatingSystem.IsMacOS())
-                    HasLeftCaptionButton = state != WindowState.FullScreen;
-                else if (!UseSystemWindowFrame)
+                if (!OperatingSystem.IsMacOS() && !UseSystemWindowFrame)
                     CaptionHeight = new GridLength(state == WindowState.Maximized ? 30 : 38);
 
                 ViewModels.Preferences.Instance.Layout.LauncherWindowState = state;
@@ -125,7 +105,7 @@ protected override void OnPropertyChanged(AvaloniaPropertyChangedEventArgs chang
                     vm.CommandPalette = null;
             }
 
-            if (HasLeftCaptionButton && OperatingSystem.IsMacOS())
+            if (OperatingSystem.IsMacOS() && WindowState != WindowState.FullScreen)
             {
                 if (change.Property == WindowStateProperty ||
                     change.Property == BoundsProperty ||
@@ -444,7 +424,6 @@ private void OnCloseCommandPalette(object sender, PointerPressedEventArgs e)
         }
 
         private GridLength _captionHeight = new(32);
-        private bool _hasLeftCaptionButton = false;
         private WindowState _lastWindowState = WindowState.Normal;
     }
 }

src/Views/MacOSTrafficLightsSpacer.cs

@@ -45,9 +45,6 @@ protected override void OnPropertyChanged(AvaloniaPropertyChangedEventArgs chang
 
         protected override Size MeasureOverride(Size availableSize)
         {
-            if (!OperatingSystem.IsMacOS())
-                return new Size(0, 0);
-
             return _isFullScreen ? new Size(4, 24) : new Size(76.0 / Math.Max(_zoom, 1.0), 24.0);
         }