"Push all tags" checkbox hidden when pushing a specific branch (since #2281)

[JC-Chung]

Since commit 3f4f0ac9 (#2281), the "Push all tags" (--tags) checkbox is hidden whenever the Push dialog is opened for a specific branch (e.g. right-click → Push on a branch). It used to be always visible.

git push --tags <remote> <branch> is valid regardless of branch, so this seems unrelated to the pushRemote feature that commit was about.

Was hiding this checkbox intentional, or a side effect? It'd be nice to push all tags together with a specific branch again.

Related: src/Views/Push.axaml (IsVisible="{Binding !HasSpecifiedLocalBranch}"), src/ViewModels/Push.cs (HasSpecifiedLocalBranch).

[love-linger]

It was probably not well thought out at that time.

The original plan was to rewrite the Push feature at the same time, add support for the --branches parameter, and optimize the display logic of --tags and --branches. But later on, I realized that pushing all local branches could be misused by users (besides, tools like Fork do not offer such an option), so the idea was dropped.

This line was just forgotten to be removed.

[JC-Chung]

Got it, thanks for explaining and for the quick fix!

[love-linger]

I've pushed a new commit that will hide --tags option when:

[branch "some_pr"]
  remote = origin
  pushRemote = another_remote_not_added ; such as git@github.com:xxxx/xxx_fork.git
  merge = refs/heads/some_pr

Because the pushRemote of selected branch is a temp remote, push with all tags should be disabled.

[love-linger]