From 779f062e35e2664a30d89ae76019c90de9344dfa Mon Sep 17 00:00:00 2001
From: JC-Chung <52159296+JC-Chung@users.noreply.github.com>
Date: Mon, 27 Jul 2026 18:00:57 +0800
Subject: [PATCH 1/3] enhance: extract reusable CopyButton control with copy
 feedback

---
 src/Views/CommitBaseInfo.axaml    |   7 +-
 src/Views/CommitBaseInfo.axaml.cs |  63 ---------------
 src/Views/CopyButton.cs           | 124 ++++++++++++++++++++++++++++++
 src/Views/LauncherPage.axaml      |   4 +-
 src/Views/LauncherPage.axaml.cs   |   8 --
 5 files changed, 126 insertions(+), 80 deletions(-)
 create mode 100644 src/Views/CopyButton.cs

diff --git a/src/Views/CommitBaseInfo.axaml b/src/Views/CommitBaseInfo.axaml
index d848203cab..c8544db7f6 100644
--- a/src/Views/CommitBaseInfo.axaml
+++ b/src/Views/CommitBaseInfo.axaml
@@ -65,12 +65,7 @@
           <StackPanel Grid.Row="0" Grid.Column="1" Orientation="Horizontal" Height="24">
             <TextBlock Text="{Binding SHA}" Margin="12,0,4,0" FontFamily="{DynamicResource Fonts.Monospace}" VerticalAlignment="Center"/>
 
-            <Button Classes="icon_button" Width="24" Cursor="Hand" Click="OnCopyCommitSHA" ToolTip.Tip="{DynamicResource Text.Copy}">
-              <Grid>
-                <Path Width="12" Height="12" Data="{StaticResource Icons.Copy}" IsVisible="{Binding #ThisControl.IsSHACopied, Mode=OneWay, Converter={x:Static BoolConverters.Not}}"/>
-                <Path Width="14" Height="14" Margin="0,2,0,0" Data="{StaticResource Icons.Check}" Fill="Green" IsVisible="{Binding #ThisControl.IsSHACopied, Mode=OneWay}"/>
-              </Grid>
-            </Button>
+            <v:CopyButton Width="24" Cursor="Hand" CopyText="{Binding SHA}" ToolTip.Tip="{DynamicResource Text.Copy}"/>
 
             <Button Classes="icon_button" Width="24" Cursor="Hand" Click="OnOpenContainsIn" IsVisible="{Binding #ThisControl.SupportsContainsIn}" ToolTip.Tip="{DynamicResource Text.CommitDetail.Info.ContainsIn}">
               <Path Width="14" Height="14" Margin="0,1,0,0" Data="{StaticResource Icons.Milestone}"/>
diff --git a/src/Views/CommitBaseInfo.axaml.cs b/src/Views/CommitBaseInfo.axaml.cs
index fb6be7d02f..50809468de 100644
--- a/src/Views/CommitBaseInfo.axaml.cs
+++ b/src/Views/CommitBaseInfo.axaml.cs
@@ -5,7 +5,6 @@
 using Avalonia.Controls;
 using Avalonia.Input;
 using Avalonia.Interactivity;
-using Avalonia.Threading;
 
 namespace SourceGit.Views
 {
@@ -47,17 +46,6 @@ public List<Models.CommitLink> WebLinks
             set => SetAndRaise(WebLinksProperty, ref _webLinks, value);
         }
 
-        public static readonly DirectProperty<CommitBaseInfo, bool> IsSHACopiedProperty =
-            AvaloniaProperty.RegisterDirect<CommitBaseInfo, bool>(
-                nameof(IsSHACopied),
-                static o => o.IsSHACopied);
-
-        public bool IsSHACopied
-        {
-            get => _isSHACopied;
-            private set => SetAndRaise(IsSHACopiedProperty, ref _isSHACopied, value);
-        }
-
         public static readonly DirectProperty<CommitBaseInfo, bool> SupportsContainsInProperty =
             AvaloniaProperty.RegisterDirect<CommitBaseInfo, bool>(
                 nameof(SupportsContainsIn),
@@ -80,45 +68,6 @@ protected override void OnDataContextChanged(EventArgs e)
             SupportsContainsIn = DataContext is ViewModels.CommitDetail;
         }
 
-        protected override void OnPropertyChanged(AvaloniaPropertyChangedEventArgs change)
-        {
-            base.OnPropertyChanged(change);
-
-            if (change.Property == ContentProperty)
-            {
-                IsSHACopied = false;
-                _iconResetTimer?.Stop();
-            }
-        }
-
-        protected override void OnLoaded(RoutedEventArgs e)
-        {
-            base.OnLoaded(e);
-
-            _iconResetTimer = new DispatcherTimer();
-            _iconResetTimer.Interval = TimeSpan.FromSeconds(1);
-            _iconResetTimer.Tag = this;
-            _iconResetTimer.Tick += static (o, _) =>
-            {
-                if (o is DispatcherTimer { Tag: CommitBaseInfo view } timer)
-                {
-                    if (view.IsSHACopied)
-                        view.IsSHACopied = false;
-
-                    timer.IsEnabled = false;
-                }
-            };
-            _iconResetTimer.IsEnabled = false;
-        }
-
-        protected override void OnUnloaded(RoutedEventArgs e)
-        {
-            _iconResetTimer.Tag = null;
-            _iconResetTimer.IsEnabled = false;
-
-            base.OnUnloaded(e);
-        }
-
         private void OnDateTimeContextMenuRequested(object sender, ContextRequestedEventArgs e)
         {
             if (sender is DateTimePresenter presenter)
@@ -139,16 +88,6 @@ private void OnDateTimeContextMenuRequested(object sender, ContextRequestedEvent
             }
         }
 
-        private async void OnCopyCommitSHA(object sender, RoutedEventArgs e)
-        {
-            if (sender is Button { DataContext: Models.Commit commit })
-                await this.CopyTextAsync(commit.SHA);
-
-            IsSHACopied = true;
-            _iconResetTimer?.Start();
-            e.Handled = true;
-        }
-
         private void OnOpenWebLink(object sender, RoutedEventArgs e)
         {
             if (DataContext is ViewModels.CommitDetail detail && sender is Control control)
@@ -323,7 +262,5 @@ sender is CommitRefsPresenter presenter &&
         private Models.CommitSignInfo _signInfo = null;
         private bool _supportsContainsIn = false;
         private List<Models.CommitLink> _webLinks = null;
-        private bool _isSHACopied = false;
-        private DispatcherTimer _iconResetTimer = null;
     }
 }
diff --git a/src/Views/CopyButton.cs b/src/Views/CopyButton.cs
new file mode 100644
index 0000000000..996bcfb57d
--- /dev/null
+++ b/src/Views/CopyButton.cs
@@ -0,0 +1,124 @@
+using System;
+
+using Avalonia;
+using Avalonia.Controls;
+using Avalonia.Controls.Shapes;
+using Avalonia.Interactivity;
+using Avalonia.Media;
+using Avalonia.Threading;
+
+namespace SourceGit.Views
+{
+    public class CopyButton : Button
+    {
+        protected override Type StyleKeyOverride => typeof(Button);
+
+        public static readonly StyledProperty<string> CopyTextProperty =
+            AvaloniaProperty.Register<CopyButton, string>(nameof(CopyText), string.Empty);
+
+        public string CopyText
+        {
+            get => GetValue(CopyTextProperty);
+            set => SetValue(CopyTextProperty, value);
+        }
+
+        public static readonly DirectProperty<CopyButton, bool> IsCopiedProperty =
+            AvaloniaProperty.RegisterDirect<CopyButton, bool>(
+                nameof(IsCopied),
+                static o => o.IsCopied);
+
+        public bool IsCopied
+        {
+            get => _isCopied;
+            private set => SetAndRaise(IsCopiedProperty, ref _isCopied, value);
+        }
+
+        public CopyButton()
+        {
+            Classes.Add("icon_button");
+
+            _copyIcon = new Path() { Width = 12, Height = 12 };
+            _checkIcon = new Path()
+            {
+                Width = 14,
+                Height = 14,
+                Margin = new Thickness(0, 2, 0, 0),
+                Fill = Brushes.Green,
+                IsVisible = false,
+            };
+
+            var grid = new Grid();
+            grid.Children.Add(_copyIcon);
+            grid.Children.Add(_checkIcon);
+            Content = grid;
+        }
+
+        protected override void OnLoaded(RoutedEventArgs e)
+        {
+            base.OnLoaded(e);
+
+            if (this.FindResource("Icons.Copy") is Geometry copyGeo)
+                _copyIcon.Data = copyGeo;
+            if (this.FindResource("Icons.Check") is Geometry checkGeo)
+                _checkIcon.Data = checkGeo;
+
+            _resetTimer = new DispatcherTimer();
+            _resetTimer.Interval = TimeSpan.FromSeconds(1);
+            _resetTimer.Tag = this;
+            _resetTimer.Tick += static (o, _) =>
+            {
+                if (o is DispatcherTimer { Tag: CopyButton btn } timer)
+                {
+                    btn.IsCopied = false;
+                    timer.IsEnabled = false;
+                }
+            };
+            _resetTimer.IsEnabled = false;
+        }
+
+        protected override void OnUnloaded(RoutedEventArgs e)
+        {
+            if (_resetTimer != null)
+            {
+                _resetTimer.Tag = null;
+                _resetTimer.IsEnabled = false;
+            }
+
+            base.OnUnloaded(e);
+        }
+
+        protected override void OnPropertyChanged(AvaloniaPropertyChangedEventArgs change)
+        {
+            base.OnPropertyChanged(change);
+
+            if (change.Property == IsCopiedProperty)
+            {
+                _copyIcon.IsVisible = !_isCopied;
+                _checkIcon.IsVisible = _isCopied;
+            }
+            else if (change.Property == CopyTextProperty)
+            {
+                // Reset the copied state when CopyText changes (e.g. switching to a different commit)
+                IsCopied = false;
+                _resetTimer?.Stop();
+            }
+        }
+
+        protected override async void OnClick()
+        {
+            base.OnClick();
+
+            var text = CopyText;
+            if (!string.IsNullOrEmpty(text))
+                await this.CopyTextAsync(text);
+
+            IsCopied = true;
+            _resetTimer?.Start();
+        }
+
+        private readonly Path _copyIcon;
+        private readonly Path _checkIcon;
+        private bool _isCopied = false;
+        private DispatcherTimer _resetTimer = null;
+    }
+}
diff --git a/src/Views/LauncherPage.axaml b/src/Views/LauncherPage.axaml
index d21ff744b7..3a1af0b8ca 100644
--- a/src/Views/LauncherPage.axaml
+++ b/src/Views/LauncherPage.axaml
@@ -166,9 +166,7 @@
                         <Path Grid.Column="0" Width="14" Height="14" Data="{StaticResource Icons.Info}" Fill="Green" IsVisible="{Binding !IsError}"/>
                         <TextBlock Grid.Column="1" Margin="8,0,0,0" FontWeight="Bold" FontSize="14" Text="{DynamicResource Text.Launcher.Error}" IsVisible="{Binding IsError}"/>
                         <TextBlock Grid.Column="1" Margin="8,0,0,0" FontWeight="Bold" FontSize="14" Text="{DynamicResource Text.Launcher.Info}" IsVisible="{Binding !IsError}"/>
-                        <Button Grid.Column="2" Classes="icon_button" Width="16" Height="16" Click="OnCopyNotification">
-                          <Path Width="12" Height="12" Data="{StaticResource Icons.Copy}"/>
-                        </Button>
+                        <v:CopyButton Grid.Column="2" Width="16" Height="16" CopyText="{Binding Message}"/>
                         <Button Grid.Column="3" Classes="icon_button" Width="16" Height="16" Margin="8,0,0,0" Click="OnDismissNotification">
                           <Path Width="10" Height="10" Data="{StaticResource Icons.Close}"/>
                         </Button>
diff --git a/src/Views/LauncherPage.axaml.cs b/src/Views/LauncherPage.axaml.cs
index 88270a5ad3..8981a86c29 100644
--- a/src/Views/LauncherPage.axaml.cs
+++ b/src/Views/LauncherPage.axaml.cs
@@ -72,14 +72,6 @@ private void OnMaskClicked(object sender, PointerPressedEventArgs e)
             OnPopupCancel(sender, e);
         }
 
-        private async void OnCopyNotification(object sender, RoutedEventArgs e)
-        {
-            if (sender is Button { DataContext: Models.Notification notice })
-                await this.CopyTextAsync(notice.Message);
-
-            e.Handled = true;
-        }
-
         private void OnDismissNotification(object sender, RoutedEventArgs e)
         {
             if (sender is Button { DataContext: Models.Notification notice } &&

From 5f464fb16c2bdb1dadca917c0e213d5bd136bc41 Mon Sep 17 00:00:00 2001
From: JC-Chung <52159296+JC-Chung@users.noreply.github.com>
Date: Tue, 1 Sep 2026 12:28:38 +0800
Subject: [PATCH 2/3] fix: `CopyButton` should not show copied feedback when
 `CopyText` is empty

---
 src/Views/CopyButton.cs | 13 +++++--------
 1 file changed, 5 insertions(+), 8 deletions(-)

diff --git a/src/Views/CopyButton.cs b/src/Views/CopyButton.cs
index 996bcfb57d..9922005c2f 100644
--- a/src/Views/CopyButton.cs
+++ b/src/Views/CopyButton.cs
@@ -78,12 +78,8 @@ protected override void OnLoaded(RoutedEventArgs e)
 
         protected override void OnUnloaded(RoutedEventArgs e)
         {
-            if (_resetTimer != null)
-            {
-                _resetTimer.Tag = null;
-                _resetTimer.IsEnabled = false;
-            }
-
+            _resetTimer.Tag = null;
+            _resetTimer.IsEnabled = false;
             base.OnUnloaded(e);
         }
 
@@ -109,9 +105,10 @@ protected override async void OnClick()
             base.OnClick();
 
             var text = CopyText;
-            if (!string.IsNullOrEmpty(text))
-                await this.CopyTextAsync(text);
+            if (string.IsNullOrEmpty(text))
+                return;
 
+            await this.CopyTextAsync(text);
             IsCopied = true;
             _resetTimer?.Start();
         }

From 3ec0672cc75252a6016ba2fde5ffe415580b974b Mon Sep 17 00:00:00 2001
From: JC-Chung <52159296+JC-Chung@users.noreply.github.com>
Date: Tue, 1 Sep 2026 12:29:33 +0800
Subject: [PATCH 3/3] code_style: use `DirectProperty` for `CopyText` in
 `CopyButton`

---
 src/Views/CopyButton.cs | 12 ++++++++----
 1 file changed, 8 insertions(+), 4 deletions(-)

diff --git a/src/Views/CopyButton.cs b/src/Views/CopyButton.cs
index 9922005c2f..0ce7908491 100644
--- a/src/Views/CopyButton.cs
+++ b/src/Views/CopyButton.cs
@@ -13,13 +13,16 @@ public class CopyButton : Button
     {
         protected override Type StyleKeyOverride => typeof(Button);
 
-        public static readonly StyledProperty<string> CopyTextProperty =
-            AvaloniaProperty.Register<CopyButton, string>(nameof(CopyText), string.Empty);
+        public static readonly DirectProperty<CopyButton, string> CopyTextProperty =
+            AvaloniaProperty.RegisterDirect<CopyButton, string>(
+                nameof(CopyText),
+                static o => o.CopyText,
+                static (o, v) => o.CopyText = v);
 
         public string CopyText
         {
-            get => GetValue(CopyTextProperty);
-            set => SetValue(CopyTextProperty, value);
+            get => _copyText;
+            set => SetAndRaise(CopyTextProperty, ref _copyText, value);
         }
 
         public static readonly DirectProperty<CopyButton, bool> IsCopiedProperty =
@@ -115,6 +118,7 @@ protected override async void OnClick()
 
         private readonly Path _copyIcon;
         private readonly Path _checkIcon;
+        private string _copyText = string.Empty;
         private bool _isCopied = false;
         private DispatcherTimer _resetTimer = null;
     }