From 1b05abd8273a46b338079ec62c8c2e7c12f54b75 Mon Sep 17 00:00:00 2001
From: ankitjain <ankit.jain@uipath.com>
Date: Mon, 12 Oct 2026 12:05:23 -0700
Subject: [PATCH] Write `.` for an empty package.json name or version

A package.json with `"name": ""` or `"version": ""` made scip-typescript
write an empty package field, for example
`scip-typescript npm  1.0.0 src/`main.ts`/main().`. The SCIP grammar reads
a double space as an escaped space, so SCIP consumers misparse every
symbol in that package. scip-to-glean, for example, stores an empty
symbol name for each one.

ScipSymbol.package now writes `.` for an empty field, as the SCIP spec
requires. A package.json without a name already gave `. .`.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
---
 snapshots/input/empty-package-fields/package.json         | 6 ++++++
 snapshots/input/empty-package-fields/src/main.ts          | 3 +++
 snapshots/input/empty-package-fields/src/version/lib.ts   | 3 +++
 .../input/empty-package-fields/src/version/package.json   | 4 ++++
 snapshots/output/empty-package-fields/src/main.ts         | 8 ++++++++
 snapshots/output/empty-package-fields/src/version/lib.ts  | 8 ++++++++
 src/ScipSymbol.ts                                         | 6 +++++-
 7 files changed, 37 insertions(+), 1 deletion(-)
 create mode 100644 snapshots/input/empty-package-fields/package.json
 create mode 100644 snapshots/input/empty-package-fields/src/main.ts
 create mode 100644 snapshots/input/empty-package-fields/src/version/lib.ts
 create mode 100644 snapshots/input/empty-package-fields/src/version/package.json
 create mode 100644 snapshots/output/empty-package-fields/src/main.ts
 create mode 100644 snapshots/output/empty-package-fields/src/version/lib.ts

diff --git a/snapshots/input/empty-package-fields/package.json b/snapshots/input/empty-package-fields/package.json
new file mode 100644
index 00000000..b59977dc
--- /dev/null
+++ b/snapshots/input/empty-package-fields/package.json
@@ -0,0 +1,6 @@
+{
+  "name": "",
+  "version": "1.0.0",
+  "description": "Example TS/JS project with an empty package name",
+  "private": true
+}
diff --git a/snapshots/input/empty-package-fields/src/main.ts b/snapshots/input/empty-package-fields/src/main.ts
new file mode 100644
index 00000000..ada3e96a
--- /dev/null
+++ b/snapshots/input/empty-package-fields/src/main.ts
@@ -0,0 +1,3 @@
+export function main(): string {
+  return ''
+}
diff --git a/snapshots/input/empty-package-fields/src/version/lib.ts b/snapshots/input/empty-package-fields/src/version/lib.ts
new file mode 100644
index 00000000..746b094a
--- /dev/null
+++ b/snapshots/input/empty-package-fields/src/version/lib.ts
@@ -0,0 +1,3 @@
+export function lib(): string {
+  return ''
+}
diff --git a/snapshots/input/empty-package-fields/src/version/package.json b/snapshots/input/empty-package-fields/src/version/package.json
new file mode 100644
index 00000000..caa280a2
--- /dev/null
+++ b/snapshots/input/empty-package-fields/src/version/package.json
@@ -0,0 +1,4 @@
+{
+  "name": "empty-version",
+  "version": ""
+}
diff --git a/snapshots/output/empty-package-fields/src/main.ts b/snapshots/output/empty-package-fields/src/main.ts
new file mode 100644
index 00000000..c5cbbcbb
--- /dev/null
+++ b/snapshots/output/empty-package-fields/src/main.ts
@@ -0,0 +1,8 @@
+// language TypeScript
+// < definition . 1.0.0 src/`main.ts`/
+
+export function main(): string {
+//              ^^^^ definition . 1.0.0 src/`main.ts`/main().
+  return ''
+}
+
diff --git a/snapshots/output/empty-package-fields/src/version/lib.ts b/snapshots/output/empty-package-fields/src/version/lib.ts
new file mode 100644
index 00000000..243c0857
--- /dev/null
+++ b/snapshots/output/empty-package-fields/src/version/lib.ts
@@ -0,0 +1,8 @@
+// language TypeScript
+// < definition empty-version . `lib.ts`/
+
+export function lib(): string {
+//              ^^^ definition empty-version . `lib.ts`/lib().
+  return ''
+}
+
diff --git a/src/ScipSymbol.ts b/src/ScipSymbol.ts
index 9d8d75a0..a52d4a62 100644
--- a/src/ScipSymbol.ts
+++ b/src/ScipSymbol.ts
@@ -24,7 +24,11 @@ export class ScipSymbol {
   }
 
   public static package(name: string, version: string): ScipSymbol {
-    return new ScipSymbol(`scip-typescript npm ${name} ${version} `)
+    // SCIP spells an empty package field as `.`, because a double space is an
+    // escaped space.
+    return new ScipSymbol(
+      `scip-typescript npm ${name || '.'} ${version || '.'} `
+    )
   }
 
   public static anonymousPackage(): ScipSymbol {