Fix Tween.tween() and autoStart

[azrafe7]

Adding the issue as it has re-bubbled up lately on the forums (http://developers.useflashpunk.net/t/knockback-with-numtween/1015).

Not sure how to exactly address this, but it seems inconsistent behaviour and I think it should be fixed in some way.

[jacobalbano]

Is there any reason for tween() to be calling start() at all? It seems like the only thing it does that matters is initialize _time to 0.

If not, can't we just remove that first call?

[azrafe7]

@jacobalbano: The doubt I had is that calling tween() would indeed scream for "hey! Let it start NOW!", but then there's an addTween() method that doesn't play nice with it.

Maybe an extra param to tween() to autostart it? or a different constructor to accept setting params? change addTween()? force the user to call start()? I really don't know... Thoughts?

[jacobalbano]

Well, addTween() already takes a parameter (bool autoStart) to start the tween you're adding. Currently the only tween class that actually puts it to good use is Alarm.

[azrafe7]

So the suggested thing would be to remove start() from tween() right?

I agree, but would also propose to have a way to pass specific tween parameters in the constructor and/or make tween() return the Tween itself so we can do:

var numTween:NumTween = new NumTween(onComplete, ONESHOT);
add(numTween);
...
numTween.tween(...).start();

Feasible?

[jacobalbano]

I like the idea of making tween() return the Tween. That's something I've wished I could do for a while. It would make it much simpler to fire off a bunch of quick tweens without having to make a lot of variables.