fix: enforce strict CLI warning policy

Author: GaspardKirira

CMakeLists.txt

@@ -146,29 +146,21 @@ function(vix_add_flag_if_supported tgt flag)
   endif()
 endfunction()
 
-if (MSVC)
-  vix_add_flag_if_supported(vix_cli /W4)
-  vix_add_flag_if_supported(vix_cli /permissive-)
-  vix_add_flag_if_supported(vix_installer /W4)
-  vix_add_flag_if_supported(vix_installer /permissive-)
-  vix_add_flag_if_supported(vix_release_tool /W4)
-  vix_add_flag_if_supported(vix_release_tool /permissive-)
-else()
-  vix_add_flag_if_supported(vix_cli -Wall)
-  vix_add_flag_if_supported(vix_cli -Wextra)
-  vix_add_flag_if_supported(vix_cli -Wshadow)
-  vix_add_flag_if_supported(vix_cli -Wconversion)
-  vix_add_flag_if_supported(vix_cli -Wformat=2)
-  vix_add_flag_if_supported(vix_cli -Wpedantic)
-  foreach(_distribution_tool vix_installer vix_release_tool)
-    vix_add_flag_if_supported(${_distribution_tool} -Wall)
-    vix_add_flag_if_supported(${_distribution_tool} -Wextra)
-    vix_add_flag_if_supported(${_distribution_tool} -Wshadow)
-    vix_add_flag_if_supported(${_distribution_tool} -Wconversion)
-    vix_add_flag_if_supported(${_distribution_tool} -Wformat=2)
-    vix_add_flag_if_supported(${_distribution_tool} -Wpedantic)
-  endforeach()
-endif()
+function(vix_enable_cli_warnings tgt)
+  if (MSVC)
+    foreach(_flag /W4 /WX /permissive-)
+      vix_add_flag_if_supported("${tgt}" "${_flag}")
+    endforeach()
+  else()
+    foreach(_flag -Wall -Wextra -Wshadow -Wconversion -Wformat=2 -Wpedantic -Werror)
+      vix_add_flag_if_supported("${tgt}" "${_flag}")
+    endforeach()
+  endif()
+endfunction()
+
+vix_enable_cli_warnings(vix_cli)
+vix_enable_cli_warnings(vix_installer)
+vix_enable_cli_warnings(vix_release_tool)
 
 # ----------------------------------------------------
 # Dependency resolution helpers

tests/CMakeLists.txt

@@ -1141,3 +1141,12 @@ add_test(NAME vix_cli_run_execution_paths_contract
 add_test(NAME vix_cli_run_compiled_dependency_contract
   COMMAND bash ${CMAKE_CURRENT_SOURCE_DIR}/contracts/run/RunCompiledDependencyContractTest.sh ${CMAKE_BINARY_DIR}/vix)
 set_tests_properties(vix_cli_run_cache_contract vix_cli_build_passthrough_contract PROPERTIES LABELS "contract")
+
+# All C++ executables defined by this test directory are Vix-owned contract or
+# unit tests. Apply the same strict diagnostics as the CLI and release tools.
+get_property(_vix_cli_test_targets DIRECTORY PROPERTY BUILDSYSTEM_TARGETS)
+foreach(_vix_cli_test_target IN LISTS _vix_cli_test_targets)
+  if (_vix_cli_test_target MATCHES "^vix_cli_")
+    vix_enable_cli_warnings("${_vix_cli_test_target}")
+  endif()
+endforeach()

tests/TestsCommandContractCliTest.sh

@@ -23,20 +23,46 @@ add_test(NAME network.alpha COMMAND test_fixture)
 set_tests_properties(network.alpha PROPERTIES LABELS "integration")
 add_test(NAME networkXalpha COMMAND test_fixture)
 add_test(NAME Network.alpha COMMAND test_fixture)
+add_executable(failure_fixture failure.cpp)
+add_test(NAME failure.case COMMAND failure_fixture)
 CMAKE
 cat >"$PROJECT/main.cpp" <<'CPP'
 int main() { return 0; }
 CPP
+cat >"$PROJECT/failure.cpp" <<'CPP'
+#include <iostream>
+int main() { std::cout << "CTEST_FAILURE_MARKER\n"; return 23; }
+CPP
 
 FILTER_OUT="$("$VIX_BIN" test --dir "$PROJECT" 'network.')" || fail "literal test filter failed"
 grep -Fq 'network.alpha' <<<"$FILTER_OUT" || fail "literal filter omitted matching registration"
 if grep -Fq 'networkXalpha' <<<"$FILTER_OUT"; then fail "filter treated dot as a regex wildcard"; fi
 if grep -Fq 'Network.alpha' <<<"$FILTER_OUT"; then fail "filter was not case-sensitive"; fi
+if grep -Eiq 'ninja:|no work to do|Building CXX object|Linking CXX|Configuring done|Generating done|cmake --build' <<<"$FILTER_OUT"; then
+  fail "successful external test build exposed backend chatter"
+fi
+
+LIST_OUT="$("$VIX_BIN" test --dir "$PROJECT" --list)" || fail "--list failed"
+for test_name in network.alpha networkXalpha Network.alpha; do
+  grep -Fq "$test_name" <<<"$LIST_OUT" || fail "--list omitted registered test: $test_name"
+done
+if grep -Fq '100% tests passed' <<<"$LIST_OUT"; then
+  fail "--list ran tests instead of listing registrations"
+fi
 
 CTEST_OUT="$("$VIX_BIN" test --dir "$PROJECT" --ctest -L integration -N)" || fail "terminal CTest forwarding failed"
 grep -Fq 'network.alpha' <<<"$CTEST_OUT" || fail "CTest label argument was not forwarded"
 if grep -Fq 'networkXalpha' <<<"$CTEST_OUT"; then fail "CTest label filter was not applied"; fi
 
+if CTEST_FAILURE_OUT="$("$VIX_BIN" test --dir "$PROJECT" --ctest -R '^failure\.case$' 2>&1)"; then
+  fail "failing CTest case unexpectedly succeeded through --ctest"
+else
+  CTEST_FAILURE_STATUS=$?
+fi
+[[ "$CTEST_FAILURE_STATUS" -ne 0 ]] || fail "failing CTest case lost its non-zero exit status"
+grep -Fq 'CTEST_FAILURE_MARKER' <<<"$CTEST_FAILURE_OUT" ||
+  fail "--ctest did not preserve failing test output"
+
 assert_parse_rejected() {
   local expected="$1"
   shift