Repository navigation
Commit 1001eab
committed
fix: two real CORS/Content-Type bugs found by live-testing the admin console
Found by actually running the server + admin console through a real
browser session for the first time — neither bug was visible to any
existing test, since app.inject()-based integration tests bypass CORS
entirely and admin-console unit tests mock fetch directly.
1. @fastify/cors defaults to methods: GET,HEAD,POST only. Every PUT/
PATCH/DELETE call the admin console makes — quota saves, break-glass
policy, user/group/policy/service-principal updates, policy/
invitation deletes — was silently failing CORS preflight from a real
browser. Fixed by passing an explicit methods list.
2. authorizedRequest() unconditionally set Content-Type: application/json
even on bodyless POST calls (activateComputePolicy,
createAccessReviewCampacampaign, verifyAiInferenceDeployment). Fastify
correctly 400s an empty body declared as JSON. Fixed to only set the
header when a body is actually present, matching the pattern already
used correctly in the desktop app's own shared-backend-client.ts.
Both verified end-to-end against a real server (in-memory stores, a
throwaway fake OIDC provider) through an actual browser session — a real
OAuth login, a real signed compute-policy created via
server/scripts/sign-compute-policy.js and activated, a real quota save —
not just re-run against the existing test suite. Added regression tests
for both (CORS preflight methods, bodyless-POST headers) so neither can
regress silently again.1 parent 1085880 commit 1001eab
4 files changed
Lines changed: 62 additions & 5 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
20 | 20 | | |
21 | 21 | | |
22 | 22 | | |
| 23 | + | |
23 | 24 | | |
24 | 25 | | |
25 | 26 | | |
| |||
81 | 82 | | |
82 | 83 | | |
83 | 84 | | |
| 85 | + | |
| 86 | + | |
| 87 | + | |
| 88 | + | |
| 89 | + | |
| 90 | + | |
| 91 | + | |
| 92 | + | |
| 93 | + | |
| 94 | + | |
| 95 | + | |
| 96 | + | |
| 97 | + | |
| 98 | + | |
84 | 99 | | |
85 | 100 | | |
86 | 101 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
41 | 41 | | |
42 | 42 | | |
43 | 43 | | |
44 | | - | |
45 | | - | |
46 | | - | |
47 | | - | |
| 44 | + | |
| 45 | + | |
| 46 | + | |
| 47 | + | |
| 48 | + | |
| 49 | + | |
| 50 | + | |
| 51 | + | |
| 52 | + | |
| 53 | + | |
| 54 | + | |
| 55 | + | |
| 56 | + | |
| 57 | + | |
48 | 58 | | |
49 | 59 | | |
50 | 60 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
3470 | 3470 | | |
3471 | 3471 | | |
3472 | 3472 | | |
| 3473 | + | |
| 3474 | + | |
| 3475 | + | |
| 3476 | + | |
| 3477 | + | |
| 3478 | + | |
| 3479 | + | |
| 3480 | + | |
| 3481 | + | |
| 3482 | + | |
| 3483 | + | |
| 3484 | + | |
| 3485 | + | |
| 3486 | + | |
| 3487 | + | |
| 3488 | + | |
| 3489 | + | |
| 3490 | + | |
| 3491 | + | |
| 3492 | + | |
| 3493 | + | |
3473 | 3494 | | |
3474 | 3495 | | |
3475 | 3496 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
295 | 295 | | |
296 | 296 | | |
297 | 297 | | |
298 | | - | |
| 298 | + | |
| 299 | + | |
| 300 | + | |
| 301 | + | |
| 302 | + | |
| 303 | + | |
| 304 | + | |
| 305 | + | |
| 306 | + | |
| 307 | + | |
| 308 | + | |
| 309 | + | |
299 | 310 | | |
300 | 311 | | |
301 | 312 | | |
| |||
0 commit comments