Repository navigation
Commit 41090fd
fix(ci): sbom job never installed @modelforge/contracts's own dependencies
Root-caused from the real CI log (npm ls --all failing with
ELSPROBLEMS: missing typescript/zod required by
contracts@npm:@modelforge/contracts, plus a handful of extraneous
@emnapi/@napi-rs/@tybys packages as a downstream symptom) and
reproduced exactly, byte for byte, locally: frontend/ and app/ both
depend on packages/contracts via file:../packages/contracts, which
npm ci only symlinks into their own node_modules -- it never installs
*that* package's own dependencies, since this repo uses plain file:
references rather than true npm workspaces. cyclonedx-npm shells out
to npm ls --all, which walks into the symlink and reports it broken
whenever packages/contracts/node_modules is empty -- exactly what the
sbom job's steps left it as, unlike test/server/e2e which already
gained an equivalent install step in an earlier fix.
Added the same 'install @modelforge/contracts's own deps' step here.
Verified locally: removed packages/contracts/node_modules entirely,
reproduced the identical ELSPROBLEMS output CI showed, then confirmed
both frontend's and app's SBOM generation succeed cleanly (exit 0,
zero warnings) once that install step runs.
Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>1 parent 2288c34 commit 41090fd
1 file changed
Lines changed: 16 additions & 0 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
430 | 430 | | |
431 | 431 | | |
432 | 432 | | |
| 433 | + | |
433 | 434 | | |
434 | 435 | | |
435 | 436 | | |
436 | 437 | | |
| 438 | + | |
| 439 | + | |
| 440 | + | |
| 441 | + | |
| 442 | + | |
| 443 | + | |
| 444 | + | |
| 445 | + | |
| 446 | + | |
| 447 | + | |
| 448 | + | |
| 449 | + | |
| 450 | + | |
| 451 | + | |
| 452 | + | |
437 | 453 | | |
438 | 454 | | |
439 | 455 | | |
| |||
0 commit comments