Skip to content

Commit b7f33d0

Browse files
committed
bench: follow Vortex benchmark conventions
1 parent 35713eb commit b7f33d0

1 file changed

Lines changed: 16 additions & 17 deletions

File tree

vortex/benches/single_encoding_throughput.rs

Lines changed: 16 additions & 17 deletions
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,6 @@
44
#![expect(clippy::unwrap_used)]
55
#![expect(clippy::cast_possible_truncation)]
66

7-
use std::hint::black_box;
87
use std::sync::LazyLock;
98

109
use divan::Bencher;
@@ -41,7 +40,8 @@ use vortex::encodings::zigzag::zigzag_encode;
4140
use vortex::encodings::zstd::Zstd;
4241
use vortex::encodings::zstd::ZstdData;
4342
use vortex_array::VortexSessionExecute;
44-
use vortex_buffer::{BitBuffer, BitBufferMut};
43+
use vortex_buffer::BitBuffer;
44+
use vortex_buffer::BitBufferMut;
4545
use vortex_error::VortexResult;
4646
use vortex_sequence::Sequence;
4747
use vortex_session::VortexSession;
@@ -57,7 +57,6 @@ fn main() {
5757
}
5858

5959
const NUM_VALUES: u64 = 100_000;
60-
const SEQUENCE_COMPARE_LENGTHS: [usize; 3] = [1_000, 100_000, 1_000_000];
6160

6261
// Helper function to conditionally add counter based on codspeed cfg
6362
fn with_byte_counter<'a, 'b>(bencher: Bencher<'a, 'b>, bytes: u64) -> Bencher<'a, 'b> {
@@ -275,22 +274,22 @@ fn bench_sequence_decompress_u32(bencher: Bencher) {
275274
.bench_refs(|(a, ctx)| canonicalize((**a).clone(), ctx));
276275
}
277276

278-
#[divan::bench(args = SEQUENCE_COMPARE_LENGTHS)]
279-
fn bench_sequence_compare_match_from_iter(bencher: Bencher, len: usize) {
280-
let set_idx = len / 2;
281-
bencher.bench(|| {
282-
black_box(BitBuffer::from_iter((0..len).map(|idx| idx == set_idx)));
283-
});
277+
#[divan::bench]
278+
fn bench_sequence_compare_match_from_iter(bencher: Bencher) {
279+
bencher
280+
.with_inputs(|| (NUM_VALUES as usize, NUM_VALUES as usize / 2))
281+
.bench_values(|(len, set_idx)| BitBuffer::from_iter((0..len).map(|idx| idx == set_idx)));
284282
}
285283

286-
#[divan::bench(args = SEQUENCE_COMPARE_LENGTHS)]
287-
fn bench_sequence_compare_match_single_set(bencher: Bencher, len: usize) {
288-
let set_idx = len / 2;
289-
bencher.bench(|| {
290-
let mut buffer = BitBufferMut::new_unset(len);
291-
buffer.set(set_idx);
292-
black_box(buffer.freeze());
293-
});
284+
#[divan::bench]
285+
fn bench_sequence_compare_match_single_set(bencher: Bencher) {
286+
bencher
287+
.with_inputs(|| (NUM_VALUES as usize, NUM_VALUES as usize / 2))
288+
.bench_values(|(len, set_idx)| {
289+
let mut buffer = BitBufferMut::new_unset(len);
290+
buffer.set(set_idx);
291+
buffer.freeze()
292+
});
294293
}
295294

296295
#[divan::bench(name = "alp_compress_f64")]

0 commit comments

Comments
 (0)