From b7d56491b1cc7f4b22232d916572117731c2dd83 Mon Sep 17 00:00:00 2001 From: anubhavaanand Date: Wed, 11 Nov 2026 22:45:14 +0530 Subject: [PATCH] test: cover RuleLogic edge cases --- .../java/com/endroid/latch/RuleLogicTest.kt | 109 ++++++++++++++++++ 1 file changed, 109 insertions(+) diff --git a/app/src/test/java/com/endroid/latch/RuleLogicTest.kt b/app/src/test/java/com/endroid/latch/RuleLogicTest.kt index 2753f13..900b6bb 100644 --- a/app/src/test/java/com/endroid/latch/RuleLogicTest.kt +++ b/app/src/test/java/com/endroid/latch/RuleLogicTest.kt @@ -19,6 +19,51 @@ class RuleLogicTest { assertFalse(RuleLogic.batteryAbove(10, 20)) } + @Test fun batteryThresholdZero() { + assertTrue(RuleLogic.batteryBelow(0, 0)) + assertFalse(RuleLogic.batteryBelow(1, 0)) + assertTrue(RuleLogic.batteryAbove(0, 0)) + } + + @Test fun batteryThresholdHundred() { + assertTrue(RuleLogic.batteryBelow(100, 100)) + assertTrue(RuleLogic.batteryAbove(100, 100)) + assertFalse(RuleLogic.batteryAbove(99, 100)) + } + + @Test fun batteryFirstRunUnknownPreviousFires() { + assertTrue( + RuleLogic.shouldFireBattery( + prevPercent = -1, percent = 80, threshold = 90, + below = true, latched = true, force = false, + ), + ) + assertTrue( + RuleLogic.shouldFireBattery( + prevPercent = -1, percent = 100, threshold = 100, + below = false, latched = true, force = false, + ), + ) + } + + @Test fun batteryCrossesZeroThreshold() { + assertTrue( + RuleLogic.shouldFireBattery( + prevPercent = 1, percent = 0, threshold = 0, + below = true, latched = true, force = false, + ), + ) + } + + @Test fun batteryCrossesHundredThreshold() { + assertTrue( + RuleLogic.shouldFireBattery( + prevPercent = 99, percent = 100, threshold = 100, + below = false, latched = true, force = false, + ), + ) + } + @Test fun fireOnForceEvenIfLatched() { assertTrue( RuleLogic.shouldFireBattery( @@ -61,6 +106,30 @@ class RuleLogicTest { assertFalse(RuleLogic.ssidMatches(null, "Home")) } + @Test fun ssidBlankPatternOrCurrentDoesNotMatch() { + assertFalse(RuleLogic.ssidMatches("Home", "")) + assertFalse(RuleLogic.ssidMatches("Home", " ")) + assertFalse(RuleLogic.ssidMatches(null, "Home")) + assertFalse(RuleLogic.ssidMatches("", "Home")) + } + + @Test fun ssidCaseInsensitive() { + assertTrue(RuleLogic.ssidMatches("Home", "hOmE")) + assertTrue(RuleLogic.ssidMatches("\"Home\"", "\"HOME\"")) + } + + @Test fun ssidQuotesAreTrimmed() { + assertTrue(RuleLogic.ssidMatches("\"Home\"", "Home")) + assertTrue(RuleLogic.ssidMatches("Home", "\"Home\"")) + assertTrue(RuleLogic.ssidMatches("\"Home\"", "\"home\"")) + } + + @Test fun ssidSpacesArePartOfTheName() { + assertTrue(RuleLogic.ssidMatches("Home Office", "home office")) + assertFalse(RuleLogic.ssidMatches(" Home", "Home")) + assertFalse(RuleLogic.ssidMatches("Home ", "Home")) + } + @Test fun timeWindowNormal() { assertTrue(RuleLogic.inTimeWindow(10 * 60, 9 * 60, 12 * 60)) assertFalse(RuleLogic.inTimeWindow(8 * 60, 9 * 60, 12 * 60)) @@ -72,6 +141,24 @@ class RuleLogicTest { assertFalse(RuleLogic.inTimeWindow(12 * 60, 22 * 60, 2 * 60)) } + @Test fun timeWindowStartEqualsEndIsOneMinute() { + // Bounds are inclusive, so start == end covers that single minute. + assertTrue(RuleLogic.inTimeWindow(10 * 60, 10 * 60, 10 * 60)) + assertFalse(RuleLogic.inTimeWindow(10 * 60 + 1, 10 * 60, 10 * 60)) + } + + @Test fun timeWindowEndingAtMidnight() { + assertTrue(RuleLogic.inTimeWindow(23 * 60 + 30, 23 * 60, 0)) + assertTrue(RuleLogic.inTimeWindow(0, 23 * 60, 0)) + assertFalse(RuleLogic.inTimeWindow(1, 23 * 60, 0)) + } + + @Test fun timeWindow23_59ToMidnight() { + assertTrue(RuleLogic.inTimeWindow(23 * 60 + 59, 23 * 60 + 59, 0)) + assertTrue(RuleLogic.inTimeWindow(0, 23 * 60 + 59, 0)) + assertFalse(RuleLogic.inTimeWindow(1, 23 * 60 + 59, 0)) + } + @Test fun dayBits() { assertTrue(RuleLogic.dayBitSet(0b1111111, Calendar.SUNDAY)) assertTrue(RuleLogic.dayBitSet(0b0000010, Calendar.MONDAY)) @@ -93,6 +180,28 @@ class RuleLogicTest { assertTrue(RuleLogic.dayBitSet(0b1111111, Calendar.SATURDAY)) } + @Test fun dayMaskZeroMatchesNoDay() { + for (day in Calendar.SUNDAY..Calendar.SATURDAY) { + assertFalse(RuleLogic.dayBitSet(0, day)) + } + } + + @Test fun dayMaskAllDaysMatchesEveryDay() { + for (day in Calendar.SUNDAY..Calendar.SATURDAY) { + assertTrue(RuleLogic.dayBitSet(0b1111111, day)) + } + } + + @Test fun dayMaskSundayBoundary() { + assertTrue(RuleLogic.dayBitSet(0b0000001, Calendar.SUNDAY)) + assertFalse(RuleLogic.dayBitSet(0b0000001, Calendar.MONDAY)) + } + + @Test fun dayMaskSaturdayBoundary() { + assertTrue(RuleLogic.dayBitSet(0b1000000, Calendar.SATURDAY)) + assertFalse(RuleLogic.dayBitSet(0b1000000, Calendar.SUNDAY)) + } + @Test fun cooldownAllowsWhenDisabled() { assertTrue(RuleLogic.cooldownOk(0, 1000L, 1000L)) assertTrue(RuleLogic.cooldownOk(-5, 1000L, 1000L))