Skip to content
This repository was archived by the owner on Mar 17, 2024. It is now read-only.
This repository was archived by the owner on Mar 17, 2024. It is now read-only.

LEAccount Warning if LetsEncrypt omits contact #126

Description

@skwirrel

We have experienced occassional warnings generated in LEAccount.php around line 136:

            $this->id = isset($post['body']['id']) ? $post['body']['id'] : '';
            $this->key = $post['body']['key'];
>>>     $this->contact = $post['body']['contact'];   <<< HERE

I'm not entirely sure why but it seems that LetsEncrypt sometimes fails to return a contact. Using a null coalescing operator to supply a default empty array fixed this for us thus:
$this->contact = $post['body']['contact'] ?? [];

Hope that helps.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions