Repository navigation
docs: drop non-existent "make environment" target - #9
Open
dajiaohuang wants to merge 1 commit into
Open
dajiaohuang wants to merge 1 commit into
dajiaohuang wants to merge 1 commit into
Conversation
The Windows target Makefile that the examples role clones (kafl.targets/windows_x86_64/Makefile) only defines the targets init, revoke, gui, compile, target and no_target. Following the usage guide's third option fails with "No rule to make target 'environment'", so only keep the two targets that exist.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Error
Section 6 of
docs/installation/README.mdsays to pick one of three targets built by theexamples role to load the driver/harness into the guest, and lists:
The Makefile that
make deploy -- --tags examples,examples-template-windowsclones(
kafl.targets/windows_x86_64/Makefile,examples_urlindeploy/intellabs/kafl/roles/examples/defaults/main.yml) defines onlyinit,revoke,gui,compile,targetandno_target. Runningmake environmentin that directoryfails with:
Change
Remove the
make environmentoption so the guide only lists targets that exist. Manualsetup is still possible with the
vagrant up --no-provisionstep that the guide alreadyuses in item 2.
Validation
kafl.targets@master(the repository cloned by the examplesrole); the target list above is the complete set of rules in that Makefile.