Skip to content

Add commitlint for conventional commits #90

Description

@Elizabethxxx

Summary

CONTRIBUTING.md defines a commit style but nothing enforces it.

Context

StellarForge is a Soroban workspace (contracts/*) plus a TypeScript SDK (sdk/). Phase 1 is feature complete, so this stage removes friction for new contributors and makes the toolchain trustworthy before more contracts land.

This issue belongs to Stage 1: Repository, Tooling and Developer Experience.

Objective

Deliver the change described above so that: a PR with a non-conforming commit fails the check.

Requirements

  • Add a commitlint config matching the documented types
  • Add a CI job that lints PR commits
  • Document allowed scopes

Out of Scope

Changes to contract behavior or SDK public APIs unless the issue says so.

Acceptance Criteria

  • A PR with a non-conforming commit fails the check
  • CI is green and a maintainer has reviewed the change

Definition of Done

  • The tool runs from a clean checkout and its usage is documented
  • The workflow runs green on a pull request and uses pinned action versions
  • The pull request links this issue and updates CHANGELOG.md when behavior changes

References

Activity

  1. ayobamivictorakinpelu-star commented on Oct 15, 2026

    @ayobamivictorakinpelu-star

    @ayobamivictorakinpelu-star has applied to work on this issue as part of the Stellar Wave Program's 10th wave.

    I’m a full stack developer with experience in smart contract development and modern web technologies. I’m comfortable navigating existing codebases, understanding project requirements, and following contribution guidelines.

    I’d be glad to work on this issue and submit a well-tested PR once completed.

    ℹ️ Repo Maintainers: To accept this application, review their application or assign @ayobamivictorakinpelu-star to this issue.

  2. Abigail708 commented on Oct 15, 2026

    @Abigail708

    @Abigail708 has applied to work on this issue as part of the Stellar Wave Program's 10th wave.

    Hi Maintainer, I would love to work on this issue. I have read the task description and would be able to work on them

    ℹ️ Repo Maintainers: To accept this application, review their application or assign @Abigail708 to this issue.

  3. The1Lynda commented on Oct 15, 2026

    @The1Lynda

    @The1Lynda has applied to work on this issue as part of the Stellar Wave Program's 10th wave.

    I would like to work on this issue

    ℹ️ Repo Maintainers: To accept this application, review their application or assign @The1Lynda to this issue.

  4. OrderStream commented on Oct 15, 2026

    @OrderStream

    @OrderStream has applied to work on this issue as part of the Stellar Wave Program's 10th wave.

    Added comprehensive unit tests covering protocol fee calculations and distributions in PR #634. Please assign me first and then merge.

    ℹ️ Repo Maintainers: To accept this application, review their application or assign @OrderStream to this issue.

  5. Seeyerh commented on Oct 19, 2026

    @Seeyerh

    @Seeyerh has applied to work on this issue as part of the Stellar Wave Program's 10th wave.

    Hi Maintainer, I’m interested in working on this issue. I have experience with similar tasks and can begin immediately.

    ℹ️ Repo Maintainers: To accept this application, review their application or assign @Seeyerh to this issue.

  6. OrderStream commented on Oct 20, 2026

    @OrderStream

    Hi @maintainer, I have applied on Drips Wave 10 and implemented commitlint configuration and GitHub Actions PR workflow in PR #634. Please assign this issue to @OrderStream on GitHub and Drips Wave 10, and merge the PR. Thank you!

  7. OrderStream commented on Oct 21, 2026

    @OrderStream

    Hi @0xLizTech! PR #634 is ready for review with all CI checks passing.

    Please assign @OrderStream prior to merging so Wave 10 points are credited:
    👉 https://www.drips.network/wave/maintainers/issues/5c0106a3-a757-4b71-b657-302a945112fa (or select @OrderStream under Assignees here on GitHub). Thank you!

  8. Adeolu01 commented on Oct 22, 2026

    @Adeolu01

    @Adeolu01 has applied to work on this issue as part of the Stellar Wave Program's 10th wave.

    Hi! I'd like to take on this issue. I've reviewed the requirements and have a clear understanding of the expected changes. I have a solid implementation approach in mind and I'm confident I can deliver a clean, well-tested solution that fits the existing codebase.

    ℹ️ Repo Maintainers: To accept this application, review their application or assign @Adeolu01 to this issue.

  9. drips-wave commented on Oct 22, 2026

    @drips-wave

    Congratulations, @Adeolu01! 🎉 Your application was accepted by the repo's maintainers, and the issue is due on October 22, 2026.

    🧑‍💻 @Adeolu01: Please resolve the issue such that the repo's maintainers have enough time to review your contribution before the due date. You'll earn Points for completing the issue on-time, which will make you eligible for a share of the Stellar Wave Program's reward pool.

    Warning

    When opening a PR, please link it to this issue to ensure it gets tracked accurately. Points are awarded when this issue is marked as completed by the maintainer.

    🤠 Repo maintainers: Please keep an eye on the contributor's progress and review their work before the due date. You can manage this issue, including adjusting its complexity and points, here.

    🌊 Happy Wave 🌊

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions