Repository navigation
fix(debug): match Rust function breakpoints and cover recovered frames - #162
Merged
Merged
Conversation
Contributor
Code Metrics Report
Details | | next (b164058) | #162 (d9b18d8) | +/- |
|-----------|----------------|----------------|-------|
+ | Coverage | 81.3% | 81.3% | +0.0% |
| Files | 69 | 69 | 0 |
| Lines | 11973 | 11978 | +5 |
+ | Covered | 9743 | 9748 | +5 |Code coverage of files in pull request scope (81.4% → 81.5%, patch 100.0%)
Reported by octocov |
This was referenced Oct 21, 2026
Match raw assembly context names and their demangled Rust source names so function breakpoints agree with stack traces, including without std. Retain focused frame and serialized-package DAP regressions from the original call-frame work, plus compact inline-range serialization and gap coverage. Preserve the current finish and step-out policy of stopping at a caller assembly operation, including tail-only recursive calls. Co-authored-by: djole <djolertrk@gmail.com>
bitwalker
force-pushed
the
feat/vm-036-call-frames
branch
from
October 21, 2026 00:17
4fed098 to
a5dd821
Compare
bitwalker
changed the title
bitwalker
marked this pull request as ready for review
October 21, 2026 00:19
bitwalker
approved these changes
Oct 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Function breakpoints used raw assembly context names, so a breakpoint such as
break in foo::innercould miss a Rust-mangled procedure even when its backtrace displayed the source name. Match both the raw symbol and its demangled name, including in engine builds without default features.Retain focused regression coverage from the original #162 and the compact inline-range roundtrip, gap, endpoint, and ordering test from #163. Coverage includes repeated invocation identities, same-named physical and source-inline frames, serialized-package DAP traces, plain and dynamic calls, tail wrappers, branches, loops, identical bodies, and reload.
Preserve the current
finish/DAP step-out policy: stop at the next caller assembly operation, skipping tail-only recursive callers that have only control cycles remaining. Existing VM 0.36.2 recovery, frame-event fallback, and replay call tracing stay in place.