fix(logging): monitor configured service reachability#2360
Open
kkovaacs wants to merge 1 commit into
Open
Conversation
sergerad
reviewed
Jul 21, 2026
| block_prover_monitor | ||
| .monitor::<RemoteProverClient>("block-prover", shutdown.clone()), | ||
| ); | ||
| } |
Collaborator
There was a problem hiding this comment.
Should this monitoring not be inherent in the connections that the sequencer has to the various components? Why is a separate monitor required?
Collaborator
Author
There was a problem hiding this comment.
Could be, but then we wouldn't report unreachable dependencies for services that are lazy-initialized. (See the original report in issue #2330.)
kkovaacs
force-pushed
the
krisztian/log-startup-shutdown-events
branch
from
July 27, 2026 12:47
ef2ab3d to
06268f5
Compare
kkovaacs
force-pushed
the
krisztian/log-service-availability-events
branch
from
July 27, 2026 12:54
cb95123 to
f1db805
Compare
kkovaacs
force-pushed
the
krisztian/log-service-availability-events
branch
from
July 27, 2026 13:03
f1db805 to
91720c9
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Partially resolves point 5 of #2330
Changelog