Support textless diarization in transcription details - #584
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #581.
The details endpoint inherits the transcription-only check and rejects pure diarization results before serializing their speaker turns. Relax that check only for diarization tasks on
/v1/audio/transcriptions/details.textvalue when diarization has no transcript, without dereferencing the absent optional.The change is limited to
app/server/runtime.cpp; no model or framework changes.Validation
Rebuilt the Debug server and sent sequential real HTTP requests using CUDA and Sortformer v1 Q8 / Parakeet TDT Q8:
stream=trueon the details endpoint still returns HTTP 400.Sortformer v2 was reviewed for the same result contract but was not runtime-tested.